[GitHub] [flink] flinkbot commented on pull request #21482: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

2022-12-09 Thread GitBox
flinkbot commented on PR #21482: URL: https://github.com/apache/flink/pull/21482#issuecomment-1345177997 ## CI report: * 8dc9f87eb02548f30ca7ea1bacf785f538ad75e9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] GOODBOY008 commented on pull request #21481: [FLINK-30357] Wrong link in connector/jdbc doc.

2022-12-09 Thread GitBox
GOODBOY008 commented on PR #21481: URL: https://github.com/apache/flink/pull/21481#issuecomment-1345177869 @leonardBang Please code review. If you are available. Also I had open a [pr](https://github.com/apache/flink/pull/21482) for branch `release-1.16`. -- This is an automated message f

[GitHub] [flink] GOODBOY008 opened a new pull request, #21482: [FLINK-30357][doc] Wrong link in connector/jdbc doc.

2022-12-09 Thread GitBox
GOODBOY008 opened a new pull request, #21482: URL: https://github.com/apache/flink/pull/21482 For flink 1.16 doc. Link https://issues.apache.org/jira/browse/FLINK-30357. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [flink] flinkbot commented on pull request #21481: [FLINK-30357] Wrong link in connector/jdbc doc.

2022-12-09 Thread GitBox
flinkbot commented on PR #21481: URL: https://github.com/apache/flink/pull/21481#issuecomment-1345177058 ## CI report: * c6f6b718c01e4b1bb12c61f01e6efb9a250bd10f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30357) Wrong link in connector/jdbc doc.

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30357: --- Labels: doc-site pull-request-available (was: doc-site) > Wrong link in connector/jdbc doc.

[GitHub] [flink] GOODBOY008 opened a new pull request, #21481: [FLINK-30357] Wrong link in connector/jdbc doc.

2022-12-09 Thread GitBox
GOODBOY008 opened a new pull request, #21481: URL: https://github.com/apache/flink/pull/21481 Link https://issues.apache.org/jira/browse/FLINK-30357. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (FLINK-30357) Wrong link in connector/jdbc doc.

2022-12-09 Thread Aiden Gong (Jira)
Aiden Gong created FLINK-30357: -- Summary: Wrong link in connector/jdbc doc. Key: FLINK-30357 URL: https://issues.apache.org/jira/browse/FLINK-30357 Project: Flink Issue Type: Improvement

[GitHub] [flink] fredia commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata

2022-12-09 Thread GitBox
fredia commented on PR #21405: URL: https://github.com/apache/flink/pull/21405#issuecomment-1345160608 @rkhachatryan Thanks for reviewing. > 1. Have you considered splitting StateChange class into StateChange and StateChange? I splited the constructor of StateChange into `StateCha

[GitHub] [flink] fredia commented on a diff in pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata

2022-12-09 Thread GitBox
fredia commented on code in PR #21405: URL: https://github.com/apache/flink/pull/21405#discussion_r1044999240 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/StateChange.java: ## @@ -26,14 +26,21 @@ @Internal public class StateChange implements Serializ

[GitHub] [flink] jiexray commented on pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-09 Thread GitBox
jiexray commented on PR #21410: URL: https://github.com/apache/flink/pull/21410#issuecomment-1345145853 Hello @snuyanzin, I have fixed your comments with a new commit. The modifications includes: - Remove public statement from test function - Replace `ExceptionUtils.findThrowable`

[GitHub] [flink] jiexray commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-09 Thread GitBox
jiexray commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1044988468 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java: ## @@ -959,24 +947,44 @@ public void testKryoRegisteringRestoreResilienceWithD

[GitHub] [flink] 1996fanrui commented on pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

2022-12-09 Thread GitBox
1996fanrui commented on PR #21368: URL: https://github.com/apache/flink/pull/21368#issuecomment-1345078542 Thanks everyone who reviewed šŸ‘šŸ» -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [flink-ml] lindong28 commented on pull request #190: [hotfix] Improve nightly build Github actions

2022-12-09 Thread GitBox
lindong28 commented on PR #190: URL: https://github.com/apache/flink-ml/pull/190#issuecomment-1344985863 @yunfengzhou-hub @zhipeng93 Could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [flink-ml] lindong28 opened a new pull request, #190: [hotfix] Improve nightly build Github actions

2022-12-09 Thread GitBox
lindong28 opened a new pull request, #190: URL: https://github.com/apache/flink-ml/pull/190 ## What is the purpose of the change Improve nightly build Github actions. ## Brief change log This PR made the following changes: - Skip triggering nightly build on forked repo

[GitHub] [flink] ashmeet-kandhari commented on a diff in pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-12-09 Thread GitBox
ashmeet-kandhari commented on code in PR #20991: URL: https://github.com/apache/flink/pull/20991#discussion_r1044911351 ## flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/KafkaSourceLegacyITCase.java: ## @@ -37,7 +37,7 @@ public Kafka

[GitHub] [flink] snuyanzin commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-09 Thread GitBox
snuyanzin commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1044823025 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java: ## @@ -959,24 +947,44 @@ public void testKryoRegisteringRestoreResilienceWit

[GitHub] [flink] SmirAlex commented on pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-12-09 Thread GitBox
SmirAlex commented on PR #20919: URL: https://github.com/apache/flink/pull/20919#issuecomment-1344609982 > After some offline chat with @zentol about it, I came to the conclusion that it's really not the right location for such a big change. We should focus on stabilizing the test here. I m

[GitHub] [flink] SmirAlex commented on a diff in pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-12-09 Thread GitBox
SmirAlex commented on code in PR #20919: URL: https://github.com/apache/flink/pull/20919#discussion_r1044681283 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/table/lookup/fullcache/CacheLoader.java: ## @@ -59,11 +65,11 @@ public abstra

[GitHub] [flink-connector-cassandra] RyanSkraba commented on pull request #3: [FLINK-26822] Add Cassandra Source

2022-12-09 Thread GitBox
RyanSkraba commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1344580035 Hey @echauchot -- I've had some delays, but I'm still looking at this! I'm bumping to the top of my to do list. -- This is an automated message from the Apache Git Serv

[GitHub] [flink] jiexray commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-09 Thread GitBox
jiexray commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1044638321 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java: ## @@ -1080,23 +1088,41 @@ public void testKryoRegisteringRestoreResilienceWit

[GitHub] [flink] jiexray commented on a diff in pull request #21410: [FLINK-29776][flink-statebackend-changelog][JUnit5 Migration]Module: flink-statebackend-changelog.

2022-12-09 Thread GitBox
jiexray commented on code in PR #21410: URL: https://github.com/apache/flink/pull/21410#discussion_r1044637743 ## flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java: ## @@ -959,24 +947,44 @@ public void testKryoRegisteringRestoreResilienceWithD

[jira] [Updated] (FLINK-30353) Limit concurrency for external connector repositories

2022-12-09 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-30353: - Summary: Limit concurrency for external connector repositories (was: Enable concurrency

[jira] [Commented] (FLINK-27916) HybridSourceReaderTest.testReader failed with AssertionError

2022-12-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645380#comment-17645380 ] Matthias Pohl commented on FLINK-27916: --- https://dev.azure.com/apache-flink/apache

[GitHub] [flink] XComp commented on pull request #21479: [BP-1.16][FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-09 Thread GitBox
XComp commented on PR #21479: URL: https://github.com/apache/flink/pull/21479#issuecomment-1344510204 Test instability documented in FLINK-27916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [flink] XComp commented on pull request #21480: [BP-1.15][FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-09 Thread GitBox
XComp commented on PR #21480: URL: https://github.com/apache/flink/pull/21480#issuecomment-1344509360 Force-pushed an updated after a [comment in the parent PR](https://github.com/apache/flink/pull/21478#discussion_r1044526123) -- This is an automated message from the Apache Git Service.

[GitHub] [flink] XComp commented on pull request #21479: [BP-1.16][FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-09 Thread GitBox
XComp commented on PR #21479: URL: https://github.com/apache/flink/pull/21479#issuecomment-1344509270 Force-pushed an updated after a [comment in the parent PR](https://github.com/apache/flink/pull/21478#discussion_r1044526123) -- This is an automated message from the Apache Git Service.

[GitHub] [flink] XComp commented on a diff in pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-09 Thread GitBox
XComp commented on code in PR #21478: URL: https://github.com/apache/flink/pull/21478#discussion_r1044619071 ## flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/PulsarUnorderedSourceITCase.java: ## @@ -32,12 +32,14 @@ import org.apa

[jira] [Created] (FLINK-30356) Update NOTICE files to say "Apache Flink AWS connectors"

2022-12-09 Thread Danny Cranmer (Jira)
Danny Cranmer created FLINK-30356: - Summary: Update NOTICE files to say "Apache Flink AWS connectors" Key: FLINK-30356 URL: https://issues.apache.org/jira/browse/FLINK-30356 Project: Flink Is

[jira] [Resolved] (FLINK-30165) [JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

2022-12-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-30165. --- Assignee: Rui Fan Resolution: Fixed master: 5f924bc84227a3a6c67b44e82c45fe444393f577

[GitHub] [flink] XComp merged pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

2022-12-09 Thread GitBox
XComp merged PR #21368: URL: https://github.com/apache/flink/pull/21368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.

[GitHub] [flink] XComp commented on pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

2022-12-09 Thread GitBox
XComp commented on PR #21368: URL: https://github.com/apache/flink/pull/21368#issuecomment-1344487115 CI is green. About the rerun: It would be also nice to investigate build failures. The build failures we've seen in this PR's CI can be explained with FLINK-29427 and FLINK-30355. The latte

[jira] [Created] (FLINK-30355) crictl causes long wait in e2e tests

2022-12-09 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-30355: - Summary: crictl causes long wait in e2e tests Key: FLINK-30355 URL: https://issues.apache.org/jira/browse/FLINK-30355 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-29427) LookupJoinITCase failed with classloader problem

2022-12-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645362#comment-17645362 ] Matthias Pohl commented on FLINK-29427: --- https://dev.azure.com/apache-flink/apache

[GitHub] [flink] XComp commented on pull request #20919: [FLINK-29405] Fix unstable test InputFormatCacheLoaderTest

2022-12-09 Thread GitBox
XComp commented on PR #20919: URL: https://github.com/apache/flink/pull/20919#issuecomment-1344469683 After some offline chat with @zentol about it, I came to the conclusion that it's really not the right location for such a big change. We should focus on stabilizing the test here. I moved

[jira] [Updated] (FLINK-30354) Reducing the number of ThreadPools in LookupFullCache and related cache-loading classes

2022-12-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-30354: -- Description: In the course of reviewing FLINK-29405, I came up with a proposal to reduce the

[jira] [Created] (FLINK-30354) Reducing the number of ThreadPools in LookupFullCache and related cache-loading classes

2022-12-09 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-30354: - Summary: Reducing the number of ThreadPools in LookupFullCache and related cache-loading classes Key: FLINK-30354 URL: https://issues.apache.org/jira/browse/FLINK-30354

[jira] [Commented] (FLINK-30314) Unable to read all records from compressed line-delimited JSON files using Table API

2022-12-09 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645356#comment-17645356 ] Etienne Chauchot commented on FLINK-30314: -- yes that is what I had in mind to u

[jira] [Updated] (FLINK-30349) Sync missing HBase e2e tests to external repo

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30349: --- Labels: pull-request-available (was: ) > Sync missing HBase e2e tests to external repo > --

[GitHub] [flink-connector-hbase] boring-cyborg[bot] commented on pull request #5: [FLINK-30349] Sync missing HBase e2e tests to external repo

2022-12-09 Thread GitBox
boring-cyborg[bot] commented on PR #5: URL: https://github.com/apache/flink-connector-hbase/pull/5#issuecomment-138646 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is an

[GitHub] [flink-connector-hbase] MartijnVisser opened a new pull request, #5: [FLINK-30349] Sync missing HBase e2e tests to external repo

2022-12-09 Thread GitBox
MartijnVisser opened a new pull request, #5: URL: https://github.com/apache/flink-connector-hbase/pull/5 + hotfix to set correct version number -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] liyubin117 commented on pull request #21182: [FLINK-29679][table] Migrate to new schema framework & show column comment

2022-12-09 Thread GitBox
liyubin117 commented on PR #21182: URL: https://github.com/apache/flink/pull/21182#issuecomment-131038 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink-connector-rabbitmq] MartijnVisser commented on pull request #3: [FLINK-30279] Move existing RabbitMQ connector code from Flink repo to dedicated RabbitMQ repo

2022-12-09 Thread GitBox
MartijnVisser commented on PR #3: URL: https://github.com/apache/flink-connector-rabbitmq/pull/3#issuecomment-1344413835 > missing production tests Fixed > Looks like this is again using the 1.17-SNAPSHOT code instead of 1.16.0. Also fixed -- This is an automated mess

[GitHub] [flink] snuyanzin commented on a diff in pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCas

2022-12-09 Thread GitBox
snuyanzin commented on code in PR #21478: URL: https://github.com/apache/flink/pull/21478#discussion_r1044526123 ## flink-connectors/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/source/PulsarUnorderedSourceITCase.java: ## @@ -32,12 +32,14 @@ import org

[jira] [Comment Edited] (FLINK-30314) Unable to read all records from compressed line-delimited JSON files using Table API

2022-12-09 Thread Dmitry Yaraev (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645326#comment-17645326 ] Dmitry Yaraev edited comment on FLINK-30314 at 12/9/22 2:45 PM: --

[jira] [Comment Edited] (FLINK-30314) Unable to read all records from compressed line-delimited JSON files using Table API

2022-12-09 Thread Dmitry Yaraev (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645326#comment-17645326 ] Dmitry Yaraev edited comment on FLINK-30314 at 12/9/22 2:44 PM: --

[GitHub] [flink-connector-pulsar] MartijnVisser commented on a diff in pull request #4: [FLINK-30336][BP 3.0] Sync missing e2e tests

2022-12-09 Thread GitBox
MartijnVisser commented on code in PR #4: URL: https://github.com/apache/flink-connector-pulsar/pull/4#discussion_r1044521120 ## .github/workflows/ci.yml: ## @@ -32,6 +32,10 @@ on: required: true type: boolean +concurrency: + group: pr-${{ github.ref }} Re

[GitHub] [flink-connector-pulsar] MartijnVisser commented on a diff in pull request #4: [FLINK-30336][BP 3.0] Sync missing e2e tests

2022-12-09 Thread GitBox
MartijnVisser commented on code in PR #4: URL: https://github.com/apache/flink-connector-pulsar/pull/4#discussion_r1044521327 ## flink-connector-pulsar-e2e-tests/pom.xml: ## @@ -77,6 +73,49 @@ under the License. + + +

[jira] [Created] (FLINK-30353) Enable concurrency for external connector repositories

2022-12-09 Thread Martijn Visser (Jira)
Martijn Visser created FLINK-30353: -- Summary: Enable concurrency for external connector repositories Key: FLINK-30353 URL: https://issues.apache.org/jira/browse/FLINK-30353 Project: Flink Is

[jira] [Comment Edited] (FLINK-30314) Unable to read all records from compressed line-delimited JSON files using Table API

2022-12-09 Thread Dmitry Yaraev (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645326#comment-17645326 ] Dmitry Yaraev edited comment on FLINK-30314 at 12/9/22 2:42 PM: --

[jira] [Commented] (FLINK-30314) Unable to read all records from compressed line-delimited JSON files using Table API

2022-12-09 Thread Dmitry Yaraev (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645326#comment-17645326 ] Dmitry Yaraev commented on FLINK-30314: --- ??We would need to uncompress them to a r

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #3: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors (documentation)

2022-12-09 Thread GitBox
reta commented on code in PR #3: URL: https://github.com/apache/flink-connector-opensearch/pull/3#discussion_r1044510808 ## docs/content/docs/connectors/table/opensearch.md: ## @@ -0,0 +1,286 @@ +--- +title: Opensearch +weight: 7 +type: docs +aliases: + - /dev/table/connectors

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #3: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors (documentation)

2022-12-09 Thread GitBox
reta commented on code in PR #3: URL: https://github.com/apache/flink-connector-opensearch/pull/3#discussion_r1044510624 ## docs/content/docs/connectors/table/opensearch.md: ## @@ -0,0 +1,286 @@ +--- +title: Opensearch +weight: 7 +type: docs +aliases: + - /dev/table/connectors

[jira] [Closed] (FLINK-21239) Upgrade Calcite version to 1.28

2022-12-09 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther closed FLINK-21239. Fix Version/s: 1.17.0 Resolution: Fixed Fixed in master: c05eab6bd6e8932f9f1ca0b78b5d6c206e

[jira] [Commented] (FLINK-29540) SubQueryAntiJoinTest started to fail after Calcite 1.27

2022-12-09 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645322#comment-17645322 ] Timo Walther commented on FLINK-29540: -- [~Sergey Nuyanzin] I moved this to 1.29 upd

[GitHub] [flink-connector-elasticsearch] reta commented on pull request #49: [FLINK-30352] [connectors/elasticsearch] Document missing configuration properties

2022-12-09 Thread GitBox
reta commented on PR #49: URL: https://github.com/apache/flink-connector-elasticsearch/pull/49#issuecomment-1344376924 @zentol please take a look, closing the gap in Elasticsearch configuration documentation, thank you -- This is an automated message from the Apache Git Service. To respo

[jira] [Updated] (FLINK-29540) SubQueryAntiJoinTest started to fail after Calcite 1.27

2022-12-09 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-29540: - Parent Issue: FLINK-29932 (was: FLINK-21239) > SubQueryAntiJoinTest started to fail after Calci

[jira] [Updated] (FLINK-29237) RexSimplify can not be removed after update to calcite 1.27

2022-12-09 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-29237: - Parent Issue: FLINK-29932 (was: FLINK-21239) > RexSimplify can not be removed after update to c

[jira] [Updated] (FLINK-30352) [Connectors][Elasticsearch] Document missing configuration properties

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30352: --- Labels: pull-request-available (was: ) > [Connectors][Elasticsearch] Document missing confi

[GitHub] [flink-connector-elasticsearch] boring-cyborg[bot] commented on pull request #49: FLINK-30352: [Connectors/Elasticsearch] Document missing configuration properties

2022-12-09 Thread GitBox
boring-cyborg[bot] commented on PR #49: URL: https://github.com/apache/flink-connector-elasticsearch/pull/49#issuecomment-1344371414 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- T

[GitHub] [flink-connector-elasticsearch] reta opened a new pull request, #49: FLINK-30352: [Connectors/Elasticsearch] Document missing configuration properties

2022-12-09 Thread GitBox
reta opened a new pull request, #49: URL: https://github.com/apache/flink-connector-elasticsearch/pull/49 There is a number of configuration properties which are not documented: - sink.delivery-guarantee - connection.request-timeout - connection.timeout - socket.timeout Ā 

[GitHub] [flink] twalthr closed pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0

2022-12-09 Thread GitBox
twalthr closed pull request #21203: [FLINK-21239][Table SQL/API] Upgrade Calcite to 1.28.0 URL: https://github.com/apache/flink/pull/21203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Updated] (FLINK-30352) [Connectors][Elasticsearch] Document missing configuration properties

2022-12-09 Thread Andriy Redko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andriy Redko updated FLINK-30352: - Description: There is a number of configuration properties which are not documented: -Ā sink.del

[jira] [Created] (FLINK-30352) [Connectors][Elasticsearch] Document missing configuration properties

2022-12-09 Thread Andriy Redko (Jira)
Andriy Redko created FLINK-30352: Summary: [Connectors][Elasticsearch] Document missing configuration properties Key: FLINK-30352 URL: https://issues.apache.org/jira/browse/FLINK-30352 Project: Flink

[jira] [Updated] (FLINK-30352) [Connectors][Elasticsearch] Document missing configuration properties

2022-12-09 Thread Andriy Redko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andriy Redko updated FLINK-30352: - Description: There is a number of configuration properties which are not documented: - sink.del

[jira] [Updated] (FLINK-30352) [Connectors][Elasticsearch] Document missing configuration properties

2022-12-09 Thread Andriy Redko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andriy Redko updated FLINK-30352: - Priority: Minor (was: Major) > [Connectors][Elasticsearch] Document missing configuration prope

[GitHub] [flink] zentol commented on pull request #21477: [FLINK-30350][build] Use default location for dependency reduced pom

2022-12-09 Thread GitBox
zentol commented on PR #21477: URL: https://github.com/apache/flink/pull/21477#issuecomment-1344365713 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #3: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors (documentation)

2022-12-09 Thread GitBox
reta commented on code in PR #3: URL: https://github.com/apache/flink-connector-opensearch/pull/3#discussion_r1044469621 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/table/OpensearchConnectorOptions.java: ## @@ -143,7 +143,7 @@ public class

[GitHub] [flink] luoyuxia commented on pull request #21316: [FLINK-30019] Remove the unused HiveTableFileInputFormat in hive conn…

2022-12-09 Thread GitBox
luoyuxia commented on PR #21316: URL: https://github.com/apache/flink/pull/21316#issuecomment-1344331351 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #3: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors (documentation)

2022-12-09 Thread GitBox
reta commented on code in PR #3: URL: https://github.com/apache/flink-connector-opensearch/pull/3#discussion_r1044469621 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/table/OpensearchConnectorOptions.java: ## @@ -143,7 +143,7 @@ public class

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #3: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors (documentation)

2022-12-09 Thread GitBox
reta commented on code in PR #3: URL: https://github.com/apache/flink-connector-opensearch/pull/3#discussion_r1044467982 ## docs/content/docs/connectors/table/opensearch.md: ## @@ -0,0 +1,286 @@ +--- +title: Opensearch +weight: 7 +type: docs +aliases: + - /dev/table/connectors

[GitHub] [flink] 1996fanrui commented on pull request #21368: [FLINK-30165][runtime][JUnit5 Migration] Migrate unaligned checkpoint related tests under flink-runtime module to junit5

2022-12-09 Thread GitBox
1996fanrui commented on PR #21368: URL: https://github.com/apache/flink/pull/21368#issuecomment-1344305894 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #3: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors (documentation)

2022-12-09 Thread GitBox
reta commented on code in PR #3: URL: https://github.com/apache/flink-connector-opensearch/pull/3#discussion_r103885 ## docs/content/docs/connectors/datastream/opensearch.md: ## @@ -0,0 +1,328 @@ +--- +title: Opensearch +weight: 5 +type: docs +aliases: + - /dev/connectors/

[jira] [Commented] (FLINK-30314) Unable to read all records from compressed line-delimited JSON files using Table API

2022-12-09 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645294#comment-17645294 ] Etienne Chauchot commented on FLINK-30314: -- Actually despite the comment on unc

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #3: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors (documentation)

2022-12-09 Thread GitBox
reta commented on code in PR #3: URL: https://github.com/apache/flink-connector-opensearch/pull/3#discussion_r100646 ## docs/content/docs/connectors/table/opensearch.md: ## @@ -0,0 +1,286 @@ +--- +title: Opensearch +weight: 7 +type: docs +aliases: + - /dev/table/connectors

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #3: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors (documentation)

2022-12-09 Thread GitBox
reta commented on code in PR #3: URL: https://github.com/apache/flink-connector-opensearch/pull/3#discussion_r100312 ## docs/content/docs/connectors/datastream/opensearch.md: ## @@ -0,0 +1,328 @@ +--- +title: Opensearch +weight: 5 +type: docs +aliases: + - /dev/connectors/

[GitHub] [flink-connector-opensearch] reta commented on pull request #3: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors (documentation)

2022-12-09 Thread GitBox
reta commented on PR #3: URL: https://github.com/apache/flink-connector-opensearch/pull/3#issuecomment-1344290837 > In the original PR you mentioned this: > > ``` > any mentions and uses of mapping types have been removed: it is deprecated feature, scheduled for removal (the indic

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #3: [FLINK-26822] Add Cassandra Source

2022-12-09 Thread GitBox
echauchot commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1344284613 > > Is there anything I can do to help the review ? > > For better or worse, no :) > > Holidays are coming up so I won't review it this year (scream) at the ver

[jira] [Commented] (FLINK-30314) Unable to read all records from compressed line-delimited JSON files using Table API

2022-12-09 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17645291#comment-17645291 ] Etienne Chauchot commented on FLINK-30314: -- Yes I agree, something needs to be

[jira] [Updated] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

2022-12-09 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul updated FLINK-27246: Affects Version/s: 1.15.3 1.16.0 > Code of method > "processElement(Lorg/a

[jira] [Assigned] (FLINK-27246) Code of method "processElement(Lorg/apache/flink/streaming/runtime/streamrecord/StreamRecord;)V" of class "HashAggregateWithKeys$9211" grows beyond 64 KB

2022-12-09 Thread Fabian Paul (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Paul reassigned FLINK-27246: --- Assignee: Krzysztof Chmielewski > Code of method > "processElement(Lorg/apache/flink/strea

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-12-09 Thread GitBox
Jiabao-Sun commented on PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#issuecomment-1344276831 Thanks @twalthr for the detailed review. Please help review it again when you have time. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-12-09 Thread GitBox
mas-chen commented on code in PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1044426605 ## flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/pom.xml: ## @@ -18,230 +18,230 @@ specific language governing permissions and limitatio

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-12-09 Thread GitBox
mas-chen commented on code in PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1044426268 ## pom.xml: ## @@ -0,0 +1,506 @@ + + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"; + xmlns="http://maven.apache.org/

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-12-09 Thread GitBox
mas-chen commented on code in PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1044426003 ## flink-sql-connector-kafka/pom.xml: ## @@ -24,20 +24,16 @@ under the License. 4.0.0 - flink-connectors org.

[GitHub] [flink-connector-kafka] mas-chen commented on a diff in pull request #1: [FLINK-30052][Connectors/Kafka] Move existing Kafka connector code from Flink repo to dedicated Kafka repo

2022-12-09 Thread GitBox
mas-chen commented on code in PR #1: URL: https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1044425679 ## flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/pom.xml: ## @@ -18,230 +18,230 @@ specific language governing permissions and limitatio

[GitHub] [flink-connector-cassandra] zentol commented on pull request #3: [FLINK-26822] Add Cassandra Source

2022-12-09 Thread GitBox
zentol commented on PR #3: URL: https://github.com/apache/flink-connector-cassandra/pull/3#issuecomment-1344270870 > Is there anything I can do to help the review ? For better or worse, no :) Holidays are coming up so I won't review it this year (:scream:) at the very least.

[GitHub] [flink] zentol commented on a diff in pull request #21477: [FLINK-30350][build] Use default location for dependency reduced pom

2022-12-09 Thread GitBox
zentol commented on code in PR #21477: URL: https://github.com/apache/flink/pull/21477#discussion_r1044418411 ## flink-dist/pom.xml: ## @@ -688,9 +688,7 @@ under the License.

[GitHub] [flink] flinkbot commented on pull request #21480: [BP-1.15][FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-09 Thread GitBox
flinkbot commented on PR #21480: URL: https://github.com/apache/flink/pull/21480#issuecomment-1344253019 ## CI report: * b9b3c2f6f171b40a192d61d57fd01630c0023694 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21479: [BP-1.16][FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-09 Thread GitBox
flinkbot commented on PR #21479: URL: https://github.com/apache/flink/pull/21479#issuecomment-1344252908 ## CI report: * 0cfb751ff3962e9bb8f0fadadf9f51ebaa99ae93 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-09 Thread GitBox
flinkbot commented on PR #21478: URL: https://github.com/apache/flink/pull/21478#issuecomment-1344252801 ## CI report: * 3fdf3b41711c4f857d2b21fdbf96c1057f3b7811 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] XComp opened a new pull request, #21480: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-09 Thread GitBox
XComp opened a new pull request, #21480: URL: https://github.com/apache/flink/pull/21480 1.15 backport PR for parent PR https://github.com/apache/flink/pull/21478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] XComp opened a new pull request, #21479: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-09 Thread GitBox
XComp opened a new pull request, #21479: URL: https://github.com/apache/flink/pull/21479 1.16 backport PR for parent PR #21478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Updated] (FLINK-28352) [Umbrella] Make Pulsar connector stable

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28352: --- Labels: pull-request-available test-stability (was: test-stability) > [Umbrella] Make Pulsa

[GitHub] [flink] XComp opened a new pull request, #21478: [FLINK-28352][tests] Disable PulsarSourceUnorderedE2ECase, PulsarUnorderedPartitionSplitReaderTest and PulsarUnorderedSourceITCase

2022-12-09 Thread GitBox
XComp opened a new pull request, #21478: URL: https://github.com/apache/flink/pull/21478 ## What is the purpose of the change These tests cause constant test instabilities. We decided to disable these tests for now to reduce the amount of effort for CI maintenance. FLINK-30351 was cr

[jira] [Updated] (FLINK-30279) Move existing RabbitMQ connector code from Flink repo to dedicated RabbitMQ repo

2022-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30279: --- Labels: pull-request-available (was: ) > Move existing RabbitMQ connector code from Flink r

[GitHub] [flink-connector-rabbitmq] zentol commented on pull request #3: [FLINK-30279] Move existing RabbitMQ connector code from Flink repo to dedicated RabbitMQ repo

2022-12-09 Thread GitBox
zentol commented on PR #3: URL: https://github.com/apache/flink-connector-rabbitmq/pull/3#issuecomment-1344243690 Looks like this is again using the 1.17-SNAPSHOT code instead of 1.16.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-connector-pulsar] zentol commented on a diff in pull request #4: [FLINK-30336][BP 3.0] Sync missing e2e tests

2022-12-09 Thread GitBox
zentol commented on code in PR #4: URL: https://github.com/apache/flink-connector-pulsar/pull/4#discussion_r1044401435 ## flink-connector-pulsar-e2e-tests/pom.xml: ## @@ -77,6 +73,49 @@ under the License. + + +

[GitHub] [flink-connector-pulsar] zentol commented on a diff in pull request #4: [FLINK-30336][BP 3.0] Sync missing e2e tests

2022-12-09 Thread GitBox
zentol commented on code in PR #4: URL: https://github.com/apache/flink-connector-pulsar/pull/4#discussion_r1044402113 ## pom.xml: ## @@ -45,10 +45,12 @@ under the License. flink-connector-pulsar flink-sql-connector-pulsar +flink-connector-pulsar

[jira] [Created] (FLINK-30351) Enable test cases again

2022-12-09 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-30351: - Summary: Enable test cases again Key: FLINK-30351 URL: https://issues.apache.org/jira/browse/FLINK-30351 Project: Flink Issue Type: Sub-task Comp

[GitHub] [flink-connector-pulsar] zentol commented on a diff in pull request #4: [FLINK-30336][BP 3.0] Sync missing e2e tests

2022-12-09 Thread GitBox
zentol commented on code in PR #4: URL: https://github.com/apache/flink-connector-pulsar/pull/4#discussion_r1044400940 ## .github/workflows/push_pr.yml: ## @@ -18,6 +18,11 @@ name: Build flink-connector-pulsar on: [push, pull_request] + +concurrency: + group: ${{ github.he

  1   2   >