mas-chen commented on code in PR #1:
URL: 
https://github.com/apache/flink-connector-kafka/pull/1#discussion_r1044425679


##########
flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/pom.xml:
##########
@@ -18,230 +18,230 @@ specific language governing permissions and limitations
 under the License.
 -->
 <project xmlns="http://maven.apache.org/POM/4.0.0";
-                xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
-                xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
-       <parent>
-               <artifactId>flink-end-to-end-tests</artifactId>
-               <groupId>org.apache.flink</groupId>
-               <version>1.16-SNAPSHOT</version>
-       </parent>
-       <modelVersion>4.0.0</modelVersion>
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+    <parent>
+        <groupId>org.apache.flink</groupId>
+        <artifactId>flink-connector-kafka-e2e-tests</artifactId>
+        <version>3.0-SNAPSHOT</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
 
-       <artifactId>flink-end-to-end-tests-common-kafka</artifactId>
-       <name>Flink : E2E Tests : Common Kafka</name>
+    <artifactId>flink-end-to-end-tests-common-kafka</artifactId>
+    <name>Flink : E2E Tests : Common Kafka</name>
 
-       <repositories>
-               <repository>
-                       <id>confluent</id>
-                       <url>https://packages.confluent.io/maven/</url>
-               </repository>
-       </repositories>
+    <repositories>
+        <repository>
+            <id>confluent</id>
+            <url>https://packages.confluent.io/maven/</url>
+        </repository>
+    </repositories>
 
-       <dependencies>
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-end-to-end-tests-common</artifactId>
-                       <version>${project.version}</version>
-               </dependency>
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-connector-kafka</artifactId>
-                       <version>${project.version}</version>
-               </dependency>
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-test-utils-junit</artifactId>
-                       <scope>compile</scope>
-               </dependency>
-               <dependency>
-                       <groupId>org.junit.jupiter</groupId>
-                       <artifactId>junit-jupiter</artifactId>
-                       <scope>compile</scope>
-               </dependency>
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-streaming-kafka-test</artifactId>
-                       <version>${project.version}</version>
-                       <!-- ensure the test jars are built beforehand -->
-                       <scope>provided</scope>
-                       <exclusions>
-                               <exclusion>
-                                       <!-- For dependency convergence; 
conflicting dependencies are not loaded at the same time -->
-                                       <groupId>org.apache.flink</groupId>
-                                       
<artifactId>flink-connector-kafka</artifactId>
-                               </exclusion>
-                       </exclusions>
-               </dependency>
+    <dependencies>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-connector-kafka</artifactId>
+            <version>${project.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-test-utils-junit</artifactId>
+            <scope>compile</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-test-utils</artifactId>
+            <scope>compile</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
+            <scope>compile</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-streaming-kafka-test</artifactId>
+            <version>${project.version}</version>
+            <!-- ensure the test jars are built beforehand -->
+            <scope>provided</scope>
+            <exclusions>
+                <exclusion>
+                    <!-- For dependency convergence; conflicting dependencies 
are not loaded at the same time -->
+                    <groupId>org.apache.flink</groupId>
+                    <artifactId>flink-connector-kafka</artifactId>
+                </exclusion>
+            </exclusions>
+        </dependency>
 
-               <dependency>
-                       <groupId>org.apache.kafka</groupId>
-                       <artifactId>kafka-clients</artifactId>
-                       <version>3.2.3</version>
-               </dependency>
+        <dependency>
+            <groupId>org.apache.kafka</groupId>
+            <artifactId>kafka-clients</artifactId>
+            <version>${kafka.version}</version>
+        </dependency>
 
-               <!-- The following dependencies are for connector/format 
sql-jars that
-                       we copy using the maven-dependency-plugin. When 
extending the test
-                       to cover more connectors/formats, add a dependency here 
and an entry
-                       to the dependency-plugin configuration below.
-                       This ensures that all modules we actually need (as 
defined by the
-                       dependency-plugin configuration) are built before this 
module. -->
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-sql-client-test</artifactId>
-                       <version>${project.version}</version>
-                       <scope>test</scope>
-               </dependency>
-               <dependency>
-                       <!-- Used by maven-dependency-plugin -->
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-sql-avro</artifactId>
-                       <version>${project.version}</version>
-                       <scope>test</scope>
-               </dependency>
-               <dependency>
-                       <!-- Used by maven-dependency-plugin -->
-                       <groupId>org.apache.flink</groupId>
-                       
<artifactId>flink-sql-avro-confluent-registry</artifactId>
-                       <version>${project.version}</version>
-                       <scope>test</scope>
-               </dependency>
+        <!-- The following dependencies are for connector/format sql-jars that
+            we copy using the maven-dependency-plugin. When extending the test
+             to cover more connectors/formats, add a dependency here and an 
entry
+            to the dependency-plugin configuration below.
+            This ensures that all modules we actually need (as defined by the
+             dependency-plugin configuration) are built before this module. -->
+        <dependency>
+            <!-- Used by maven-dependency-plugin -->
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-sql-avro</artifactId>
+            <version>${flink.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <!-- Used by maven-dependency-plugin -->
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-sql-avro-confluent-registry</artifactId>
+            <version>${flink.version}</version>
+            <scope>test</scope>
+        </dependency>
 
-               <dependency>
-                       <groupId>org.testcontainers</groupId>
-                       <artifactId>kafka</artifactId>
-               </dependency>
+        <dependency>
+            <groupId>org.testcontainers</groupId>
+            <artifactId>kafka</artifactId>
+        </dependency>
 
-               <dependency>
-                       <!-- 
https://mvnrepository.com/artifact/io.confluent/kafka-avro-serializer -->
-                       <groupId>io.confluent</groupId>
-                       <artifactId>kafka-avro-serializer</artifactId>
-                       <version>6.2.2</version>
-                       <scope>test</scope>
-               </dependency>
+        <dependency>
+            <!-- 
https://mvnrepository.com/artifact/io.confluent/kafka-avro-serializer -->
+            <groupId>io.confluent</groupId>
+            <artifactId>kafka-avro-serializer</artifactId>
+            <version>6.2.2</version>
+            <scope>test</scope>
+        </dependency>
 
-               <dependency>
-                       <groupId>io.confluent</groupId>
-                       <artifactId>kafka-schema-registry-client</artifactId>
-                       <version>6.2.2</version>
-                       <scope>test</scope>
-                       <exclusions>
-                               <exclusion>
-                                       <groupId>org.apache.kafka</groupId>
-                                       <artifactId>kafka-clients</artifactId>
-                               </exclusion>
-                       </exclusions>
-               </dependency>
+        <dependency>
+            <groupId>io.confluent</groupId>
+            <artifactId>kafka-schema-registry-client</artifactId>
+            <version>6.2.2</version>
+            <scope>test</scope>
+            <exclusions>
+                <exclusion>
+                    <groupId>org.apache.kafka</groupId>
+                    <artifactId>kafka-clients</artifactId>
+                </exclusion>
+            </exclusions>
+        </dependency>
 
-               <dependency>
-                       <groupId>org.apache.avro</groupId>
-                       <artifactId>avro</artifactId>
-                       <version>${avro.version}</version>
-                       <scope>test</scope>
-               </dependency>
+        <dependency>
+            <groupId>org.apache.avro</groupId>
+            <artifactId>avro</artifactId>
+            <version>${avro.version}</version>
+            <scope>test</scope>
+        </dependency>
 
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-connector-test-utils</artifactId>
-                       <version>${project.version}</version>
-                       <exclusions>
-                               <exclusion>
-                                       <groupId>com.google.guava</groupId>
-                                       <artifactId>guava</artifactId>
-                               </exclusion>
-                       </exclusions>
-               </dependency>
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-connector-kafka</artifactId>
-                       <version>${project.version}</version>
-                       <type>test-jar</type>
-               </dependency>
-       </dependencies>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-connector-test-utils</artifactId>
+            <version>${flink.version}</version>
+            <exclusions>
+                <exclusion>
+                    <groupId>com.google.guava</groupId>
+                    <artifactId>guava</artifactId>
+                </exclusion>
+            </exclusions>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-connector-kafka</artifactId>
+            <version>${project.version}</version>
+            <type>test-jar</type>
+        </dependency>
 
-       <build>
-               <plugins>
-                       <plugin>
-                               <groupId>org.apache.maven.plugins</groupId>
-                               <artifactId>maven-dependency-plugin</artifactId>
-                               <executions>
-                                       <execution>
-                                               <id>copy</id>
-                                               
<phase>pre-integration-test</phase>
-                                               <goals>
-                                                       <goal>copy</goal>
-                                               </goals>
-                                       </execution>
-                               </executions>
-                               <configuration>
-                                       <artifactItems>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-streaming-kafka-test</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       <type>jar</type>
-                                                       
<overWrite>true</overWrite>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
+        <dependency>
+            <groupId>org.hamcrest</groupId>
+            <artifactId>hamcrest-all</artifactId>
+            <version>${hamcrest.version}</version>
+            <scope>test</scope>
+        </dependency>
+    </dependencies>
 
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-sql-client-test</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>SqlToolbox.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-sql-avro</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>avro.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-sql-avro-confluent-registry</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>avro-confluent.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-sql-connector-kafka</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>sql-kafka.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-connector-kafka</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>kafka-connector.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-connector-test-utils</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>flink-connector-testing.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.kafka</groupId>
-                                                       
<artifactId>kafka-clients</artifactId>
-                                                       <version>3.2.3</version>
-                                                       
<destFileName>kafka-clients.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                       </artifactItems>
-                               </configuration>
-                       </plugin>
-               </plugins>
-       </build>
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-dependency-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>copy</id>
+                        <phase>pre-integration-test</phase>
+                        <goals>
+                            <goal>copy</goal>
+                        </goals>
+                    </execution>
+                </executions>
+                <configuration>
+                    <artifactItems>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            <artifactId>flink-streaming-kafka-test</artifactId>
+                            <version>${project.version}</version>
+                            <type>jar</type>
+                            <overWrite>true</overWrite>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            <artifactId>flink-sql-avro</artifactId>
+                            <version>${flink.version}</version>
+                            <destFileName>avro.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            
<artifactId>flink-sql-avro-confluent-registry</artifactId>
+                            <version>${flink.version}</version>
+                            <destFileName>avro-confluent.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            <artifactId>flink-sql-connector-kafka</artifactId>
+                            <version>${project.version}</version>
+                            <destFileName>sql-kafka.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            <artifactId>flink-connector-kafka</artifactId>
+                            <version>${project.version}</version>
+                            <destFileName>kafka-connector.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            <artifactId>flink-connector-test-utils</artifactId>
+                            <version>${flink.version}</version>
+                            
<destFileName>flink-connector-testing.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.kafka</groupId>
+                            <artifactId>kafka-clients</artifactId>
+                            <version>${kafka.version}</version>
+                            <destFileName>kafka-clients.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                    </artifactItems>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <configuration>
+                    <source>8</source>
+                    <target>8</target>
+                </configuration>
+            </plugin>

Review Comment:
   This must have been a copy paste error



##########
flink-connector-kafka-e2e-tests/flink-end-to-end-tests-common-kafka/pom.xml:
##########
@@ -18,230 +18,230 @@ specific language governing permissions and limitations
 under the License.
 -->
 <project xmlns="http://maven.apache.org/POM/4.0.0";
-                xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
-                xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
-       <parent>
-               <artifactId>flink-end-to-end-tests</artifactId>
-               <groupId>org.apache.flink</groupId>
-               <version>1.16-SNAPSHOT</version>
-       </parent>
-       <modelVersion>4.0.0</modelVersion>
+         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+    <parent>
+        <groupId>org.apache.flink</groupId>
+        <artifactId>flink-connector-kafka-e2e-tests</artifactId>
+        <version>3.0-SNAPSHOT</version>
+    </parent>
+    <modelVersion>4.0.0</modelVersion>
 
-       <artifactId>flink-end-to-end-tests-common-kafka</artifactId>
-       <name>Flink : E2E Tests : Common Kafka</name>
+    <artifactId>flink-end-to-end-tests-common-kafka</artifactId>
+    <name>Flink : E2E Tests : Common Kafka</name>
 
-       <repositories>
-               <repository>
-                       <id>confluent</id>
-                       <url>https://packages.confluent.io/maven/</url>
-               </repository>
-       </repositories>
+    <repositories>
+        <repository>
+            <id>confluent</id>
+            <url>https://packages.confluent.io/maven/</url>
+        </repository>
+    </repositories>
 
-       <dependencies>
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-end-to-end-tests-common</artifactId>
-                       <version>${project.version}</version>
-               </dependency>
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-connector-kafka</artifactId>
-                       <version>${project.version}</version>
-               </dependency>
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-test-utils-junit</artifactId>
-                       <scope>compile</scope>
-               </dependency>
-               <dependency>
-                       <groupId>org.junit.jupiter</groupId>
-                       <artifactId>junit-jupiter</artifactId>
-                       <scope>compile</scope>
-               </dependency>
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-streaming-kafka-test</artifactId>
-                       <version>${project.version}</version>
-                       <!-- ensure the test jars are built beforehand -->
-                       <scope>provided</scope>
-                       <exclusions>
-                               <exclusion>
-                                       <!-- For dependency convergence; 
conflicting dependencies are not loaded at the same time -->
-                                       <groupId>org.apache.flink</groupId>
-                                       
<artifactId>flink-connector-kafka</artifactId>
-                               </exclusion>
-                       </exclusions>
-               </dependency>
+    <dependencies>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-connector-kafka</artifactId>
+            <version>${project.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-test-utils-junit</artifactId>
+            <scope>compile</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-test-utils</artifactId>
+            <scope>compile</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.junit.jupiter</groupId>
+            <artifactId>junit-jupiter</artifactId>
+            <scope>compile</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-streaming-kafka-test</artifactId>
+            <version>${project.version}</version>
+            <!-- ensure the test jars are built beforehand -->
+            <scope>provided</scope>
+            <exclusions>
+                <exclusion>
+                    <!-- For dependency convergence; conflicting dependencies 
are not loaded at the same time -->
+                    <groupId>org.apache.flink</groupId>
+                    <artifactId>flink-connector-kafka</artifactId>
+                </exclusion>
+            </exclusions>
+        </dependency>
 
-               <dependency>
-                       <groupId>org.apache.kafka</groupId>
-                       <artifactId>kafka-clients</artifactId>
-                       <version>3.2.3</version>
-               </dependency>
+        <dependency>
+            <groupId>org.apache.kafka</groupId>
+            <artifactId>kafka-clients</artifactId>
+            <version>${kafka.version}</version>
+        </dependency>
 
-               <!-- The following dependencies are for connector/format 
sql-jars that
-                       we copy using the maven-dependency-plugin. When 
extending the test
-                       to cover more connectors/formats, add a dependency here 
and an entry
-                       to the dependency-plugin configuration below.
-                       This ensures that all modules we actually need (as 
defined by the
-                       dependency-plugin configuration) are built before this 
module. -->
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-sql-client-test</artifactId>
-                       <version>${project.version}</version>
-                       <scope>test</scope>
-               </dependency>
-               <dependency>
-                       <!-- Used by maven-dependency-plugin -->
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-sql-avro</artifactId>
-                       <version>${project.version}</version>
-                       <scope>test</scope>
-               </dependency>
-               <dependency>
-                       <!-- Used by maven-dependency-plugin -->
-                       <groupId>org.apache.flink</groupId>
-                       
<artifactId>flink-sql-avro-confluent-registry</artifactId>
-                       <version>${project.version}</version>
-                       <scope>test</scope>
-               </dependency>
+        <!-- The following dependencies are for connector/format sql-jars that
+            we copy using the maven-dependency-plugin. When extending the test
+             to cover more connectors/formats, add a dependency here and an 
entry
+            to the dependency-plugin configuration below.
+            This ensures that all modules we actually need (as defined by the
+             dependency-plugin configuration) are built before this module. -->
+        <dependency>
+            <!-- Used by maven-dependency-plugin -->
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-sql-avro</artifactId>
+            <version>${flink.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <!-- Used by maven-dependency-plugin -->
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-sql-avro-confluent-registry</artifactId>
+            <version>${flink.version}</version>
+            <scope>test</scope>
+        </dependency>
 
-               <dependency>
-                       <groupId>org.testcontainers</groupId>
-                       <artifactId>kafka</artifactId>
-               </dependency>
+        <dependency>
+            <groupId>org.testcontainers</groupId>
+            <artifactId>kafka</artifactId>
+        </dependency>
 
-               <dependency>
-                       <!-- 
https://mvnrepository.com/artifact/io.confluent/kafka-avro-serializer -->
-                       <groupId>io.confluent</groupId>
-                       <artifactId>kafka-avro-serializer</artifactId>
-                       <version>6.2.2</version>
-                       <scope>test</scope>
-               </dependency>
+        <dependency>
+            <!-- 
https://mvnrepository.com/artifact/io.confluent/kafka-avro-serializer -->
+            <groupId>io.confluent</groupId>
+            <artifactId>kafka-avro-serializer</artifactId>
+            <version>6.2.2</version>
+            <scope>test</scope>
+        </dependency>
 
-               <dependency>
-                       <groupId>io.confluent</groupId>
-                       <artifactId>kafka-schema-registry-client</artifactId>
-                       <version>6.2.2</version>
-                       <scope>test</scope>
-                       <exclusions>
-                               <exclusion>
-                                       <groupId>org.apache.kafka</groupId>
-                                       <artifactId>kafka-clients</artifactId>
-                               </exclusion>
-                       </exclusions>
-               </dependency>
+        <dependency>
+            <groupId>io.confluent</groupId>
+            <artifactId>kafka-schema-registry-client</artifactId>
+            <version>6.2.2</version>
+            <scope>test</scope>
+            <exclusions>
+                <exclusion>
+                    <groupId>org.apache.kafka</groupId>
+                    <artifactId>kafka-clients</artifactId>
+                </exclusion>
+            </exclusions>
+        </dependency>
 
-               <dependency>
-                       <groupId>org.apache.avro</groupId>
-                       <artifactId>avro</artifactId>
-                       <version>${avro.version}</version>
-                       <scope>test</scope>
-               </dependency>
+        <dependency>
+            <groupId>org.apache.avro</groupId>
+            <artifactId>avro</artifactId>
+            <version>${avro.version}</version>
+            <scope>test</scope>
+        </dependency>
 
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-connector-test-utils</artifactId>
-                       <version>${project.version}</version>
-                       <exclusions>
-                               <exclusion>
-                                       <groupId>com.google.guava</groupId>
-                                       <artifactId>guava</artifactId>
-                               </exclusion>
-                       </exclusions>
-               </dependency>
-               <dependency>
-                       <groupId>org.apache.flink</groupId>
-                       <artifactId>flink-connector-kafka</artifactId>
-                       <version>${project.version}</version>
-                       <type>test-jar</type>
-               </dependency>
-       </dependencies>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-connector-test-utils</artifactId>
+            <version>${flink.version}</version>
+            <exclusions>
+                <exclusion>
+                    <groupId>com.google.guava</groupId>
+                    <artifactId>guava</artifactId>
+                </exclusion>
+            </exclusions>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.flink</groupId>
+            <artifactId>flink-connector-kafka</artifactId>
+            <version>${project.version}</version>
+            <type>test-jar</type>
+        </dependency>
 
-       <build>
-               <plugins>
-                       <plugin>
-                               <groupId>org.apache.maven.plugins</groupId>
-                               <artifactId>maven-dependency-plugin</artifactId>
-                               <executions>
-                                       <execution>
-                                               <id>copy</id>
-                                               
<phase>pre-integration-test</phase>
-                                               <goals>
-                                                       <goal>copy</goal>
-                                               </goals>
-                                       </execution>
-                               </executions>
-                               <configuration>
-                                       <artifactItems>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-streaming-kafka-test</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       <type>jar</type>
-                                                       
<overWrite>true</overWrite>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
+        <dependency>
+            <groupId>org.hamcrest</groupId>
+            <artifactId>hamcrest-all</artifactId>
+            <version>${hamcrest.version}</version>
+            <scope>test</scope>
+        </dependency>
+    </dependencies>
 
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-sql-client-test</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>SqlToolbox.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-sql-avro</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>avro.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-sql-avro-confluent-registry</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>avro-confluent.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-sql-connector-kafka</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>sql-kafka.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-connector-kafka</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>kafka-connector.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.flink</groupId>
-                                                       
<artifactId>flink-connector-test-utils</artifactId>
-                                                       
<version>${project.version}</version>
-                                                       
<destFileName>flink-connector-testing.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                               <artifactItem>
-                                                       
<groupId>org.apache.kafka</groupId>
-                                                       
<artifactId>kafka-clients</artifactId>
-                                                       <version>3.2.3</version>
-                                                       
<destFileName>kafka-clients.jar</destFileName>
-                                                       <type>jar</type>
-                                                       
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
-                                               </artifactItem>
-                                       </artifactItems>
-                               </configuration>
-                       </plugin>
-               </plugins>
-       </build>
+    <build>
+        <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-dependency-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>copy</id>
+                        <phase>pre-integration-test</phase>
+                        <goals>
+                            <goal>copy</goal>
+                        </goals>
+                    </execution>
+                </executions>
+                <configuration>
+                    <artifactItems>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            <artifactId>flink-streaming-kafka-test</artifactId>
+                            <version>${project.version}</version>
+                            <type>jar</type>
+                            <overWrite>true</overWrite>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            <artifactId>flink-sql-avro</artifactId>
+                            <version>${flink.version}</version>
+                            <destFileName>avro.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            
<artifactId>flink-sql-avro-confluent-registry</artifactId>
+                            <version>${flink.version}</version>
+                            <destFileName>avro-confluent.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            <artifactId>flink-sql-connector-kafka</artifactId>
+                            <version>${project.version}</version>
+                            <destFileName>sql-kafka.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            <artifactId>flink-connector-kafka</artifactId>
+                            <version>${project.version}</version>
+                            <destFileName>kafka-connector.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.flink</groupId>
+                            <artifactId>flink-connector-test-utils</artifactId>
+                            <version>${flink.version}</version>
+                            
<destFileName>flink-connector-testing.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                        <artifactItem>
+                            <groupId>org.apache.kafka</groupId>
+                            <artifactId>kafka-clients</artifactId>
+                            <version>${kafka.version}</version>
+                            <destFileName>kafka-clients.jar</destFileName>
+                            <type>jar</type>
+                            
<outputDirectory>${project.build.directory}/dependencies</outputDirectory>
+                        </artifactItem>
+                    </artifactItems>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <configuration>
+                    <source>8</source>
+                    <target>8</target>
+                </configuration>
+            </plugin>

Review Comment:
   This must have been a copy paste error. Removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to