reta commented on code in PR #3:
URL:
https://github.com/apache/flink-connector-opensearch/pull/3#discussion_r1044469621
##########
flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/table/OpensearchConnectorOptions.java:
##########
@@ -143,7 +143,7 @@ public class OpensearchConnectorOptions {
public static final ConfigOption<DeliveryGuarantee>
DELIVERY_GUARANTEE_OPTION =
ConfigOptions.key("sink.delivery-guarantee")
.enumType(DeliveryGuarantee.class)
- .defaultValue(DeliveryGuarantee.NONE)
+ .defaultValue(DeliveryGuarantee.AT_LEAST_ONCE)
Review Comment:
Updating to match the right default
(https://github.com/apache/flink-connector-opensearch/blob/main/flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchSinkBuilder.java#L65)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
