[GitHub] [flink] Aitozi commented on a diff in pull request #19840: [FLINK-24713][Runtime/Coordination] Support the initial delay for SlotManager to wait fo…

2022-06-17 Thread GitBox
Aitozi commented on code in PR #19840: URL: https://github.com/apache/flink/pull/19840#discussion_r900707375 ## flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/slotmanager/AbstractFineGrainedSlotManagerITCase.java: ## @@ -752,4 +753,76 @@ public void testAl

[GitHub] [flink] Aitozi commented on a diff in pull request #19840: [FLINK-24713][Runtime/Coordination] Support the initial delay for SlotManager to wait fo…

2022-06-17 Thread GitBox
Aitozi commented on code in PR #19840: URL: https://github.com/apache/flink/pull/19840#discussion_r900706727 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/FineGrainedSlotManager.java: ## @@ -504,8 +522,11 @@ private void checkResourceRequire

[jira] [Comment Edited] (FLINK-27667) YARNHighAvailabilityITCase fails with "Failed to delete temp directory /tmp/junit1681"

2022-06-17 Thread Biao Geng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1732#comment-1732 ] Biao Geng edited comment on FLINK-27667 at 6/18/22 6:36 AM:

[jira] [Comment Edited] (FLINK-27667) YARNHighAvailabilityITCase fails with "Failed to delete temp directory /tmp/junit1681"

2022-06-17 Thread Biao Geng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1732#comment-1732 ] Biao Geng edited comment on FLINK-27667 at 6/18/22 6:34 AM:

[jira] [Commented] (FLINK-28103) Job cancelling api returns 404 when job is actually running

2022-06-17 Thread David (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555843#comment-17555843 ] David commented on FLINK-28103: --- [~chesnay] PATCH is supported neither in Java (HttpURLCon

[jira] [Commented] (FLINK-28103) Job cancelling api returns 404 when job is actually running

2022-06-17 Thread David (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555842#comment-17555842 ] David commented on FLINK-28103: --- [~martijnvisser] I'll try that next week > Job cancellin

[GitHub] [flink] MartijnVisser commented on pull request #19994: [FLINK-28060][Connector/Kafka] Updated Kafka Clients to 3.1.1

2022-06-17 Thread GitBox
MartijnVisser commented on PR #19994: URL: https://github.com/apache/flink/pull/19994#issuecomment-1159371183 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Commented] (FLINK-27898) fix PartitionPushDown in streaming mode for hive source

2022-06-17 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555830#comment-17555830 ] luoyuxia commented on FLINK-27898: -- Sorry for late reply. About my thoughts, I think th

[jira] [Commented] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

2022-06-17 Thread yutao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555828#comment-17555828 ] yutao commented on FLINK-28111: --- [~jingge] ok,just in work day.i will try > flinksql use

[jira] [Commented] (FLINK-28104) Drop the unused order parameter in FirstValueFunction/LastValueFunction

2022-06-17 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555827#comment-17555827 ] Benchao Li commented on FLINK-28104: {quote}But for such case,  not only it's not do

[GitHub] [flink] WangLinH closed pull request #20013: little test

2022-06-17 Thread GitBox
WangLinH closed pull request #20013: little test URL: https://github.com/apache/flink/pull/20013 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-

[GitHub] [flink] flinkbot commented on pull request #20013: little test

2022-06-17 Thread GitBox
flinkbot commented on PR #20013: URL: https://github.com/apache/flink/pull/20013#issuecomment-1159343030 ## CI report: * 0b06f6cb1b6088c62ba2a3b2b7389ad2d735aaa9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] WangLinH commented on pull request #20013: little test

2022-06-17 Thread GitBox
WangLinH commented on PR #20013: URL: https://github.com/apache/flink/pull/20013#issuecomment-1159342103 agree -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [flink] WangLinH opened a new pull request, #20013: little test

2022-06-17 Thread GitBox
WangLinH opened a new pull request, #20013: URL: https://github.com/apache/flink/pull/20013 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them o

[GitHub] [flink] 1996fanrui commented on pull request #19499: [FLINK-26762][network] Add the overdraft buffer in ResultPartition

2022-06-17 Thread GitBox
1996fanrui commented on PR #19499: URL: https://github.com/apache/flink/pull/19499#issuecomment-1159334613 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #111: [FLINK-27877] Improve StringIndexer performance and optimize flink-ml-bench

2022-06-17 Thread GitBox
lindong28 commented on code in PR #111: URL: https://github.com/apache/flink-ml/pull/111#discussion_r900638687 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/BenchmarkUtils.java: ## @@ -99,6 +99,7 @@ private static BenchmarkResult runBenchmark( Da

[GitHub] [flink-ml] lindong28 commented on pull request #112: [FLINK-27096] Flush buffer at epoch watermark

2022-06-17 Thread GitBox
lindong28 commented on PR #112: URL: https://github.com/apache/flink-ml/pull/112#issuecomment-1159323425 @yunfengzhou-hub Thanks for the PR! LGTM. Could you explain the performance impact of this PR on the iteration benchmark with and without trivial UDF payload? -- This is an automated

[GitHub] [flink] dianfu commented on a diff in pull request #20002: [FLINK-28107][python][connector/elasticsearch] Support id of document is null

2022-06-17 Thread GitBox
dianfu commented on code in PR #20002: URL: https://github.com/apache/flink/pull/20002#discussion_r900607863 ## flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/connector/elasticsearch/sink/SimpleElasticsearchEmitter.java: ## @@ -20,76 +20,87 @@

[GitHub] [flink] dianfu commented on a diff in pull request #20002: [FLINK-28107][python][connector/elasticsearch] Support id of document is null

2022-06-17 Thread GitBox
dianfu commented on code in PR #20002: URL: https://github.com/apache/flink/pull/20002#discussion_r900607863 ## flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/connector/elasticsearch/sink/SimpleElasticsearchEmitter.java: ## @@ -20,76 +20,87 @@

[jira] [Commented] (FLINK-28021) Add FLIP-33 metrics to FileSystem connector

2022-06-17 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555777#comment-17555777 ] Jing Ge commented on FLINK-28021: - [~shubham.bansal] you could find more information w.r

[jira] [Commented] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

2022-06-17 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555774#comment-17555774 ] Jing Ge commented on FLINK-28111: - [~chaojipaopao] how about Flink 1.15.0? Would you lik

[jira] [Commented] (FLINK-28115) Flink 1.15.0 Parallelism Rebalance causes flink job failure

2022-06-17 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555773#comment-17555773 ] Jing Ge commented on FLINK-28115: - [~renqs] Would you like to take a look at this? [~hu

[jira] [Updated] (FLINK-28116) Elasticsearch connector doesn't provide security through token

2022-06-17 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge updated FLINK-28116: Issue Type: Improvement (was: Bug) > Elasticsearch connector doesn't provide security through token > ---

[GitHub] [flink] JingGe closed pull request #19799: [Flink-26011][test] backport 1.15 - ArchUnit test for formats test code

2022-06-17 Thread GitBox
JingGe closed pull request #19799: [Flink-26011][test] backport 1.15 - ArchUnit test for formats test code URL: https://github.com/apache/flink/pull/19799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [flink] flinkbot commented on pull request #20012: [FLINK-27667][yarn-tests][NO_MERGE] Attempt to stabilize flaky YARN IT tests

2022-06-17 Thread GitBox
flinkbot commented on PR #20012: URL: https://github.com/apache/flink/pull/20012#issuecomment-1159190152 ## CI report: * be30fe0f9954f673ac599e9e3149edb98ee67c9b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-27667) YARNHighAvailabilityITCase fails with "Failed to delete temp directory /tmp/junit1681"

2022-06-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27667: --- Labels: pull-request-available test-stability (was: test-stability) > YARNHighAvailabilityI

[GitHub] [flink] ferenc-csaky opened a new pull request, #20012: [FLINK-27667][yarn-tests][NO_MERGE] Attempt to stabilize flaky YARN IT tests

2022-06-17 Thread GitBox
ferenc-csaky opened a new pull request, #20012: URL: https://github.com/apache/flink/pull/20012 ## What is the purpose of the change Stabilizing YARN IT test cases. Currently, they tend to fail, because of a concurrent temp folder cleanup. ## Brief change log Added separ

[GitHub] [flink] gaborgsomogyi commented on pull request #20011: [FLINK-28112][filesystems] Fix error message when directly supported file system is not able to be handled

2022-06-17 Thread GitBox
gaborgsomogyi commented on PR #20011: URL: https://github.com/apache/flink/pull/20011#issuecomment-1159182213 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Created] (FLINK-28116) Elasticsearch connector doesn't provide security through token

2022-06-17 Thread Deepika Sahu (Jira)
Deepika Sahu created FLINK-28116: Summary: Elasticsearch connector doesn't provide security through token Key: FLINK-28116 URL: https://issues.apache.org/jira/browse/FLINK-28116 Project: Flink

[jira] [Updated] (FLINK-28115) Flink 1.15.0 Parallelism Rebalance causes flink job failure

2022-06-17 Thread Huameng Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huameng Li updated FLINK-28115: --- Description: {color:#de350b}*Issue:*{color} *Flink 1.15.0 Parallelism Rebalance causes flink job fa

[jira] [Updated] (FLINK-28115) Flink 1.15.0 Parallelism Rebalance causes flink job failure

2022-06-17 Thread Huameng Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huameng Li updated FLINK-28115: --- Description:   *1 of the 8 re-balance parallelism task slots failed due to*  *{color:#de350b}org.ap

[jira] [Updated] (FLINK-28115) Flink 1.15.0 Parallelism Rebalance causes flink job failure

2022-06-17 Thread Huameng Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huameng Li updated FLINK-28115: --- Description: *1 of the 8 parallelism task slots failed due to* **  *{color:#de350b}org.apache.flink.

[jira] [Updated] (FLINK-28115) Flink 1.15.0 Parallelism Rebalance causes flink job failure

2022-06-17 Thread Huameng Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huameng Li updated FLINK-28115: --- Attachment: (was: flink1.15.0-ParallelismRebalanceError.png) > Flink 1.15.0 Parallelism Rebalanc

[jira] [Updated] (FLINK-28115) Flink 1.15.0 Parallelism Rebalance causes flink job failure

2022-06-17 Thread Huameng Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huameng Li updated FLINK-28115: --- Attachment: flink1.15.0-ParallelismRebalanceError.png > Flink 1.15.0 Parallelism Rebalance causes fl

[jira] [Created] (FLINK-28115) Flink 1.15.0 Parallelism Rebalance causes flink job failure

2022-06-17 Thread Huameng Li (Jira)
Huameng Li created FLINK-28115: -- Summary: Flink 1.15.0 Parallelism Rebalance causes flink job failure Key: FLINK-28115 URL: https://issues.apache.org/jira/browse/FLINK-28115 Project: Flink Issu

[GitHub] [flink] gaborgsomogyi commented on pull request #20011: [FLINK-28112][filesystems] Fix error message when directly supported file system is not able to be handled

2022-06-17 Thread GitBox
gaborgsomogyi commented on PR #20011: URL: https://github.com/apache/flink/pull/20011#issuecomment-1159052827 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [flink] ferenc-csaky commented on a diff in pull request #20011: [FLINK-28112][filesystems] Fix error message when directly supported file system is not able to be handled

2022-06-17 Thread GitBox
ferenc-csaky commented on code in PR #20011: URL: https://github.com/apache/flink/pull/20011#discussion_r900287393 ## flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java: ## @@ -527,13 +527,30 @@ public static FileSystem getUnguardedFileSystem(final URI fsUri) thr

[GitHub] [flink] libenchao commented on pull request #14376: [FLINK-18202][PB format] New Format of protobuf

2022-06-17 Thread GitBox
libenchao commented on PR #14376: URL: https://github.com/apache/flink/pull/14376#issuecomment-1159021778 @maosuhan I started to review this PR today. Apologies for the delay. I didn't go deep into the code yet, but there are a few general issues which we'd better handle them in the first

[GitHub] [flink] 1996fanrui commented on pull request #19499: [FLINK-26762][network] Add the overdraft buffer in ResultPartition

2022-06-17 Thread GitBox
1996fanrui commented on PR #19499: URL: https://github.com/apache/flink/pull/19499#issuecomment-1159015244 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] zentol commented on a diff in pull request #19968: [FLINK-27972][coordination] Wait until savepoint operation is complete

2022-06-17 Thread GitBox
zentol commented on code in PR #19968: URL: https://github.com/apache/flink/pull/19968#discussion_r900223182 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepoint.java: ## @@ -132,6 +146,7 @@ public void onLeave(Class newState) { @Ov

[GitHub] [flink] gaborgsomogyi commented on pull request #20011: [FLINK-28112][filesystems] Fix error message when directly supported file system is not able to be handled

2022-06-17 Thread GitBox
gaborgsomogyi commented on PR #20011: URL: https://github.com/apache/flink/pull/20011#issuecomment-1158970779 cc @gyfora @mbalassi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [flink] PrabhuJoseph commented on pull request #20011: [FLINK-28112][filesystems] Fix error message when directly supported file system is not able to be handled

2022-06-17 Thread GitBox
PrabhuJoseph commented on PR #20011: URL: https://github.com/apache/flink/pull/20011#issuecomment-1158965939 Thanks for the patch, LGTM +1 (non-binding) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] zentol commented on a diff in pull request #19968: [FLINK-27972][coordination] Wait until savepoint operation is complete

2022-06-17 Thread GitBox
zentol commented on code in PR #19968: URL: https://github.com/apache/flink/pull/19968#discussion_r900209065 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepoint.java: ## @@ -132,6 +146,7 @@ public void onLeave(Class newState) { @Ov

[jira] [Created] (FLINK-28114) The path of the Python client interpreter could not point to an archive file in distributed file system

2022-06-17 Thread Dian Fu (Jira)
Dian Fu created FLINK-28114: --- Summary: The path of the Python client interpreter could not point to an archive file in distributed file system Key: FLINK-28114 URL: https://issues.apache.org/jira/browse/FLINK-28114

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #111: [FLINK-27877] Improve StringIndexer performance and optimize flink-ml-bench

2022-06-17 Thread GitBox
lindong28 commented on code in PR #111: URL: https://github.com/apache/flink-ml/pull/111#discussion_r900198528 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/BenchmarkUtils.java: ## @@ -99,6 +99,7 @@ private static BenchmarkResult runBenchmark( Da

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #111: [FLINK-27877] Improve StringIndexer performance and optimize flink-ml-bench

2022-06-17 Thread GitBox
lindong28 commented on code in PR #111: URL: https://github.com/apache/flink-ml/pull/111#discussion_r900198528 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/BenchmarkUtils.java: ## @@ -99,6 +99,7 @@ private static BenchmarkResult runBenchmark( Da

[GitHub] [flink] flinkbot commented on pull request #20011: [FLINK-28112][filesystems] Fix error message when directly supported file system is not able to be handled

2022-06-17 Thread GitBox
flinkbot commented on PR #20011: URL: https://github.com/apache/flink/pull/20011#issuecomment-1158947217 ## CI report: * de4ca69b381a4f1c86d43ac98baf03a337181f6c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-28112) Misleading error message when Hadoop S3FileSystem is used and not at classpath

2022-06-17 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi reassigned FLINK-28112: - Assignee: Gabor Somogyi > Misleading error message when Hadoop S3FileSystem is used and

[jira] [Commented] (FLINK-28112) Misleading error message when Hadoop S3FileSystem is used and not at classpath

2022-06-17 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555647#comment-17555647 ] Gabor Somogyi commented on FLINK-28112: --- Created a PR, plz have a look. > Mislead

[jira] [Updated] (FLINK-28112) Misleading error message when Hadoop S3FileSystem is used and not at classpath

2022-06-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28112: --- Labels: pull-request-available (was: ) > Misleading error message when Hadoop S3FileSystem

[GitHub] [flink] gaborgsomogyi opened a new pull request, #20011: [FLINK-28112][filesystems] Fix error message when directly supported file system is not able to be handled

2022-06-17 Thread GitBox
gaborgsomogyi opened a new pull request, #20011: URL: https://github.com/apache/flink/pull/20011 ## What is the purpose of the change The error message is wrong when a directly supported filesystem is not able to be handled. In this PR I've fixed it. ## Brief change log

[jira] [Updated] (FLINK-28112) Misleading error message when Hadoop S3FileSystem is used and not at classpath

2022-06-17 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-28112: -- Affects Version/s: 1.16.0 > Misleading error message when Hadoop S3FileSystem is used and not

[jira] [Updated] (FLINK-28112) Misleading error message when Hadoop S3FileSystem is used and not at classpath

2022-06-17 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Somogyi updated FLINK-28112: -- Component/s: FileSystems > Misleading error message when Hadoop S3FileSystem is used and not a

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #254: [FLINK-27812] Support Dynamic Change of Watched Namespaces

2022-06-17 Thread GitBox
morhidi commented on PR #254: URL: https://github.com/apache/flink-kubernetes-operator/pull/254#issuecomment-1158931070 Thank you for your review @gyfora I've addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #111: [FLINK-27877] Improve StringIndexer performance and optimize flink-ml-bench

2022-06-17 Thread GitBox
lindong28 commented on code in PR #111: URL: https://github.com/apache/flink-ml/pull/111#discussion_r900162810 ## flink-ml-benchmark/src/main/java/org/apache/flink/ml/benchmark/datagenerator/common/RandomStringGenerator.java: ## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache So

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #254: [FLINK-27812] Support Dynamic Change of Watched Namespaces

2022-06-17 Thread GitBox
morhidi commented on code in PR #254: URL: https://github.com/apache/flink-kubernetes-operator/pull/254#discussion_r900053365 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java: ## @@ -187,4 +188,18 @@ pub

[jira] [Updated] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

2022-06-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28111: --- Affects Version/s: 1.14.4 > flinksql use hivecatalog cause union all operation lost 'event

[jira] [Updated] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

2022-06-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-28111: --- Affects Version/s: 1.13.5 > flinksql use hivecatalog cause union all operation lost 'event

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #254: [FLINK-27812] Support Dynamic Change of Watched Namespaces

2022-06-17 Thread GitBox
morhidi commented on code in PR #254: URL: https://github.com/apache/flink-kubernetes-operator/pull/254#discussion_r900053993 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -109,14 +117,19 @@ public Configur

[GitHub] [flink] zentol commented on pull request #20003: [FLINK-28080][runtime] Introduce MutableURLClassLoader as parent class of FlinkUserClassLoader and SafetyNetWrapperClassLoader

2022-06-17 Thread GitBox
zentol commented on PR #20003: URL: https://github.com/apache/flink/pull/20003#issuecomment-1158895050 You can just take whatever classloader you have (e.g., the Flink CL), and create a new FlinkUserCodeClassLoader with that CL as a parent and specify the jar via the urls parameter.

[GitHub] [flink] lsyldliu commented on pull request #19859: [FLINK-27861][table] Introduce UserResourceManager to manage user defined resource

2022-06-17 Thread GitBox
lsyldliu commented on PR #19859: URL: https://github.com/apache/flink/pull/19859#issuecomment-1158890147 @lsyldliu Thanks for your review, the advice is goods to me, I've addressed it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-28112) Misleading error message when Hadoop S3FileSystem is used and not at classpath

2022-06-17 Thread Gabor Somogyi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555611#comment-17555611 ] Gabor Somogyi commented on FLINK-28112: --- Now I see, one case is not covered, namel

[jira] [Comment Edited] (FLINK-26051) one sql has row_number =1 and the subsequent SQL has "case when" and "where" statement result Exception : The window can only be ordered in ASCENDING mode

2022-06-17 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555610#comment-17555610 ] Jane Chan edited comment on FLINK-26051 at 6/17/22 1:30 PM:

[jira] [Commented] (FLINK-26051) one sql has row_number =1 and the subsequent SQL has "case when" and "where" statement result Exception : The window can only be ordered in ASCENDING mode

2022-06-17 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555610#comment-17555610 ] Jane Chan commented on FLINK-26051: --- Sorry for joining this discussion late. I reprodu

[jira] [Updated] (FLINK-26051) one sql has row_number =1 and the subsequent SQL has "case when" and "where" statement result Exception : The window can only be ordered in ASCENDING mode

2022-06-17 Thread Jane Chan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jane Chan updated FLINK-26051: -- Attachment: image-2022-06-17-21-28-54-886.png > one sql has row_number =1 and the subsequent SQL has "

[GitHub] [flink] Aitozi commented on a diff in pull request #19840: [FLINK-24713][Runtime/Coordination] Support the initial delay for SlotManager to wait fo…

2022-06-17 Thread GitBox
Aitozi commented on code in PR #19840: URL: https://github.com/apache/flink/pull/19840#discussion_r900113489 ## flink-core/src/main/java/org/apache/flink/configuration/ResourceManagerOptions.java: ## @@ -150,6 +150,18 @@ public class ResourceManagerOptions {

[jira] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

2022-06-17 Thread yutao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28111 ] yutao deleted comment on FLINK-28111: --- was (Author: chaojipaopao): [~martijnvisser] 1.12.4 but i try flink1.13.5 and flink1.14.4 also have this problem > flinksql use hivecatalog cause union all

[jira] [Commented] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

2022-06-17 Thread yutao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555603#comment-17555603 ] yutao commented on FLINK-28111: --- [~martijnvisser] 1.12.4 but i try flink1.13.5 and flink1.

[GitHub] [flink] RyanSkraba commented on pull request #19970: [FLINK-27970][tests][JUnit5 migration] flink-hadoop-bulk

2022-06-17 Thread GitBox
RyanSkraba commented on PR #19970: URL: https://github.com/apache/flink/pull/19970#issuecomment-1158867140 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Commented] (FLINK-28111) flinksql use hivecatalog cause union all operation lost 'eventTime attribute'

2022-06-17 Thread yutao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555600#comment-17555600 ] yutao commented on FLINK-28111: --- [~martijnvisser] 1.12.4 but i try flink1.13.5 and flink1.

[jira] [Updated] (FLINK-27776) Throw exception when UDAF used in sliding window does not implement merge method in PyFlink

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27776: --- Summary: Throw exception when UDAF used in sliding window does not implement merge method in

[jira] [Updated] (FLINK-27820) Handle Upgrade/Deployment errors gracefully

2022-06-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27820: --- Labels: pull-request-available (was: ) > Handle Upgrade/Deployment errors gracefully >

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #271: [FLINK-27820] Handle deployment errors on observe

2022-06-17 Thread GitBox
gyfora commented on PR #271: URL: https://github.com/apache/flink-kubernetes-operator/pull/271#issuecomment-1158859281 cc @Aitozi @morhidi @wangyang0918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #271: [FLINK-27820] Handle deployment errors on observe

2022-06-17 Thread GitBox
gyfora opened a new pull request, #271: URL: https://github.com/apache/flink-kubernetes-operator/pull/271 This change allows the operator to recover from errors during and directly after Flink cluster submissions. One common cause for this would be a temporary unavailability of the kubernet

[jira] [Updated] (FLINK-26909) Allow setting parallelism to -1 from CLI

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-26909: --- Summary: Allow setting parallelism to -1 from CLI (was: Allow to set parallelism to be -1 f

[jira] [Updated] (FLINK-26788) AbstractDeserializationSchema should add cause when throwing a FlinkRuntimeException

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-26788: --- Summary: AbstractDeserializationSchema should add cause when throwing a FlinkRuntimeExceptio

[jira] [Updated] (FLINK-27955) PyFlink installation failure on Windows OS

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27955: --- Summary: PyFlink installation failure on Windows OS (was: Fix the problem of windows instal

[GitHub] [flink] luoyuxia commented on pull request #19561: [FLINK-26414][hive] Hive dialect supports macro

2022-06-17 Thread GitBox
luoyuxia commented on PR #19561: URL: https://github.com/apache/flink/pull/19561#issuecomment-1158855773 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-27890) SideOutputExample.java fails

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27890: --- Summary: SideOutputExample.java fails (was: bug of SideOutputExample.java) > SideOutputExam

[jira] [Updated] (FLINK-27910) FileSink not enforcing rolling policy if started from scratch

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27910: --- Summary: FileSink not enforcing rolling policy if started from scratch (was: FileSink not r

[jira] [Updated] (FLINK-27683) Insert into (column1, column2) Values(.....) fails with SQL hints

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27683: --- Summary: Insert into (column1, column2) Values(.) fails with SQL hints (was: Insert int

[jira] [Updated] (FLINK-27606) CompileException when using UDAF with merge() method

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27606: --- Summary: CompileException when using UDAF with merge() method (was: Fix CompileException wh

[jira] [Updated] (FLINK-27367) SQL CAST between INT and DATE is broken

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27367: --- Summary: SQL CAST between INT and DATE is broken (was: CAST between INT and DATE is broken)

[jira] [Updated] (FLINK-27420) Suspended SlotManager fails to re-register metrics when started again

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27420: --- Summary: Suspended SlotManager fails to re-register metrics when started again (was: Suspen

[jira] [Commented] (FLINK-28104) Drop the unused order parameter in FirstValueFunction/LastValueFunction

2022-06-17 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1791#comment-1791 ] luoyuxia commented on FLINK-28104: -- [~libenchao] Appreciate for your inputs.  Seems it

[jira] [Updated] (FLINK-27368) SQL CAST(' 1 ' as BIGINT) returns wrong result

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27368: --- Summary: SQL CAST(' 1 ' as BIGINT) returns wrong result (was: CAST(' 1 ' as BIGINT) returns

[jira] [Comment Edited] (FLINK-28104) Drop the unused order parameter in FirstValueFunction/LastValueFunction

2022-06-17 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1791#comment-1791 ] luoyuxia edited comment on FLINK-28104 at 6/17/22 1:02 PM: --- [~

[jira] [Commented] (FLINK-28112) Misleading error message when Hadoop S3FileSystem is used and not at classpath

2022-06-17 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1790#comment-1790 ] Prabhu Joseph commented on FLINK-28112: --- Yes you are right. But *S3 scheme is not

[jira] [Created] (FLINK-28113) Document periodic savepointing

2022-06-17 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-28113: -- Summary: Document periodic savepointing Key: FLINK-28113 URL: https://issues.apache.org/jira/browse/FLINK-28113 Project: Flink Issue Type: Improvement

[jira] [Assigned] (FLINK-27041) KafkaSource in batch mode failing on 0 messages in any topic partition

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson reassigned FLINK-27041: -- Assignee: Qingsheng Ren (was: David Anderson) > KafkaSource in batch mode failing on

[jira] [Updated] (FLINK-27041) KafkaSource in batch mode failing if any topic partition is empty

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27041: --- Summary: KafkaSource in batch mode failing if any topic partition is empty (was: KafkaSourc

[jira] [Assigned] (FLINK-27041) KafkaSource in batch mode failing on 0 messages in any topic partition

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson reassigned FLINK-27041: -- Assignee: David Anderson (was: Qingsheng Ren) > KafkaSource in batch mode failing on

[jira] [Updated] (FLINK-26588) Translate the new SQL CAST documentation to Chinese

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-26588: --- Summary: Translate the new SQL CAST documentation to Chinese (was: Translate the new CAST d

[jira] [Updated] (FLINK-27079) Setup cron jobs

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27079: --- Fix Version/s: 1.15.2 (was: 1.15.1) > Setup cron jobs > -

[jira] [Updated] (FLINK-27082) Disable tests relying on non-writable directories

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27082: --- Fix Version/s: 1.15.2 (was: 1.15.1) > Disable tests relying on non-wr

[jira] [Updated] (FLINK-27080) Enable builds for pull requests

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27080: --- Fix Version/s: 1.15.2 (was: 1.15.1) > Enable builds for pull requests

[jira] [Updated] (FLINK-27077) Setup per-commit builds

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27077: --- Fix Version/s: 1.15.2 (was: 1.15.1) > Setup per-commit builds > -

[jira] [Updated] (FLINK-27075) Migrate CI from Azure to Github Actions

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27075: --- Fix Version/s: 1.15.2 (was: 1.15.1) > Migrate CI from Azure to Github

[GitHub] [flink] lsyldliu commented on pull request #20003: [FLINK-28080][runtime] Introduce MutableURLClassLoader as parent class of FlinkUserClassLoader and SafetyNetWrapperClassLoader

2022-06-17 Thread GitBox
lsyldliu commented on PR #20003: URL: https://github.com/apache/flink/pull/20003#issuecomment-1158838709 > What prevents you from creating such a classloader as a child classloader? The common parent class of `SafetyNetWrapperClassLoader ` and `FlinkUserCodeClassLoader ` is `URLClassL

[jira] [Updated] (FLINK-27492) Flink table scala example does not including the scala-api jars

2022-06-17 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson updated FLINK-27492: --- Fix Version/s: 1.15.2 (was: 1.15.1) > Flink table scala example does

  1   2   3   >