[
https://issues.apache.org/jira/browse/FLINK-28104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555591#comment-17555591
]
luoyuxia edited comment on FLINK-28104 at 6/17/22 1:02 PM:
-----------------------------------------------------------
[~libenchao] Appreciate for your inputs. Seems it should be careful when try
to drop it.
But for such case, not only it's not documented, but also users have no way to
call first_value(value, order) unless user modify Flink's source code for the
function FIRST_VALUE actually only accpet 1 arguments currently.
The reason why I want to drop it is when I try to implement fist_value(value,
[repect_null]) FLINK-26764, a sql startard for first_value function, I find
the current implemtation is more like fist_value(value, order). Also, I found
the order parameter actually isn't exposed to user, and I think it shouldn't
exposed to user as it's not sql startard.
So, I want to drop it, make codebase clean and then move to implement
fist_value(value, [repect_null]).
As you have said you used it, maybe we need still keep it.
But from myside, as it haven't exposed to user, and won't be exposed to user
in the future, I still think we should drop it.
was (Author: luoyuxia):
[~libenchao] Appreciate for your inputs. Seems it should be careful when try
to drop it.
But for such case, not only it's not documented, but also users have no way to
call first_value(value, order) unless user modify Flink's source code for the
function FIRST_VALUE actually only accpet 1 arguments.
The reason why I want to drop it is when I try to implement fist_value(value,
[repect_null]) [FLINK-26764|https://issues.apache.org/jira/browse/FLINK-26764],
a sql startard for first_value function, I find the current implemtation is
more like fist_value(value, order). Also, I found the order parameter actually
isn't exposed to user, and I think it shouldn't exposed to user as it's not sql
startard.
So, I want to drop it, make codebase clean and then move to implement
fist_value(value, [repect_null]).
As you have said you used it, maybe we need still keep it.
But from myside, as it haven't exposed to user, and won't be exposed to user
in the future, I still think we should drop it.
> Drop the unused order parameter in FirstValueFunction/LastValueFunction
> -----------------------------------------------------------------------
>
> Key: FLINK-28104
> URL: https://issues.apache.org/jira/browse/FLINK-28104
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / API, Table SQL / Planner
> Reporter: luoyuxia
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.16.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
