zentol commented on code in PR #19968: URL: https://github.com/apache/flink/pull/19968#discussion_r900209065
########## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepoint.java: ########## @@ -132,6 +146,7 @@ public void onLeave(Class<? extends State> newState) { @Override public void cancel() { + operationFailureCause = new FlinkException("The job was cancelled."); Review Comment: document why we dont wait for the future here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org