[GitHub] [flink] flinkbot edited a comment on pull request #18075: [FLINK-25241][architecture-tests] Ensure CI fails when violations are resolved

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #18075: URL: https://github.com/apache/flink/pull/18075#issuecomment-990709436 ## CI report: * fe38dffce317de46c8b0e34f7bdc64fb72ad81fa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Closed] (FLINK-17083) Restrict users of accumulators not to return null in Accumulator#getLocalValue

2021-12-09 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-17083. --- Resolution: Abandoned > Restrict users of accumulators not to return null in Accumulator#getLocalVal

[GitHub] [flink] flinkbot commented on pull request #18075: [FLINK-25241][architecture-tests] Ensure CI fails when violations are resolved

2021-12-09 Thread GitBox
flinkbot commented on pull request #18075: URL: https://github.com/apache/flink/pull/18075#issuecomment-990710257 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[jira] [Closed] (FLINK-19044) Web UI reports incorrect timeline for the FINISHED state of a subtask

2021-12-09 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-19044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-19044. --- Resolution: Abandoned > Web UI reports incorrect timeline for the FINISHED state of a subtask >

[GitHub] [flink] flinkbot commented on pull request #18075: [FLINK-25241][architecture-tests] Ensure CI fails when violations are resolved

2021-12-09 Thread GitBox
flinkbot commented on pull request #18075: URL: https://github.com/apache/flink/pull/18075#issuecomment-990709436 ## CI report: * fe38dffce317de46c8b0e34f7bdc64fb72ad81fa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[jira] [Closed] (FLINK-13410) Csv input format does not support LocalDate

2021-12-09 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-13410. --- Resolution: Fixed > Csv input format does not support LocalDate > --

[jira] [Updated] (FLINK-25241) Architectural tests do not fail on CI if violations are removed

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25241: --- Labels: pull-request-available (was: ) > Architectural tests do not fail on CI if violation

[GitHub] [flink] Airblader opened a new pull request #18075: [FLINK-25241][architecture-tests] Ensure CI fails when violations are resolved

2021-12-09 Thread GitBox
Airblader opened a new pull request #18075: URL: https://github.com/apache/flink/pull/18075 ## What is the purpose of the change Due to the missing `archunit.` prefix, the CI would not fail if violations were removed with a change; this creates unnecessary and unrelated changes to t

[GitHub] [flink] flinkbot edited a comment on pull request #17958: FLINK-25029: Hadoop Caller Context Setting in Flink

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #17958: URL: https://github.com/apache/flink/pull/17958#issuecomment-982461620 ## CI report: * c6106bd7df67e7e41b3cfd6a45b82149622f074b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766446454 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,311 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766446189 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software

[jira] [Closed] (FLINK-10036) Flink's CSV output format is not consistent with the standard.

2021-12-09 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-10036. --- Fix Version/s: 1.8.0 Resolution: Fixed > Flink's CSV output format is not consistent with the

[GitHub] [flink] flinkbot edited a comment on pull request #16957: [FLINK-23937][Documentation] Fix PQ comment in KeyGroupPartitionedPriorityQueue

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #16957: URL: https://github.com/apache/flink/pull/16957#issuecomment-904428363 ## CI report: * ffd68df341f8fae34e7c830022e2bd0c47690259 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Created] (FLINK-25242) UDF with primitive int argument does not accept int values even after a not null filter

2021-12-09 Thread Caizhi Weng (Jira)
Caizhi Weng created FLINK-25242: --- Summary: UDF with primitive int argument does not accept int values even after a not null filter Key: FLINK-25242 URL: https://issues.apache.org/jira/browse/FLINK-25242

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766444735 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (FLINK-25241) Architectural tests do not fail on CI if violations are removed

2021-12-09 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-25241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ingo Bürk updated FLINK-25241: -- Description: This is problematic because anyone executing tests locally will see unrelated changes to

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766443911 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] flinkbot edited a comment on pull request #17919: [FLINK-24419][table-planner] Trim to precision when casting to BINARY/VARBINARY

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #17919: URL: https://github.com/apache/flink/pull/17919#issuecomment-979659835 ## CI report: * 28b096cbb562c753b9761d81d40b4af2cf9ed2df Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Comment Edited] (FLINK-25096) Issue in exceptions API(/jobs/:jobid/exceptions) in flink 1.13.2

2021-12-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456928#comment-17456928 ] Matthias Pohl edited comment on FLINK-25096 at 12/10/21, 7:41 AM:

[jira] [Resolved] (FLINK-25096) Issue in exceptions API(/jobs/:jobid/exceptions) in flink 1.13.2

2021-12-09 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl resolved FLINK-25096. --- Release Note: Fixes issue where the failover cause it not listed in the exception history bu

[jira] [Created] (FLINK-25241) Architectural tests do not fail on CI if violations are removed

2021-12-09 Thread Jira
Ingo Bürk created FLINK-25241: - Summary: Architectural tests do not fail on CI if violations are removed Key: FLINK-25241 URL: https://issues.apache.org/jira/browse/FLINK-25241 Project: Flink Is

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766442190 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] shenzhu commented on pull request #17919: [FLINK-24419][table-planner] Trim to precision when casting to BINARY/VARBINARY

2021-12-09 Thread GitBox
shenzhu commented on pull request #17919: URL: https://github.com/apache/flink/pull/17919#issuecomment-990690967 > @shenzhu Again thx for your effort! > > Please rebase with master and then: > > * I need to ask you now to use the `legacyBehaviour` from the context to decide if

[GitHub] [flink] XComp merged pull request #18036: [BP-1.13][FLINK-25096] Fixes empty exception history for JobInitializationException

2021-12-09 Thread GitBox
XComp merged pull request #18036: URL: https://github.com/apache/flink/pull/18036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [flink] XComp merged pull request #18035: [BP-1.14][FLINK-25096] Fixes empty exception history for JobInitializationException

2021-12-09 Thread GitBox
XComp merged pull request #18035: URL: https://github.com/apache/flink/pull/18035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766441077 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] XComp merged pull request #17967: [FLINK-25096][runtime] Fixes empty exception history for JobInitializationException

2021-12-09 Thread GitBox
XComp merged pull request #17967: URL: https://github.com/apache/flink/pull/17967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766440801 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] flinkbot edited a comment on pull request #18068: [FLINK-25105][checkpoint] Enables final checkpoint by default

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #18068: URL: https://github.com/apache/flink/pull/18068#issuecomment-989975508 ## CI report: * 8c44c251f1be40e49bee24875b9625e859070010 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766437379 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766433936 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] flinkbot edited a comment on pull request #17892: [FLINK-25038][testutils] Refactor FlinkContainer to split JM and TMs to individual containers and support HA

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #17892: URL: https://github.com/apache/flink/pull/17892#issuecomment-977710431 ## CI report: * 2872da56f8fff16f9378ea09f63d8a12a40045f1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17893: [FLINK-24987][Configuration] Add explicit enum value NO_EXTERNAL_CHECKPOINTS as default for ExternalizedCheckpointRetention

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #17893: URL: https://github.com/apache/flink/pull/17893#issuecomment-977732141 ## CI report: * 2d4583a9ebacb18227d7fc5d8d5db3f9b4f0ea95 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766432489 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766430824 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] flinkbot edited a comment on pull request #17892: [FLINK-25038][testutils] Refactor FlinkContainer to split JM and TMs to individual containers and support HA

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #17892: URL: https://github.com/apache/flink/pull/17892#issuecomment-977710431 ## CI report: * 2872da56f8fff16f9378ea09f63d8a12a40045f1 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766427188 ## File path: flink-ml-lib/src/main/java/org/apache/flink/ml/classification/knn/KnnModel.java ## @@ -0,0 +1,317 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766426334 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766419360 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] paul8263 commented on a change in pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-09 Thread GitBox
paul8263 commented on a change in pull request #16108: URL: https://github.com/apache/flink/pull/16108#discussion_r766417762 ## File path: flink-core/src/main/java/org/apache/flink/util/FileLock.java ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766417485 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766414851 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (FLINK-25240) Update log4j2 version to 2.15.0

2021-12-09 Thread Ada Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ada Wong updated FLINK-25240: - Description: 2.0 <= Apache log4j2 <= 2.14.1 have a RCE zero day. [https://www.cyberkendra.com/2021/12/w

[GitHub] [flink] flinkbot edited a comment on pull request #18073: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #18073: URL: https://github.com/apache/flink/pull/18073#issuecomment-990667419 ## CI report: * f64443b76b0bc0ac8ab9bfbb4b88f5a24f2f000d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #18074: [FLINK-24728][table-runtime-blink] Close output stream in batch SQL file sink

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #18074: URL: https://github.com/apache/flink/pull/18074#issuecomment-990667453 ## CI report: * b2a248d6fde42448bc03842f9f0949fb547d7ad2 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot commented on pull request #18074: [FLINK-24728][table-runtime-blink] Close output stream in batch SQL file sink

2021-12-09 Thread GitBox
flinkbot commented on pull request #18074: URL: https://github.com/apache/flink/pull/18074#issuecomment-990668651 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the pro

[GitHub] [flink] flinkbot commented on pull request #18074: [FLINK-24728][table-runtime-blink] Close output stream in batch SQL file sink

2021-12-09 Thread GitBox
flinkbot commented on pull request #18074: URL: https://github.com/apache/flink/pull/18074#issuecomment-990667453 ## CI report: * b2a248d6fde42448bc03842f9f0949fb547d7ad2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot r

[GitHub] [flink] flinkbot commented on pull request #18073: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-12-09 Thread GitBox
flinkbot commented on pull request #18073: URL: https://github.com/apache/flink/pull/18073#issuecomment-990667419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766394899 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,287 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] tsreaper opened a new pull request #18074: [FLINK-24728][table-runtime-blink] Close output stream in batch SQL file sink

2021-12-09 Thread GitBox
tsreaper opened a new pull request #18074: URL: https://github.com/apache/flink/pull/18074 (This PR is cherry-picked from #17638 and #17655) ## What is the purpose of the change Currently the output format created in `FileSystemTableSink#createBulkWriterOutputFormat` only fini

[GitHub] [flink] tsreaper opened a new pull request #18073: [FLINK-24728][tests] Add tests to ensure SQL file sink closes all created files

2021-12-09 Thread GitBox
tsreaper opened a new pull request #18073: URL: https://github.com/apache/flink/pull/18073 (This PR is cherry-picked from #17655) ## What is the purpose of the change This PR adds tests for the change in #17638. ## Brief change log - Add tests to ensure SQL file

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766391028 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/DenseMatrix.java ## @@ -0,0 +1,74 @@ +package org.apache.flink.ml.linalg; + +import o

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766390619 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/BLAS.java ## @@ -22,13 +22,86 @@ /** A utility class that provides BLAS routines ov

[GitHub] [flink-ml] lindong28 commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
lindong28 commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766351212 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/DenseMatrix.java ## @@ -0,0 +1,74 @@ +package org.apache.flink.ml.linalg; + +import o

[GitHub] [flink] flinkbot edited a comment on pull request #16108: [FLINK-22821][connector-kafka] FlinkKafkaProducerMigrationTest fails …

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #16108: URL: https://github.com/apache/flink/pull/16108#issuecomment-856641884 ## CI report: * 6cc9790481b8459c816d5750b08d8c8c4d5bbd26 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17893: [FLINK-24987][Configuration] Add explicit enum value NO_EXTERNAL_CHECKPOINTS as default for ExternalizedCheckpointRetention

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #17893: URL: https://github.com/apache/flink/pull/17893#issuecomment-977732141 ## CI report: * 2d4583a9ebacb18227d7fc5d8d5db3f9b4f0ea95 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17893: [FLINK-24987][Configuration] Add explicit enum value NO_EXTERNAL_CHECKPOINTS as default for ExternalizedCheckpointRetention

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #17893: URL: https://github.com/apache/flink/pull/17893#issuecomment-977732141 ## CI report: * 2d4583a9ebacb18227d7fc5d8d5db3f9b4f0ea95 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] liufangqi commented on pull request #17958: FLINK-25029: Hadoop Caller Context Setting in Flink

2021-12-09 Thread GitBox
liufangqi commented on pull request #17958: URL: https://github.com/apache/flink/pull/17958#issuecomment-990645530 > In general I agree with the sentiment of the patch. Few things that need to be addressed: > > * As the whole hadoop ecosystem is slowly phasing out and lot of users a

[jira] [Commented] (FLINK-25240) Update log4j2 version to 2.15.0

2021-12-09 Thread Ada Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456899#comment-17456899 ] Ada Wong commented on FLINK-25240: -- I want to fix it. after 2.15.0 release I want to up

[jira] [Comment Edited] (FLINK-25240) Update log4j2 version to 2.15.0

2021-12-09 Thread Ada Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456899#comment-17456899 ] Ada Wong edited comment on FLINK-25240 at 12/10/21, 6:08 AM: -

[GitHub] [flink] Airblader commented on pull request #17893: [FLINK-24987][Configuration] Add explicit enum value NO_EXTERNAL_CHECKPOINTS as default for ExternalizedCheckpointRetention

2021-12-09 Thread GitBox
Airblader commented on pull request #17893: URL: https://github.com/apache/flink/pull/17893#issuecomment-990644617 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Created] (FLINK-25240) Update log4j2 version to 2.15.0

2021-12-09 Thread Ada Wong (Jira)
Ada Wong created FLINK-25240: Summary: Update log4j2 version to 2.15.0 Key: FLINK-25240 URL: https://issues.apache.org/jira/browse/FLINK-25240 Project: Flink Issue Type: Bug Components

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766358710 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/DataStreamUtils.java ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache S

[GitHub] [flink] becketqin commented on a change in pull request #17991: [FLINK-25132][connector/kafka] Move record deserializing from SplitFetcher to RecordEmitter to support object-reusing deseriali

2021-12-09 Thread GitBox
becketqin commented on a change in pull request #17991: URL: https://github.com/apache/flink/pull/17991#discussion_r766356300 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java ## @@

[GitHub] [flink-ml] weibozhao commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
weibozhao commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766352736 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/typeinfo/DenseMatrixSerializer.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apac

[GitHub] [flink-ml] lindong28 commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
lindong28 commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766347505 ## File path: flink-ml-lib/src/test/java/org/apache/flink/ml/classification/knn/KnnTest.java ## @@ -0,0 +1,273 @@ +package org.apache.flink.ml.classificat

[GitHub] [flink-ml] lindong28 commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
lindong28 commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766347443 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/typeinfo/DenseMatrixSerializer.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apac

[GitHub] [flink] wenlong88 commented on a change in pull request #18017: [FLINK-25171] Validation of duplicate fields in ddl sql

2021-12-09 Thread GitBox
wenlong88 commented on a change in pull request #18017: URL: https://github.com/apache/flink/pull/18017#discussion_r766345592 ## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/MergeTableLikeUtil.java ## @@ -426,6 +433,14 @@ p

[GitHub] [flink-ml] lindong28 commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
lindong28 commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766344063 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/linalg/typeinfo/DenseMatrixSerializer.java ## @@ -0,0 +1,134 @@ +/* + * Licensed to the Apac

[GitHub] [flink-ml] lindong28 commented on a change in pull request #24: [Flink 24557] - Add Estimator and Transformer for K-nearest neighbor

2021-12-09 Thread GitBox
lindong28 commented on a change in pull request #24: URL: https://github.com/apache/flink-ml/pull/24#discussion_r766343636 ## File path: flink-ml-core/src/main/java/org/apache/flink/ml/common/datastream/DataStreamUtils.java ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apache S

[GitHub] [flink] flinkbot edited a comment on pull request #18061: [FLINK-25239][connector/jdbc] delete useless variables

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #18061: URL: https://github.com/apache/flink/pull/18061#issuecomment-989698410 ## CI report: * 10cb0a168b73f594a1f117632993d204c6f2d6a7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17958: FLINK-25029: Hadoop Caller Context Setting in Flink

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #17958: URL: https://github.com/apache/flink/pull/17958#issuecomment-982461620 ## CI report: * f8995a6b6713cbe1e6b7415ed51b920183823b9f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-25239) Delete useless variables

2021-12-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25239: --- Labels: pull-request-available (was: ) > Delete useless variables > ---

[GitHub] [flink] deadwind4 commented on pull request #18061: [FLINK-25239][connector/jdbc] delete useless variables

2021-12-09 Thread GitBox
deadwind4 commented on pull request #18061: URL: https://github.com/apache/flink/pull/18061#issuecomment-990596192 @flinkbot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [flink] flinkbot edited a comment on pull request #17958: FLINK-25029: Hadoop Caller Context Setting in Flink

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #17958: URL: https://github.com/apache/flink/pull/17958#issuecomment-982461620 ## CI report: * f8995a6b6713cbe1e6b7415ed51b920183823b9f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #18061: [FLINK-25239][connector/jdbc] delete useless variables

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #18061: URL: https://github.com/apache/flink/pull/18061#issuecomment-989698410 ## CI report: * 10cb0a168b73f594a1f117632993d204c6f2d6a7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Updated] (FLINK-25239) Delete useless variables

2021-12-09 Thread Ada Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ada Wong updated FLINK-25239: - Description:    DEFAULT_FLUSH_MAX_SIZE and DEFAULT_FLUSH_INTERVAL_MILLS in JdbcOutputFormat class are u

[jira] [Created] (FLINK-25239) Delete useless variables

2021-12-09 Thread Ada Wong (Jira)
Ada Wong created FLINK-25239: Summary: Delete useless variables Key: FLINK-25239 URL: https://issues.apache.org/jira/browse/FLINK-25239 Project: Flink Issue Type: Improvement Components

[GitHub] [flink] flinkbot edited a comment on pull request #17919: [FLINK-24419][table-planner] Trim to precision when casting to BINARY/VARBINARY

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #17919: URL: https://github.com/apache/flink/pull/17919#issuecomment-979659835 ## CI report: * 0095d26396c879948f70547077efe70743d4be07 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #17919: [FLINK-24419][table-planner] Trim to precision when casting to BINARY/VARBINARY

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #17919: URL: https://github.com/apache/flink/pull/17919#issuecomment-979659835 ## CI report: * 0095d26396c879948f70547077efe70743d4be07 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] imaffe commented on a change in pull request #18014: [FLINK-24857][test][Kafka] Upgrade SourceReaderTestBase t…

2021-12-09 Thread GitBox
imaffe commented on a change in pull request #18014: URL: https://github.com/apache/flink/pull/18014#discussion_r766313655 ## File path: flink-test-utils-parent/flink-connector-test-utils/pom.xml ## @@ -54,6 +54,12 @@ compile +

[GitHub] [flink] imaffe commented on a change in pull request #18014: [FLINK-24857][test][Kafka] Upgrade SourceReaderTestBase t…

2021-12-09 Thread GitBox
imaffe commented on a change in pull request #18014: URL: https://github.com/apache/flink/pull/18014#discussion_r766313655 ## File path: flink-test-utils-parent/flink-connector-test-utils/pom.xml ## @@ -54,6 +54,12 @@ compile +

[GitHub] [flink] imaffe commented on a change in pull request #18014: [FLINK-24857][test][Kafka] Upgrade SourceReaderTestBase t…

2021-12-09 Thread GitBox
imaffe commented on a change in pull request #18014: URL: https://github.com/apache/flink/pull/18014#discussion_r766313655 ## File path: flink-test-utils-parent/flink-connector-test-utils/pom.xml ## @@ -54,6 +54,12 @@ compile +

[GitHub] [flink] flinkbot edited a comment on pull request #16957: [FLINK-23937][Documentation] Fix PQ comment in KeyGroupPartitionedPriorityQueue

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #16957: URL: https://github.com/apache/flink/pull/16957#issuecomment-904428363 ## CI report: * Unknown: [CANCELED](TBD) * ffd68df341f8fae34e7c830022e2bd0c47690259 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620

[GitHub] [flink] flinkbot edited a comment on pull request #16957: [FLINK-23937][Documentation] Fix PQ comment in KeyGroupPartitionedPriorityQueue

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #16957: URL: https://github.com/apache/flink/pull/16957#issuecomment-904428363 ## CI report: * Unknown: [CANCELED](TBD) * ffd68df341f8fae34e7c830022e2bd0c47690259 UNKNOWN Bot commands The @flinkbot bot supports the fol

[GitHub] [flink] Myracle commented on pull request #16957: [FLINK-23937][Documentation] Fix PQ comment in KeyGroupPartitionedPriorityQueue

2021-12-09 Thread GitBox
Myracle commented on pull request #16957: URL: https://github.com/apache/flink/pull/16957#issuecomment-990570193 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-25238) flink iceberg source reading array types fail with Cast Exception

2021-12-09 Thread Praneeth Ramesh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Praneeth Ramesh updated FLINK-25238: Description: I have a stream with iceberg table as a source. I have few columns of array

[jira] [Created] (FLINK-25238) flink iceberg source reading array types fail with Cast Exception

2021-12-09 Thread Praneeth Ramesh (Jira)
Praneeth Ramesh created FLINK-25238: --- Summary: flink iceberg source reading array types fail with Cast Exception Key: FLINK-25238 URL: https://issues.apache.org/jira/browse/FLINK-25238 Project: Flin

[GitHub] [flink] flinkbot edited a comment on pull request #18068: [FLINK-25105][checkpoint] Enables final checkpoint by default

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #18068: URL: https://github.com/apache/flink/pull/18068#issuecomment-989975508 ## CI report: * 5b593fe7fe22a0dce1f5cefe847b9dead2c840f0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] flinkbot edited a comment on pull request #18068: [FLINK-25105][checkpoint] Enables final checkpoint by default

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #18068: URL: https://github.com/apache/flink/pull/18068#issuecomment-989975508 ## CI report: * 5b593fe7fe22a0dce1f5cefe847b9dead2c840f0 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[GitHub] [flink] liufangqi removed a comment on pull request #17958: FLINK-25029: Hadoop Caller Context Setting in Flink

2021-12-09 Thread GitBox
liufangqi removed a comment on pull request #17958: URL: https://github.com/apache/flink/pull/17958#issuecomment-989471157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [flink] flinkbot edited a comment on pull request #18071: [FLINK-24077][hbase2/HBaseConnectorITCase] fix flaky tests backport to 1.13

2021-12-09 Thread GitBox
flinkbot edited a comment on pull request #18071: URL: https://github.com/apache/flink/pull/18071#issuecomment-990316009 ## CI report: * b5ce2147d38f1eebb0f39f901cb268c4ef06aa54 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/result

[jira] [Created] (FLINK-25237) ElasticsearchSinkITCase fails due to NoNodeAvailableException

2021-12-09 Thread Yun Tang (Jira)
Yun Tang created FLINK-25237: Summary: ElasticsearchSinkITCase fails due to NoNodeAvailableException Key: FLINK-25237 URL: https://issues.apache.org/jira/browse/FLINK-25237 Project: Flink Issue

[jira] [Resolved] (FLINK-21504) State ownership: notify TMs about checkpoint subsumption

2021-12-09 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-21504. -- Resolution: Fixed merged in master: def3855690f8a5ac24a889dc4ed5909d4f9b31aa > State ownership: notif

[GitHub] [flink] Myasuka merged pull request #16582: [FLINK-21504][checkpoint] Introduce notification of subsumed checkpoint

2021-12-09 Thread GitBox
Myasuka merged pull request #16582: URL: https://github.com/apache/flink/pull/16582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [flink] Myasuka commented on pull request #16582: [FLINK-21504][checkpoint] Introduce notification of subsumed checkpoint

2021-12-09 Thread GitBox
Myasuka commented on pull request #16582: URL: https://github.com/apache/flink/pull/16582#issuecomment-990548693 My local CI turns green: https://myasuka.visualstudio.com/flink/_build/results?buildId=362&view=results -- This is an automated message from the Apache Git Service. To respond

[jira] [Comment Edited] (FLINK-20370) Result is wrong when sink primary key is not the same with query

2021-12-09 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17455065#comment-17455065 ] Jingsong Lee edited comment on FLINK-20370 at 12/10/21, 2:11 AM: -

[jira] [Updated] (FLINK-20370) Result is wrong when sink primary key is not the same with query

2021-12-09 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-20370: - Fix Version/s: 1.13.4 > Result is wrong when sink primary key is not the same with query > -

[GitHub] [flink] JingsongLi merged pull request #18060: [FLINK-20370][table] part1: Fix wrong results when sink primary key is not the same with query result's changelog upsert key

2021-12-09 Thread GitBox
JingsongLi merged pull request #18060: URL: https://github.com/apache/flink/pull/18060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsu

[jira] [Commented] (FLINK-25207) sample pyflink from documentation doesn't work in jupyter notebooks

2021-12-09 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17456853#comment-17456853 ] Dian Fu commented on FLINK-25207: - [~Nakram] The above exception should doesn't affect t

  1   2   3   4   5   6   7   >