shenzhu commented on pull request #17919: URL: https://github.com/apache/flink/pull/17919#issuecomment-990690967
> @shenzhu Again thx for your effort! > > Please rebase with master and then: > > * I need to ask you now to use the `legacyBehaviour` from the context to decide if you apply the trimming, similarly to: https://github.com/apache/flink/blob/master/flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/casting/RowToStringCastRule.java#L170 It would be great to not even include the if statement at all in the generated code if the legacyBehaviour is `true`. > * Please also adjust the config in `CastFunctionITCase` with the following > > ``` > @Override > protected Configuration configuration() { > return super.configuration() > .set(TableConfigOptions.LOCAL_TIME_ZONE, TEST_TZ.getId()) > .set( > ExecutionConfigOptions.TABLE_EXEC_LEGACY_CAST_BEHAVIOUR, > LegacyCastBehaviour.DISABLED); > } > ``` to make sure that we always use the new behaviour for the IT tests. > ``` Sure, thanks for your feedback! I will update this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
