imaffe commented on a change in pull request #18014:
URL: https://github.com/apache/flink/pull/18014#discussion_r766313655



##########
File path: flink-test-utils-parent/flink-connector-test-utils/pom.xml
##########
@@ -54,6 +54,12 @@
                        <scope>compile</scope>
                </dependency>
 
+               <dependency>
+                       <groupId>org.assertj</groupId>

Review comment:
       Looks like this is a special module, as if I remove the dependency the 
dependency will not be found. Similarly in this pom.xml it declared 
`org.junit.jupiter:junit-jupiter` set and in parent pom it has 
`org.junit.jupiter:junit-jupiter` as well. So I figured this dependency is 
necessary here. Basically in parent dom the scope is limited to `test` and this 
module is not considered test so I guess that's why the dependency in parent 
pom didn't work




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to