[GitHub] [flink] flinkbot edited a comment on issue #9355: [FLINK-13577][ml] Add an util class to build result row and generate …

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #9355: [FLINK-13577][ml] Add an util class to build result row and generate … URL: https://github.com/apache/flink/pull/9355#issuecomment-518089359 ## CI report: * f8f3792f7ce55735f05200c90431b20b99a42d18 : FAILURE [Build](https://travis-ci.com/fli

[GitHub] [flink] flinkbot edited a comment on issue #9007: [FLINK-13131] [Deployment / YARN] add a custom directory for storing configuration files and jar files for user jobs

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #9007: [FLINK-13131] [Deployment / YARN] add a custom directory for storing configuration files and jar files for user jobs URL: https://github.com/apache/flink/pull/9007#issuecomment-513724290 ## CI report: * 716838aa5eb80e61c0eb69f26885357d17d234f

[GitHub] [flink] flinkbot edited a comment on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength URL: https://github.com/apache/flink/pull/8559#issuecomment-511466573 ## CI report: * b2e38d5e9dabd95409899c56a3064e75378fdba3 : SUCCESS [Build]

[GitHub] [flink] wuchong commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value.

2019-08-04 Thread GitBox
wuchong commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#issuecomment-518100107 I agree with you @beyond1920 , however, I

[GitHub] [flink] Aitozi commented on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength

2019-08-04 Thread GitBox
Aitozi commented on issue #8559: [FLINK-12576][Network, Metrics]Take localInputChannel into account when compute inputQueueLength URL: https://github.com/apache/flink/pull/8559#issuecomment-518099753 Done, Ping @zhijiangW Th

[GitHub] [flink] beyond1920 commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value.

2019-08-04 Thread GitBox
beyond1920 commented on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#issuecomment-518099258 @wuchong > could you also update In

[GitHub] [flink] beyond1920 edited a comment on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null val

2019-08-04 Thread GitBox
beyond1920 edited a comment on issue #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#issuecomment-518099258 @wuchong > could you also up

[GitHub] [flink] flinkbot edited a comment on issue #9354: [FLINK-13568][sqk-parser] DDL create table doesn't allow STRING data …

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #9354: [FLINK-13568][sqk-parser] DDL create table doesn't allow STRING data … URL: https://github.com/apache/flink/pull/9354#issuecomment-518083679 ## CI report: * 754c52de984cb476ae0442c6704219b64c68441e : SUCCESS [Build](https://travis-ci.com/fli

[GitHub] [flink] flinkbot commented on issue #9355: [FLINK-13577][ml] Add an util class to build result row and generate …

2019-08-04 Thread GitBox
flinkbot commented on issue #9355: [FLINK-13577][ml] Add an util class to build result row and generate … URL: https://github.com/apache/flink/pull/9355#issuecomment-518089359 ## CI report: * f8f3792f7ce55735f05200c90431b20b99a42d18 : PENDING [Build](https://travis-ci.com/flink-ci/f

[GitHub] [flink] flinkbot commented on issue #9355: [FLINK-13577][ml] Add an util class to build result row and generate …

2019-08-04 Thread GitBox
flinkbot commented on issue #9355: [FLINK-13577][ml] Add an util class to build result row and generate … URL: https://github.com/apache/flink/pull/9355#issuecomment-518088606 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[jira] [Updated] (FLINK-13577) Add an util class to build result row and generate result schema.

2019-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13577: --- Labels: pull-request-available (was: ) > Add an util class to build result row and generate

[GitHub] [flink] xuyang1706 opened a new pull request #9355: [FLINK-13577][ml] Add an util class to build result row and generate …

2019-08-04 Thread GitBox
xuyang1706 opened a new pull request #9355: [FLINK-13577][ml] Add an util class to build result row and generate … URL: https://github.com/apache/flink/pull/9355 ## What is the purpose of the change Add an util class to build result row and generate result schema, which will

[jira] [Created] (FLINK-13577) Add an util class to build result row and generate result schema.

2019-08-04 Thread Xu Yang (JIRA)
Xu Yang created FLINK-13577: --- Summary: Add an util class to build result row and generate result schema. Key: FLINK-13577 URL: https://issues.apache.org/jira/browse/FLINK-13577 Project: Flink Issu

[GitHub] [flink] zhangbinzaifendou closed pull request #9007: [FLINK-13131] [Deployment / YARN] add a custom directory for storing configuration files and jar files for user jobs

2019-08-04 Thread GitBox
zhangbinzaifendou closed pull request #9007: [FLINK-13131] [Deployment / YARN] add a custom directory for storing configuration files and jar files for user jobs URL: https://github.com/apache/flink/pull/9007 This is an aut

[GitHub] [flink] flinkbot edited a comment on issue #9007: [FLINK-13131] [Deployment / YARN] add a custom directory for storing configuration files and jar files for user jobs

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #9007: [FLINK-13131] [Deployment / YARN] add a custom directory for storing configuration files and jar files for user jobs URL: https://github.com/apache/flink/pull/9007#issuecomment-513724290 ## CI report: * 716838aa5eb80e61c0eb69f26885357d17d234f

[GitHub] [flink] flinkbot commented on issue #9354: [FLINK-13568][sqk-parser] DDL create table doesn't allow STRING data …

2019-08-04 Thread GitBox
flinkbot commented on issue #9354: [FLINK-13568][sqk-parser] DDL create table doesn't allow STRING data … URL: https://github.com/apache/flink/pull/9354#issuecomment-518083679 ## CI report: * 754c52de984cb476ae0442c6704219b64c68441e : PENDING [Build](https://travis-ci.com/flink-ci/f

[GitHub] [flink] flinkbot commented on issue #9354: [FLINK-13568][sqk-parser] DDL create table doesn't allow STRING data …

2019-08-04 Thread GitBox
flinkbot commented on issue #9354: [FLINK-13568][sqk-parser] DDL create table doesn't allow STRING data … URL: https://github.com/apache/flink/pull/9354#issuecomment-518082256 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[jira] [Updated] (FLINK-13568) DDL create table doesn't allow STRING data type

2019-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13568: --- Labels: pull-request-available (was: ) > DDL create table doesn't allow STRING data type >

[GitHub] [flink] danny0405 opened a new pull request #9354: [FLINK-13568][sqk-parser] DDL create table doesn't allow STRING data …

2019-08-04 Thread GitBox
danny0405 opened a new pull request #9354: [FLINK-13568][sqk-parser] DDL create table doesn't allow STRING data … URL: https://github.com/apache/flink/pull/9354 ## What is the purpose of the change After FLINK-13335, we have supported full data types in SQL CREATE TABLE, but the `Sq

[jira] [Assigned] (FLINK-13561) Verify and correct time function's semantic for Blink planner

2019-08-04 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13561: --- Assignee: Jark Wu > Verify and correct time function's semantic for Blink planner > ---

[GitHub] [flink] AT-Fieldless commented on issue #9350: [FLINK-13485] [chinese-translation] Translate "Table API Example Walkthrough" page into Chinese

2019-08-04 Thread GitBox
AT-Fieldless commented on issue #9350: [FLINK-13485] [chinese-translation] Translate "Table API Example Walkthrough" page into Chinese URL: https://github.com/apache/flink/pull/9350#issuecomment-518077508 > Hi, @AT-Fieldless , Thanks for your contribution. I left some suggestions. I hope i

[GitHub] [flink] flinkbot edited a comment on issue #9329: [FLINK-13545] [table-planner-blink] JoinToMultiJoinRule should not match SEMI/ANTI LogicalJoin

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #9329: [FLINK-13545] [table-planner-blink] JoinToMultiJoinRule should not match SEMI/ANTI LogicalJoin URL: https://github.com/apache/flink/pull/9329#issuecomment-517539518 ## CI report: * 079992c709866991888ec10cda40ec0395138dc2 : FAILURE [Build](h

[jira] [Commented] (FLINK-13489) Heavy deployment end-to-end test fails on Travis with TM heartbeat timeout

2019-08-04 Thread Yun Gao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899749#comment-16899749 ] Yun Gao commented on FLINK-13489: - I think the cut-off configuration problem might be in

[jira] [Commented] (FLINK-13449) Add ARM architecture to MemoryArchitecture

2019-08-04 Thread wangxiyuan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899746#comment-16899746 ] wangxiyuan commented on FLINK-13449: This problem cause some other tests fail. Such

[GitHub] [flink] lirui-apache commented on issue #9264: [FLINK-13192][hive] Add tests for different Hive table formats

2019-08-04 Thread GitBox
lirui-apache commented on issue #9264: [FLINK-13192][hive] Add tests for different Hive table formats URL: https://github.com/apache/flink/pull/9264#issuecomment-518070778 @KurtYoung could you help review and merge this PR? Thanks. --

[jira] [Commented] (FLINK-13540) DDL do not support key of properties contains number or "-"

2019-08-04 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899734#comment-16899734 ] Jark Wu commented on FLINK-13540: - Sorry [~danny831], I mis-assigned to you... > DDL d

[jira] [Assigned] (FLINK-13540) DDL do not support key of properties contains number or "-"

2019-08-04 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu reassigned FLINK-13540: --- Assignee: Danny Chan (was: Danny Chen) > DDL do not support key of properties contains number or "

[GitHub] [flink] ssquan commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/Ex

2019-08-04 Thread GitBox
ssquan commented on a change in pull request #8852: [FLINK-12798][table-api][table-planner] Add a proper discover mechanism that will enable switching between Flink & Blink Planner/Executor URL: https://github.com/apache/flink/pull/8852#discussion_r310424843 ## File path: flink-

[jira] [Commented] (FLINK-13567) Avro Confluent Schema Registry nightly end-to-end test failed on Travis

2019-08-04 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899729#comment-16899729 ] TisonKun commented on FLINK-13567: -- [~till.rohrmann] you can try out the patch attached

[jira] [Updated] (FLINK-13567) Avro Confluent Schema Registry nightly end-to-end test failed on Travis

2019-08-04 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TisonKun updated FLINK-13567: - Attachment: patch.diff > Avro Confluent Schema Registry nightly end-to-end test failed on Travis > -

[jira] [Created] (FLINK-13576) Enable configuring IntermediateResultStorage with YAML

2019-08-04 Thread Xuannan Su (JIRA)
Xuannan Su created FLINK-13576: -- Summary: Enable configuring IntermediateResultStorage with YAML Key: FLINK-13576 URL: https://issues.apache.org/jira/browse/FLINK-13576 Project: Flink Issue Type

[GitHub] [flink] wuchong commented on a change in pull request #9024: [FLINK-13119] add blink table config to documentation

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#discussion_r310423067 ## File path: docs/dev/table/blink.md ## @@ -0,0 +1,87 @@ +--- +title: "Configuration" +nav-id: "

[jira] [Created] (FLINK-13575) Introduce IntermediateResultStorageDescriptor

2019-08-04 Thread Xuannan Su (JIRA)
Xuannan Su created FLINK-13575: -- Summary: Introduce IntermediateResultStorageDescriptor Key: FLINK-13575 URL: https://issues.apache.org/jira/browse/FLINK-13575 Project: Flink Issue Type: Sub-tas

[GitHub] [flink] flinkbot edited a comment on issue #9329: [FLINK-13545] [table-planner-blink] JoinToMultiJoinRule should not match SEMI/ANTI LogicalJoin

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #9329: [FLINK-13545] [table-planner-blink] JoinToMultiJoinRule should not match SEMI/ANTI LogicalJoin URL: https://github.com/apache/flink/pull/9329#issuecomment-517539518 ## CI report: * 079992c709866991888ec10cda40ec0395138dc2 : FAILURE [Build](h

[jira] [Commented] (FLINK-9953) Active Kubernetes integration

2019-08-04 Thread frank wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899725#comment-16899725 ] frank wang commented on FLINK-9953: --- [~till.rohrmann],Now how is the project going, can

[jira] [Created] (FLINK-13573) Merge SubmittedJobGraph into JobGraph

2019-08-04 Thread TisonKun (JIRA)
TisonKun created FLINK-13573: Summary: Merge SubmittedJobGraph into JobGraph Key: FLINK-13573 URL: https://issues.apache.org/jira/browse/FLINK-13573 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-13574) Introduce IntermediateResultStorage Interface

2019-08-04 Thread Xuannan Su (JIRA)
Xuannan Su created FLINK-13574: -- Summary: Introduce IntermediateResultStorage Interface Key: FLINK-13574 URL: https://issues.apache.org/jira/browse/FLINK-13574 Project: Flink Issue Type: Sub-tas

[GitHub] [flink] godfreyhe commented on issue #9349: [FLINK-13564] [table-planner-blink] throw exception if constant with YEAR TO MONTH resolution was used for group windows

2019-08-04 Thread GitBox
godfreyhe commented on issue #9349: [FLINK-13564] [table-planner-blink] throw exception if constant with YEAR TO MONTH resolution was used for group windows URL: https://github.com/apache/flink/pull/9349#issuecomment-518062674 my private travis is green https://travis-ci.org/godfreyhe/flin

[jira] [Created] (FLINK-13572) Introduce Configurable, TableCreationHook and TableCleanupHook Interfaces

2019-08-04 Thread Xuannan Su (JIRA)
Xuannan Su created FLINK-13572: -- Summary: Introduce Configurable, TableCreationHook and TableCleanupHook Interfaces Key: FLINK-13572 URL: https://issues.apache.org/jira/browse/FLINK-13572 Project: Flink

[jira] [Created] (FLINK-13571) Support full data type in sql DML

2019-08-04 Thread Danny Chan (JIRA)
Danny Chan created FLINK-13571: -- Summary: Support full data type in sql DML Key: FLINK-13571 URL: https://issues.apache.org/jira/browse/FLINK-13571 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-13570) Pluggable Intermediate Result Storage

2019-08-04 Thread Xuannan Su (JIRA)
Xuannan Su created FLINK-13570: -- Summary: Pluggable Intermediate Result Storage Key: FLINK-13570 URL: https://issues.apache.org/jira/browse/FLINK-13570 Project: Flink Issue Type: New Feature

[jira] [Commented] (FLINK-13550) Support for CPU FlameGraphs in new web UI

2019-08-04 Thread Yadong Xie (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899721#comment-16899721 ] Yadong Xie commented on FLINK-13550: Great job [~davidmoravek] ! I can offer fronte

[jira] [Commented] (FLINK-13569) DDL table property key is defined as indentifier but should be string literal instead

2019-08-04 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899715#comment-16899715 ] Jark Wu commented on FLINK-13569: - [~danny0405], I think this is the same problem with F

[jira] [Commented] (FLINK-13569) DDL table property key is defined as indentifier but should be string literal instead

2019-08-04 Thread Danny Chan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899714#comment-16899714 ] Danny Chan commented on FLINK-13569: I disagree, because string literal and identifi

[jira] [Created] (FLINK-13569) DDL table property key is defined as indentifier but should be string literal instead

2019-08-04 Thread Xuefu Zhang (JIRA)
Xuefu Zhang created FLINK-13569: --- Summary: DDL table property key is defined as indentifier but should be string literal instead Key: FLINK-13569 URL: https://issues.apache.org/jira/browse/FLINK-13569 P

[jira] [Created] (FLINK-13568) DDL create table doesn't allow STRING data type

2019-08-04 Thread Xuefu Zhang (JIRA)
Xuefu Zhang created FLINK-13568: --- Summary: DDL create table doesn't allow STRING data type Key: FLINK-13568 URL: https://issues.apache.org/jira/browse/FLINK-13568 Project: Flink Issue Type: Bug

[jira] [Created] (FLINK-13567) Avro Confluent Schema Registry nightly end-to-end test failed on Travis

2019-08-04 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-13567: - Summary: Avro Confluent Schema Registry nightly end-to-end test failed on Travis Key: FLINK-13567 URL: https://issues.apache.org/jira/browse/FLINK-13567 Project: Fl

[GitHub] [flink] flinkbot edited a comment on issue #9343: [FLINK-13508][1.8][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #9343: [FLINK-13508][1.8][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time URL: https://github.com/apache/flink/pull/9343#issuecomment-517783288 ## CI report: * 0425fb36fe495cdca6e54523567e37d9bb2b8132 : FAILURE [

[jira] [Commented] (FLINK-13566) Support checkpoint configuration through flink-conf.yaml

2019-08-04 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899674#comment-16899674 ] Gyula Fora commented on FLINK-13566: I don't think there is a good enough reason unf

[jira] [Commented] (FLINK-13566) Support checkpoint configuration through flink-conf.yaml

2019-08-04 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899673#comment-16899673 ] Yun Tang commented on FLINK-13566: -- We could configure the checkpoint/savepoint directo

[GitHub] [flink] GJL closed pull request #9341: [FLINK-13508][1.9][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time

2019-08-04 Thread GitBox
GJL closed pull request #9341: [FLINK-13508][1.9][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time URL: https://github.com/apache/flink/pull/9341 This is an automated message from the Apach

[GitHub] [flink] GJL commented on issue #9341: [FLINK-13508][1.9][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time

2019-08-04 Thread GitBox
GJL commented on issue #9341: [FLINK-13508][1.9][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time URL: https://github.com/apache/flink/pull/9341#issuecomment-518027058 Merged This is an auto

[jira] [Created] (FLINK-13566) Support checkpoint configuration through flink-conf.yaml

2019-08-04 Thread Gyula Fora (JIRA)
Gyula Fora created FLINK-13566: -- Summary: Support checkpoint configuration through flink-conf.yaml Key: FLINK-13566 URL: https://issues.apache.org/jira/browse/FLINK-13566 Project: Flink Issue Ty

[GitHub] [flink] flinkbot edited a comment on issue #9343: [FLINK-13508][1.8][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #9343: [FLINK-13508][1.8][tests] CommonTestUtils#waitUntilCondition() may attempt to sleep with negative time URL: https://github.com/apache/flink/pull/9343#issuecomment-517783288 ## CI report: * 0425fb36fe495cdca6e54523567e37d9bb2b8132 : FAILURE [

[GitHub] [flink] flinkbot edited a comment on issue #9353: Add a new connector ' flink-connector-rocketmq'

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #9353: Add a new connector ' flink-connector-rocketmq' URL: https://github.com/apache/flink/pull/9353#issuecomment-518013889 ## CI report: * ae86a133468c692d9d29a78e4189412c997a5752 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/1218

[jira] [Commented] (FLINK-13548) Support priority of the Flink YARN application

2019-08-04 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899652#comment-16899652 ] Rong Rong commented on FLINK-13548: --- Hi [~boswell], thanks for bringing up this discus

[GitHub] [flink] flinkbot commented on issue #9353: Add a new connector ' flink-connector-rocketmq'

2019-08-04 Thread GitBox
flinkbot commented on issue #9353: Add a new connector ' flink-connector-rocketmq' URL: https://github.com/apache/flink/pull/9353#issuecomment-518013889 ## CI report: * ae86a133468c692d9d29a78e4189412c997a5752 : PENDING [Build](https://travis-ci.com/flink-ci/flink/builds/121877710)

[GitHub] [flink] flinkbot commented on issue #9353: Add a new connector ' flink-connector-rocketmq'

2019-08-04 Thread GitBox
flinkbot commented on issue #9353: Add a new connector ' flink-connector-rocketmq' URL: https://github.com/apache/flink/pull/9353#issuecomment-518013532 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. W

[GitHub] [flink] mikiaichiyu opened a new pull request #9353: Add a new connector ' flink-connector-rocketmq'

2019-08-04 Thread GitBox
mikiaichiyu opened a new pull request #9353: Add a new connector ' flink-connector-rocketmq' URL: https://github.com/apache/flink/pull/9353 ## What is the purpose of the change *Added a new flink-connector to connect RocketMQ cluster, then can implement the message producing

[jira] [Closed] (FLINK-13560) Expose YARN ship files option flag for flink CLI run

2019-08-04 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-13560. -- > Expose YARN ship files option flag for flink CLI run > -

[jira] [Resolved] (FLINK-13560) Expose YARN ship files option flag for flink CLI run

2019-08-04 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora resolved FLINK-13560. Resolution: Not A Problem > Expose YARN ship files option flag for flink CLI run > ---

[jira] [Closed] (FLINK-13559) Expose YARN Dynamic configuration option flag for flink CLI run

2019-08-04 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-13559. -- > Expose YARN Dynamic configuration option flag for flink CLI run > --

[jira] [Commented] (FLINK-13559) Expose YARN Dynamic configuration option flag for flink CLI run

2019-08-04 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899649#comment-16899649 ] Gyula Fora commented on FLINK-13559: Sorry turns out -yD key=value actually works >

[jira] [Resolved] (FLINK-13559) Expose YARN Dynamic configuration option flag for flink CLI run

2019-08-04 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora resolved FLINK-13559. Resolution: Not A Problem > Expose YARN Dynamic configuration option flag for flink CLI run >

[GitHub] [flink] mans2singh edited a comment on issue #9325: [FLINK-13542][metrics] Update datadog reporter to send metrics if the…

2019-08-04 Thread GitBox
mans2singh edited a comment on issue #9325: [FLINK-13542][metrics] Update datadog reporter to send metrics if the… URL: https://github.com/apache/flink/pull/9325#issuecomment-517944144 Hi @zentol I have an application that registers only specific metrics which are based on data and

[GitHub] [flink] mans2singh edited a comment on issue #9325: [FLINK-13542][metrics] Update datadog reporter to send metrics if the…

2019-08-04 Thread GitBox
mans2singh edited a comment on issue #9325: [FLINK-13542][metrics] Update datadog reporter to send metrics if the… URL: https://github.com/apache/flink/pull/9325#issuecomment-517944144 Hi @zentol I have an application that registers only specific metrics which are based on data and

[GitHub] [flink] wuchong commented on a change in pull request #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#discussion_r310389980 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#discussion_r310390327 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#discussion_r310390595 ## File path:

[GitHub] [flink] wuchong commented on a change in pull request #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9285: [FLINK-13433][table-planner-blink] Do not fetch data from LookupableTableSource if the JoinKey in left side of LookupJoin contains null value. URL: https://github.com/apache/flink/pull/9285#discussion_r310390743 ## File path:

[jira] [Comment Edited] (FLINK-13317) Merge NetUtils and ClientUtils

2019-08-04 Thread Charles Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899645#comment-16899645 ] Charles Xu edited comment on FLINK-13317 at 8/4/19 3:02 PM:

[jira] [Commented] (FLINK-13317) Merge NetUtils and ClientUtils

2019-08-04 Thread Charles Xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899645#comment-16899645 ] Charles Xu commented on FLINK-13317: Should I merge the commit to release-1.9 or apa

[GitHub] [flink] flinkbot commented on issue #9352: FLINK-13317 Merge NetUtils and ClientUtils

2019-08-04 Thread GitBox
flinkbot commented on issue #9352: FLINK-13317 Merge NetUtils and ClientUtils URL: https://github.com/apache/flink/pull/9352#issuecomment-518010490 ## CI report: * 2c2b8ec8ad260a021792fb7ac41e2c1c15da0722 : FAILURE [Build](https://travis-ci.com/flink-ci/flink/builds/121876465) -

[GitHub] [flink] flinkbot commented on issue #9352: FLINK-13317 Merge NetUtils and ClientUtils

2019-08-04 Thread GitBox
flinkbot commented on issue #9352: FLINK-13317 Merge NetUtils and ClientUtils URL: https://github.com/apache/flink/pull/9352#issuecomment-518009973 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will

[GitHub] [flink] xuchao0903 opened a new pull request #9352: FLINK-13317 Merge NetUtils and ClientUtils

2019-08-04 Thread GitBox
xuchao0903 opened a new pull request #9352: FLINK-13317 Merge NetUtils and ClientUtils URL: https://github.com/apache/flink/pull/9352 ## What is the purpose of the change This pull request merges ClientUtils and NetUtils into one class (NetUtils). That way we reduce the duplicat

[jira] [Updated] (FLINK-13317) Merge NetUtils and ClientUtils

2019-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-13317: --- Labels: pull-request-available (was: ) > Merge NetUtils and ClientUtils > -

[GitHub] [flink] wuchong commented on a change in pull request #9024: [FLINK-13119] add blink table config to documentation

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#discussion_r310389557 ## File path: flink-docs/src/main/java/org/apache/flink/docs/configuration/ConfigOptionsDocGenerator.java

[GitHub] [flink] wuchong commented on a change in pull request #9024: [FLINK-13119] add blink table config to documentation

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#discussion_r310389441 ## File path: docs/dev/table/blink.md ## @@ -0,0 +1,87 @@ +--- Review comment: Please renam

[GitHub] [flink] wuchong commented on a change in pull request #9024: [FLINK-13119] add blink table config to documentation

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#discussion_r310389465 ## File path: docs/dev/table/blink.md ## @@ -0,0 +1,87 @@ +--- +title: "Configuration" +nav-id: "

[GitHub] [flink] wuchong commented on a change in pull request #9024: [FLINK-13119] add blink table config to documentation

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9024: [FLINK-13119] add blink table config to documentation URL: https://github.com/apache/flink/pull/9024#discussion_r310389494 ## File path: docs/dev/table/blink.md ## @@ -0,0 +1,87 @@ +--- +title: "Configuration" +nav-id: "

[GitHub] [flink] xuchao0903 closed pull request #9182: FLINK-13130 Refactor AbstractYarnClusterDescriptor to reduce code dup…

2019-08-04 Thread GitBox
xuchao0903 closed pull request #9182: FLINK-13130 Refactor AbstractYarnClusterDescriptor to reduce code dup… URL: https://github.com/apache/flink/pull/9182 This is an automated message from the Apache Git Service. To respond

[jira] [Created] (FLINK-13565) Integrate springboot found error

2019-08-04 Thread feixue (JIRA)
feixue created FLINK-13565: -- Summary: Integrate springboot found error Key: FLINK-13565 URL: https://issues.apache.org/jira/browse/FLINK-13565 Project: Flink Issue Type: Improvement Compon

[GitHub] [flink] wuchong commented on a change in pull request #9331: [FLINK-13523][table-planner-blink] Verify and correct arithmetic function's semantic for Blink planner

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9331: [FLINK-13523][table-planner-blink] Verify and correct arithmetic function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9331#discussion_r310388560 ## File path: flink-table/flink-table-planner-blink/src/

[GitHub] [flink] wuchong commented on issue #9331: [FLINK-13523][table-planner-blink] Verify and correct arithmetic function's semantic for Blink planner

2019-08-04 Thread GitBox
wuchong commented on issue #9331: [FLINK-13523][table-planner-blink] Verify and correct arithmetic function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9331#issuecomment-518005874 @JingsongLi , could you help to review this PR too ? -

[GitHub] [flink] wuchong commented on issue #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink

2019-08-04 Thread GitBox
wuchong commented on issue #9099: [FLINK-13237][table-planner-blink] Add expression table api test to blink URL: https://github.com/apache/flink/pull/9099#issuecomment-518004957 Thanks @JingsongLi , this looks good to me now. However, there are cases failed on travis, could you have

[GitHub] [flink] wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316#discussion_r310385973 ## File path: flink-table/flink-table-planner-blink/src/main/ja

[GitHub] [flink] wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316#discussion_r310386633 ## File path: flink-table/flink-table-planner-blink/src/main/sc

[GitHub] [flink] wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316#discussion_r310385134 ## File path: flink-table/flink-table-planner-blink/src/test/sc

[GitHub] [flink] wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316#discussion_r310386164 ## File path: flink-table/flink-table-planner-blink/src/main/ja

[GitHub] [flink] wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316#discussion_r310006944 ## File path: flink-table/flink-table-planner-blink/src/main/ja

[GitHub] [flink] wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316#discussion_r310386025 ## File path: flink-table/flink-table-planner-blink/src/main/ja

[GitHub] [flink] wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316#discussion_r310386367 ## File path: flink-table/flink-table-planner-blink/src/main/ja

[GitHub] [flink] wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316#discussion_r310385981 ## File path: flink-table/flink-table-planner-blink/src/main/ja

[GitHub] [flink] wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner

2019-08-04 Thread GitBox
wuchong commented on a change in pull request #9316: [FLINK-13529][table-planner-blink] Verify and correct agg function's semantic for Blink planner URL: https://github.com/apache/flink/pull/9316#discussion_r310386622 ## File path: flink-table/flink-table-planner-blink/src/main/sc

[GitHub] [flink] flinkbot edited a comment on issue #9182: FLINK-13130 Refactor AbstractYarnClusterDescriptor to reduce code dup…

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #9182: FLINK-13130 Refactor AbstractYarnClusterDescriptor to reduce code dup… URL: https://github.com/apache/flink/pull/9182#issuecomment-513290077 ## CI report: * 2975f3ecd708ef9a02cede05c358b9fbff888372 : FAILURE [Build](https://travis-ci.com/fli

[jira] [Closed] (FLINK-13518) Disable Hive tests

2019-08-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-13518. Resolution: Fixed master: 37aee5e749213c2d97f5decf10ed45d28b89e271 > Disable Hive tests >

[GitHub] [flink] zentol merged pull request #9319: [FLINK-13518][hive] Disable tests on Java 11

2019-08-04 Thread GitBox
zentol merged pull request #9319: [FLINK-13518][hive] Disable tests on Java 11 URL: https://github.com/apache/flink/pull/9319 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] flinkbot edited a comment on issue #8350: [FLINK-12403][doc-zh]Translate 'How to use logging' page into Chinese

2019-08-04 Thread GitBox
flinkbot edited a comment on issue #8350: [FLINK-12403][doc-zh]Translate 'How to use logging' page into Chinese URL: https://github.com/apache/flink/pull/8350#issuecomment-517984448 ## CI report: * e5ead8e196dff7da0eeae41f320a4b66f782ba6b : SUCCESS [Build](https://travis-ci.com/flin

[GitHub] [flink] YngwieWang commented on a change in pull request #8350: [FLINK-12403][doc-zh]Translate 'How to use logging' page into Chinese

2019-08-04 Thread GitBox
YngwieWang commented on a change in pull request #8350: [FLINK-12403][doc-zh]Translate 'How to use logging' page into Chinese URL: https://github.com/apache/flink/pull/8350#discussion_r310377060 ## File path: docs/monitoring/logging.zh.md ## @@ -81,15 +78,13 @@ import org.

[jira] [Resolved] (FLINK-13190) add test to verify partition pruning for HiveTableSource

2019-08-04 Thread Jark Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-13190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu resolved FLINK-13190. - Resolution: Fixed Fix Version/s: 1.10.0 Fixed in 1.10.0: 858841d20881d0544aa4b46ba936d29c1132e779

  1   2   >