wuchong commented on a change in pull request #9024: [FLINK-13119] add blink
table config to documentation
URL: https://github.com/apache/flink/pull/9024#discussion_r310389557
##########
File path:
flink-docs/src/main/java/org/apache/flink/docs/configuration/ConfigOptionsDocGenerator.java
##########
@@ -260,10 +262,26 @@ private static String toHtmlTable(final
List<OptionWithMetaInfo> options) {
private static String toHtmlString(final OptionWithMetaInfo
optionWithMetaInfo) {
ConfigOption<?> option = optionWithMetaInfo.option;
String defaultValue = stringifyDefault(optionWithMetaInfo);
+ Documentation.TableMeta tableMeta =
optionWithMetaInfo.field.getAnnotation(Documentation.TableMeta.class);
+ StringBuilder sb = new StringBuilder();
+ if (tableMeta != null) {
+ Documentation.ExecMode execMode = tableMeta.execMode();
+ if
(Documentation.ExecMode.BATCH_STREAMING.equals(execMode)) {
+ sb.append("<br> <span class=\"label
label-primary\">")
+ .append("BATCH")
Review comment:
Hi @XuPingyong , could you update this too for a better protection?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
