wuchong commented on a change in pull request #9285: 
[FLINK-13433][table-planner-blink]  Do not fetch data from 
LookupableTableSource if the JoinKey in left side of LookupJoin contains null 
value.
URL: https://github.com/apache/flink/pull/9285#discussion_r310389980
 
 

 ##########
 File path: 
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/LookupJoinCodeGenerator.scala
 ##########
 @@ -65,7 +65,7 @@ object LookupJoinCodeGenerator {
     : GeneratedFunction[FlatMapFunction[BaseRow, BaseRow]] = {
 
     val ctx = CodeGeneratorContext(config)
-    val (prepareCode, parameters) = prepareParameters(
+    val (prepareCode, parameters, parametersCheckNullCode) = prepareParameters(
 
 Review comment:
   `parametersCheckNullCode` -> `nullInParameters` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to