[jira] [Created] (FLINK-12372) Implement ExecutionSlotAllocator

2019-04-29 Thread Gary Yao (JIRA)
Gary Yao created FLINK-12372: Summary: Implement ExecutionSlotAllocator Key: FLINK-12372 URL: https://issues.apache.org/jira/browse/FLINK-12372 Project: Flink Issue Type: Sub-task Compo

[GitHub] [flink] zhijiangW commented on a change in pull request #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment

2019-04-29 Thread GitBox
zhijiangW commented on a change in pull request #8310: [FLINK-12331][network] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8310#discussion_r279631107 ## File path: flink-runtime/src/main/java/org/apa

[jira] [Commented] (FLINK-11921) Upgrade Calcite dependency to 1.19

2019-04-29 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830009#comment-16830009 ] Kurt Young commented on FLINK-11921: cc [~danny0405] > Upgrade Calcite dependency t

[jira] [Commented] (FLINK-12070) Make blocking result partitions consumable multiple times

2019-04-29 Thread ryantaocer (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16830003#comment-16830003 ] ryantaocer commented on FLINK-12070: [~StephanEwen] thank you for the response!  I a

[GitHub] [flink] flinkbot commented on issue #8317: [FLINK-12371] [table-planner-blink] Add support for converting (NOT) IN/ (NOT) EXISTS to SemiJoin, and generating optimized logical plan

2019-04-29 Thread GitBox
flinkbot commented on issue #8317: [FLINK-12371] [table-planner-blink] Add support for converting (NOT) IN/ (NOT) EXISTS to SemiJoin, and generating optimized logical plan URL: https://github.com/apache/flink/pull/8317#issuecomment-487835092 Thanks a lot for your contribution to the Apache

[jira] [Updated] (FLINK-12371) Add support for converting (NOT) IN/ (NOT) EXISTS to SemiJoin, and generating optimized logical plan

2019-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12371: --- Labels: pull-request-available (was: ) > Add support for converting (NOT) IN/ (NOT) EXISTS

[GitHub] [flink] godfreyhe opened a new pull request #8317: [FLINK-12371] [table-planner-blink] Add support for converting (NOT) IN/ (NOT) EXISTS to SemiJoin, and generating optimized logical plan

2019-04-29 Thread GitBox
godfreyhe opened a new pull request #8317: [FLINK-12371] [table-planner-blink] Add support for converting (NOT) IN/ (NOT) EXISTS to SemiJoin, and generating optimized logical plan URL: https://github.com/apache/flink/pull/8317 ## What is the purpose of the change *Add suppor

[jira] [Assigned] (FLINK-11636) Translate "State Schema Evolution" into Chinese

2019-04-29 Thread YangFei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YangFei reassigned FLINK-11636: --- Assignee: YangFei > Translate "State Schema Evolution" into Chinese > -

[jira] [Updated] (FLINK-12371) Add support for converting (NOT) IN/ (NOT) EXISTS to SemiJoin, and generating optimized logical plan

2019-04-29 Thread godfrey he (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he updated FLINK-12371: --- Description: This issue aims to convert IN/EXISTS to semi-join, and NOT IN/NOT EXISTS to anti-join.

[jira] [Created] (FLINK-12371) Add support for converting (NOT) IN/ (NOT) EXISTS to SemiJoin, and generating optimized logical plan

2019-04-29 Thread godfrey he (JIRA)
godfrey he created FLINK-12371: -- Summary: Add support for converting (NOT) IN/ (NOT) EXISTS to SemiJoin, and generating optimized logical plan Key: FLINK-12371 URL: https://issues.apache.org/jira/browse/FLINK-12371

[GitHub] [flink] zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode

2019-04-29 Thread GitBox
zjffdu commented on issue #8144: [FLINK-12159]. Enable YarnMiniCluster integration test under non-secure mode URL: https://github.com/apache/flink/pull/8144#issuecomment-487822515 @tillrohrmann I could do other refactoring/improvement in another followup pr. Thanks for the review. Do you

[jira] [Assigned] (FLINK-12370) Integrated Travis for Python Table API

2019-04-29 Thread Wei Zhong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei Zhong reassigned FLINK-12370: - Assignee: Wei Zhong > Integrated Travis for Python Table API >

[GitHub] [flink] sunjincheng121 commented on issue #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on issue #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#issuecomment-487818672 I have created the JIRA for Integrated Travis for Python Table API. ht

[jira] [Created] (FLINK-12370) Integrated Travis for Python Table API

2019-04-29 Thread sunjincheng (JIRA)
sunjincheng created FLINK-12370: --- Summary: Integrated Travis for Python Table API Key: FLINK-12370 URL: https://issues.apache.org/jira/browse/FLINK-12370 Project: Flink Issue Type: Sub-task

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279607459 ## File path: flink-python/pyflink/table/tab

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279600310 ## File path: flink-python/README.md ##

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279585800 ## File path: docs/dev/table/tableApi.zh.md

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279590864 ## File path: flink-python/README.md ##

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279586605 ## File path: flink-dist/src/main/assemblies

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279603205 ## File path: flink-python/pyflink/table/tab

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279589827 ## File path: flink-python/pom.xml

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279590263 ## File path: docs/dev/table/tableApi.zh.md

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279584911 ## File path: docs/dev/table/tableApi.md ##

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279601910 ## File path: flink-dist/src/main/flink-bin/

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279605826 ## File path: flink-python/pyflink/table/tab

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279589515 ## File path: flink-python/README.md ##

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279600480 ## File path: flink-python/pyflink/find_flin

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279600010 ## File path: flink-python/README.md ##

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279591670 ## File path: flink-python/README.md ##

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279594338 ## File path: flink-python/pyflink/java_gate

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279603054 ## File path: flink-python/pyflink/table/tab

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279594143 ## File path: .gitignore ## @@ -14

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279607459 ## File path: flink-python/pyflink/table/tab

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279588033 ## File path: flink-dist/src/main/flink-bin/

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279592971 ## File path: flink-python/setup.py ###

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279588708 ## File path: flink-dist/src/main/flink-bin/

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8267: [FLINK-12311][table][python] Add base python framework and Add Scan, Projection, and Filter operator support URL: https://github.com/apache/flink/pull/8267#discussion_r279602913 ## File path: flink-python/pyflink/table/tab

[GitHub] [flink] GJL closed pull request #7999: [hotfix][runtime] Remove unused local variable in ExecutionGraphBuilder

2019-04-29 Thread GitBox
GJL closed pull request #7999: [hotfix][runtime] Remove unused local variable in ExecutionGraphBuilder URL: https://github.com/apache/flink/pull/7999 This is an automated message from the Apache Git Service. To respond to th

[GitHub] [flink] GJL edited a comment on issue #7999: [hotfix][runtime] Remove unused local variable in ExecutionGraphBuilder

2019-04-29 Thread GitBox
GJL edited a comment on issue #7999: [hotfix][runtime] Remove unused local variable in ExecutionGraphBuilder URL: https://github.com/apache/flink/pull/7999#issuecomment-487817067 Already fixed in https://github.com/apache/flink/commit/306a8eb58e261115cad59a533640b56496d10999 Sorry f

[GitHub] [flink] GJL commented on issue #7999: [hotfix][runtime] Remove unused local variable in ExecutionGraphBuilder

2019-04-29 Thread GitBox
GJL commented on issue #7999: [hotfix][runtime] Remove unused local variable in ExecutionGraphBuilder URL: https://github.com/apache/flink/pull/7999#issuecomment-487817067 Already fixed in https://github.com/apache/flink/commit/306a8eb58e261115cad59a533640b56496d10999

[GitHub] [flink] bowenli86 commented on issue #8312: [FLINK-12366][table] Clean up Catalog APIs to make them more consiste…

2019-04-29 Thread GitBox
bowenli86 commented on issue #8312: [FLINK-12366][table] Clean up Catalog APIs to make them more consiste… URL: https://github.com/apache/flink/pull/8312#issuecomment-487815417 @KurtYoung Would be good to have you take a look, and help to merge if there's no more concerns. Thanks! ---

[jira] [Updated] (FLINK-12369) Implement a region failover strategy regarding the next version FailoverStrategy interfaces

2019-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12369: --- Labels: pull-request-available (was: ) > Implement a region failover strategy regarding the

[GitHub] [flink] flinkbot commented on issue #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces

2019-04-29 Thread GitBox
flinkbot commented on issue #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces URL: https://github.com/apache/flink/pull/8316#issuecomment-487813728 Thanks a lot for your contribution to the Apache Flink project. I

[GitHub] [flink] zhuzhurk opened a new pull request #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces

2019-04-29 Thread GitBox
zhuzhurk opened a new pull request #8316: [FLINK-12369] [coordination] Implement a region failover strategy regarding the next version FailoverStrategy interfaces URL: https://github.com/apache/flink/pull/8316 ## What is the purpose of the change *This pull request implements a regi

[jira] [Updated] (FLINK-12369) Implement a region failover strategy regarding the next version FailoverStrategy interfaces

2019-04-29 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-12369: Description: It is a re-requisite of FLINK-12068.  The new strategy interface design can be found at FLIN

[jira] [Updated] (FLINK-12369) Implement a region failover strategy regarding the next version FailoverStrategy interfaces

2019-04-29 Thread Zhu Zhu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-12369: Summary: Implement a region failover strategy regarding the next version FailoverStrategy interfaces (was

[jira] [Created] (FLINK-12369) Introducing next version failover strategy interfaces and implement a region failover strategy with it

2019-04-29 Thread Zhu Zhu (JIRA)
Zhu Zhu created FLINK-12369: --- Summary: Introducing next version failover strategy interfaces and implement a region failover strategy with it Key: FLINK-12369 URL: https://issues.apache.org/jira/browse/FLINK-12369

[GitHub] [flink] tianchen92 closed pull request #8240: [FLINK-12293][docs, datastream]Fix some comment typos in flink-streaming-java.

2019-04-29 Thread GitBox
tianchen92 closed pull request #8240: [FLINK-12293][docs, datastream]Fix some comment typos in flink-streaming-java. URL: https://github.com/apache/flink/pull/8240 This is an automated message from the Apache Git Service. To

[GitHub] [flink] tianchen92 commented on issue #8240: [FLINK-12293][docs, datastream]Fix some comment typos in flink-streaming-java.

2019-04-29 Thread GitBox
tianchen92 commented on issue #8240: [FLINK-12293][docs, datastream]Fix some comment typos in flink-streaming-java. URL: https://github.com/apache/flink/pull/8240#issuecomment-487809375 @rmetzger Thanks for replying, I have closed this PR. --

[GitHub] [flink] kisimple commented on issue #7757: [FLINK-11630] Triggers the termination of all running Tasks when shutting down TaskExecutor

2019-04-29 Thread GitBox
kisimple commented on issue #7757: [FLINK-11630] Triggers the termination of all running Tasks when shutting down TaskExecutor URL: https://github.com/apache/flink/pull/7757#issuecomment-487809077 Hi @azagrebin many thanks for your review and very sorry for the late reply, I will address t

[jira] [Comment Edited] (FLINK-10929) Add support for Apache Arrow

2019-04-29 Thread Liya Fan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16826677#comment-16826677 ] Liya Fan edited comment on FLINK-10929 at 4/30/19 3:01 AM: --- Hi

[jira] [Assigned] (FLINK-10446) Use the "guava beta checker" plugin to keep off of @Beta API

2019-04-29 Thread Ji Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu reassigned FLINK-10446: -- Assignee: (was: Ji Liu) > Use the "guava beta checker" plugin to keep off of @Beta API >

[jira] [Assigned] (FLINK-12145) Host config in flink-web is incorrect

2019-04-29 Thread Ji Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu reassigned FLINK-12145: -- Assignee: (was: Ji Liu) > Host config in flink-web is incorrect > ---

[jira] [Assigned] (FLINK-12349) invalid

2019-04-29 Thread Ji Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ji Liu reassigned FLINK-12349: -- Assignee: (was: Ji Liu) > invalid > --- > > Key: FLINK-12349 >

[GitHub] [flink] FaxianZhao commented on a change in pull request #8248: [FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align

2019-04-29 Thread GitBox
FaxianZhao commented on a change in pull request #8248: [FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align URL: https://github.com/apache/flink/pull/8248#discussion_r279599610 ## File path: flink-connectors/flink-jdbc/src/main/java/org/apache/

[GitHub] [flink] FaxianZhao commented on a change in pull request #8248: [FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align

2019-04-29 Thread GitBox
FaxianZhao commented on a change in pull request #8248: [FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align URL: https://github.com/apache/flink/pull/8248#discussion_r279599519 ## File path: flink-connectors/flink-jdbc/src/test/java/org/apache/

[GitHub] [flink] FaxianZhao commented on a change in pull request #8248: [FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align

2019-04-29 Thread GitBox
FaxianZhao commented on a change in pull request #8248: [FLINK-12309][JDBC] JDBCOoutputFormat and JDBCAppendTableSink float behavior is not align URL: https://github.com/apache/flink/pull/8248#discussion_r279599496 ## File path: flink-connectors/flink-jdbc/src/test/java/org/apache/

[GitHub] [flink] hequn8128 commented on issue #8301: [FLINK-12357][api-java][hotfix] Remove useless code in TableConfig

2019-04-29 Thread GitBox
hequn8128 commented on issue #8301: [FLINK-12357][api-java][hotfix] Remove useless code in TableConfig URL: https://github.com/apache/flink/pull/8301#issuecomment-487796670 @twalthr Thank you very much for the review. This is

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279592781 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.

[GitHub] [flink] KurtYoung commented on a change in pull request #8302: [FLINK-12269][table-blink] Support Temporal Table Join in blink planner and runtime

2019-04-29 Thread GitBox
KurtYoung commented on a change in pull request #8302: [FLINK-12269][table-blink] Support Temporal Table Join in blink planner and runtime URL: https://github.com/apache/flink/pull/8302#discussion_r279592398 ## File path: flink-table/flink-table-planner-blink/src/test/resources/or

[GitHub] [flink] flinkbot edited a comment on issue #8238: [FLINK-11732] [docs] Add a language switch to the sidebar for Flink documents

2019-04-29 Thread GitBox
flinkbot edited a comment on issue #8238: [FLINK-11732] [docs] Add a language switch to the sidebar for Flink documents URL: https://github.com/apache/flink/pull/8238#issuecomment-485405256 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the commun

[GitHub] [flink] sunjincheng121 commented on a change in pull request #8238: [FLINK-11732] [docs] Add a language switch to the sidebar for Flink documents

2019-04-29 Thread GitBox
sunjincheng121 commented on a change in pull request #8238: [FLINK-11732] [docs] Add a language switch to the sidebar for Flink documents URL: https://github.com/apache/flink/pull/8238#discussion_r279583940 ## File path: docs/_layouts/plain.html ## @@ -64,3 +64,9 @@ {{ pag

[GitHub] [flink] flinkbot edited a comment on issue #8238: [FLINK-11732] [docs] Add a language switch to the sidebar for Flink documents

2019-04-29 Thread GitBox
flinkbot edited a comment on issue #8238: [FLINK-11732] [docs] Add a language switch to the sidebar for Flink documents URL: https://github.com/apache/flink/pull/8238#issuecomment-485405256 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the commun

[GitHub] [flink] sunjincheng121 commented on issue #8238: [FLINK-11732] [docs] Add a language switch to the sidebar for Flink documents

2019-04-29 Thread GitBox
sunjincheng121 commented on issue #8238: [FLINK-11732] [docs] Add a language switch to the sidebar for Flink documents URL: https://github.com/apache/flink/pull/8238#issuecomment-487785374 @flinkbot approve-until architecture

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279582178 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.jav

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279582074 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.jav

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279581962 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.jav

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279581568 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.jav

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279581120 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCa

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279581079 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCa

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279573210 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279573127 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279572332 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279571858 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279572488 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279570916 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemor

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279568940 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemor

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279569853 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.

[GitHub] [flink] flinkbot commented on issue #8315: [FLINK-12368] add subtask index to FlinkKafkaConsumerBase logging, wh…

2019-04-29 Thread GitBox
flinkbot commented on issue #8315: [FLINK-12368] add subtask index to FlinkKafkaConsumerBase logging, wh… URL: https://github.com/apache/flink/pull/8315#issuecomment-48772 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to revi

[jira] [Updated] (FLINK-12368) add subtask index to FlinkKafkaConsumerBase logging, which can be very useful when debugging problem

2019-04-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12368: --- Labels: pull-request-available (was: ) > add subtask index to FlinkKafkaConsumerBase loggin

[GitHub] [flink] stevenzwu opened a new pull request #8315: [FLINK-12368] add subtask index to FlinkKafkaConsumerBase logging, wh…

2019-04-29 Thread GitBox
stevenzwu opened a new pull request #8315: [FLINK-12368] add subtask index to FlinkKafkaConsumerBase logging, wh… URL: https://github.com/apache/flink/pull/8315 …ich can be very useful when debugging problem This is a

[GitHub] [flink] piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-04-29 Thread GitBox
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#issuecomment-487765637 Thanks for getting back and taking a look @tillrohrmann and @shuai-xu. To answer some of your top level comments / questions:

[jira] [Created] (FLINK-12368) add subtask index to FlinkKafkaConsumerBase logging, which can be very useful when debugging problem

2019-04-29 Thread Steven Zhen Wu (JIRA)
Steven Zhen Wu created FLINK-12368: -- Summary: add subtask index to FlinkKafkaConsumerBase logging, which can be very useful when debugging problem Key: FLINK-12368 URL: https://issues.apache.org/jira/browse/FLINK

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279557567 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCa

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279555978 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCa

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279554736 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.jav

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279551799 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/CatalogColumnStatis

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279550562 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCa

[GitHub] [flink] piyushnarang commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-04-29 Thread GitBox
piyushnarang commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#discussion_r279550173 ## File path: flink-filesystems/flink-azure-fs-hadoop/src/main/java/org/apache/flink/fs/azurefs/AzureF

[GitHub] [flink] xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279550088 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/GenericInMemoryCa

[GitHub] [flink] piyushnarang commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-04-29 Thread GitBox
piyushnarang commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#discussion_r279549575 ## File path: flink-filesystems/flink-azure-fs-hadoop/pom.xml ## @@ -0,0 +1,80 @@ + + +http:/

[GitHub] [flink] xuefuz edited a comment on issue #8312: [FLINK-12366][table] Clean up Catalog APIs to make them more consiste…

2019-04-29 Thread GitBox
xuefuz edited a comment on issue #8312: [FLINK-12366][table] Clean up Catalog APIs to make them more consiste… URL: https://github.com/apache/flink/pull/8312#issuecomment-487736112 Thanks, @bowenli86! Updated the PR to address above your review feedback. ---

[GitHub] [flink] xuefuz commented on issue #8312: [FLINK-12366][table] Clean up Catalog APIs to make them more consiste…

2019-04-29 Thread GitBox
xuefuz commented on issue #8312: [FLINK-12366][table] Clean up Catalog APIs to make them more consiste… URL: https://github.com/apache/flink/pull/8312#issuecomment-487736112 Thanks, Bowen! Updated the PR to address above your review feedback. ---

[GitHub] [flink] bowenli86 commented on issue #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module

2019-04-29 Thread GitBox
bowenli86 commented on issue #8205: [FLINK-12238] [hive] Support database related operations in GenericHiveMetastoreCatalog and setup flink-connector-hive module URL: https://github.com/apache/flink/pull/8205#issuecomment-487735305 @flinkbot attention @KurtYoung -

[jira] [Comment Edited] (FLINK-9172) Support external catalogs in SQL-Client

2019-04-29 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829690#comment-16829690 ] Bowen Li edited comment on FLINK-9172 at 4/29/19 8:36 PM: -- Hi [~

[GitHub] [flink] bowenli86 commented on issue #7393: [FLINK-9172][table][sql-client] - Support external catalogs in SQL-Client

2019-04-29 Thread GitBox
bowenli86 commented on issue #7393: [FLINK-9172][table][sql-client] - Support external catalogs in SQL-Client URL: https://github.com/apache/flink/pull/7393#issuecomment-487733576 Thanks for your valuable contribution, @EronWright ! I left some comments in the JIRA ticket. Can you please

[jira] [Commented] (FLINK-9172) Support external catalogs in SQL-Client

2019-04-29 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16829690#comment-16829690 ] Bowen Li commented on FLINK-9172: - Hi [~eronwright] , sorry to have you wait so long. Thi

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279500369 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemor

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279523176 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-29 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279506420 ## File path: flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemor

  1   2   3   4   >