bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add
stats related catalog APIs
URL: https://github.com/apache/flink/pull/8314#discussion_r279506420
##########
File path:
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogTest.java
##########
@@ -1104,6 +1104,43 @@ public void testDropFunction_FunctionNotExist_ignored()
throws Exception {
catalog.dropDatabase(db1, false);
}
+ // ------ statistics ------
Review comment:
compared to the amount of unit tests for other APIs, the amount of UT for
stats seems to be too few.
I'm ok with either adding more tests in this PR, or creating an immediate
followup PR dedicated to adding UT for stats related APIs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
