xuefuz commented on a change in pull request #8314: [FLINK-12365][table] Add
stats related catalog APIs
URL: https://github.com/apache/flink/pull/8314#discussion_r279554736
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/catalog/ReadableCatalog.java
##########
@@ -224,4 +224,54 @@ CatalogPartition getPartition(ObjectPath tablePath,
CatalogPartitionSpec partiti
*/
boolean functionExists(ObjectPath functionPath) throws CatalogException;
+ // ------ Statistics ------
+
+ /**
+ * Get the statistics of a table.
+ *
+ * @param tablePath path of the table
+ * @return the statistics of the given table, null if its statistics
don't exist or are unknown.
Review comment:
Make sense. I will leave out the "null" comment in those APIs and let
implementations decide. It doesn't seem making sense to throw "stats not exist"
exception, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
