[GitHub] flink issue #6354: [FLINK-9881] Fixed a typo in table.scala

2018-07-18 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/6354 Thank you @tygrash. For future PRs please use the following schema for commits so that I don't have to touch them again: "[FLINK-] [table] Issue message" "[FLINK-] [sql-client] Issue m

[GitHub] flink pull request #6364: [hotfix] typo for SqlExecutionException msg

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6364 ---

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203617345 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java --- @@ -160,4 +160,41 @@ key("security.ssl.verify-hostna

[jira] [Commented] (FLINK-9499) Allow REST API for running a job to provide job configuration as body of POST request

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548873#comment-16548873 ] ASF GitHub Bot commented on FLINK-9499: --- Github user asfgit closed the pull request

[jira] [Commented] (FLINK-9878) IO worker threads BLOCKED on SSL Session Cache while CMS full gc

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548875#comment-16548875 ] ASF GitHub Bot commented on FLINK-9878: --- Github user NicoK commented on a diff in t

[GitHub] flink pull request #6330: [FLINK-9499][rest] Support JSON request in JarHand...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6330 ---

[GitHub] flink pull request #6352: [FLINK-9815][yarn][tests] Harden tests against slo...

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6352 ---

[jira] [Commented] (FLINK-9815) YARNSessionCapacitySchedulerITCase flaky

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548870#comment-16548870 ] ASF GitHub Bot commented on FLINK-9815: --- Github user asfgit closed the pull request

[jira] [Closed] (FLINK-9815) YARNSessionCapacitySchedulerITCase flaky

2018-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-9815. --- Resolution: Fixed master: 230f81753fb56cea39cdea4c763ad8667baa9dbe 1.6: 9ae2c3bacc4c25b813a89

[jira] [Commented] (FLINK-9872) SavepointITCase#testSavepointForJobWithIteration does not properly cancel jobs

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548863#comment-16548863 ] ASF GitHub Bot commented on FLINK-9872: --- Github user asfgit closed the pull request

[GitHub] flink pull request #6349: [FLINK-9872][tests] Properly cancel test job

2018-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/6349 ---

[jira] [Closed] (FLINK-9872) SavepointITCase#testSavepointForJobWithIteration does not properly cancel jobs

2018-07-18 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-9872. --- Resolution: Fixed master: 4d2163c9ac08d4f596a1edb165dee4addd64ff47 1.6: e87532e01ce180ab8f666

[GitHub] flink issue #6364: [hotfix] typo for SqlExecutionException msg

2018-07-18 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/6364 Thank you, merging... ---

[jira] [Commented] (FLINK-9852) Expose descriptor-based sink creation in table environments

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548848#comment-16548848 ] ASF GitHub Bot commented on FLINK-9852: --- Github user twalthr commented on the issue

[jira] [Commented] (FLINK-7386) Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548847#comment-16548847 ] ASF GitHub Bot commented on FLINK-7386: --- Github user tzulitai commented on the issu

[GitHub] flink issue #6343: [FLINK-9852] [table] Expose descriptor-based sink creatio...

2018-07-18 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/6343 Thank you for your suggestions @pnowojski. I hope I could address most of them in the new commits. I improved the code duplication a bit and `ExternalCatalogTable` is immutable now with a proper buil

[jira] [Commented] (FLINK-7386) Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548846#comment-16548846 ] ASF GitHub Bot commented on FLINK-7386: --- Github user tzulitai commented on the issu

[GitHub] flink issue #6043: [FLINK-7386] evolve RequestIndexer API to make it working...

2018-07-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6043 @cjolif Ideally we have ES 6.x connector merged by the beginning of next week. Let me know if this is possible for you. I'll proceed to merge this PR first. ---

[GitHub] flink issue #6043: [FLINK-7386] evolve RequestIndexer API to make it working...

2018-07-18 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/6043 @cjolif do you think you would be able to quickly open a PR for the REST 6.x connector that includes the new changes you mentioned, based on this one? ---

[jira] [Commented] (FLINK-9875) Add concurrent creation of execution job vertex

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548843#comment-16548843 ] ASF GitHub Bot commented on FLINK-9875: --- Github user yanghua commented on the issue

[GitHub] flink issue #6353: [FLINK-9875] Add concurrent creation of execution job ver...

2018-07-18 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6353 @tison1 there are too many commits, you can use `git rebase -i [commit-id]` to squash them, then use `git push -f xxx xxx` to force update the PR. ---

[jira] [Commented] (FLINK-9850) Add a string to the print method to identify output for DataStream

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548837#comment-16548837 ] ASF GitHub Bot commented on FLINK-9850: --- Github user yanghua commented on the issue

[GitHub] flink issue #6367: [FLINK-9850] Add a string to the print method to identify...

2018-07-18 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6367 @hequn8128 thanks, I have added some test case~ ---

[jira] [Commented] (FLINK-7251) Merge the flink-java8 project into flink-core

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548808#comment-16548808 ] ASF GitHub Bot commented on FLINK-7251: --- Github user twalthr commented on a diff in

[GitHub] flink pull request #6120: [FLINK-7251] [types] Remove the flink-java8 module...

2018-07-18 Thread twalthr
Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/6120#discussion_r203605524 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java --- @@ -545,15 +543,15 @@ public IntervalJoined(

[jira] [Commented] (FLINK-9875) Add concurrent creation of execution job vertex

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548797#comment-16548797 ] ASF GitHub Bot commented on FLINK-9875: --- Github user tison1 commented on the issue:

[GitHub] flink issue #6353: [FLINK-9875] Add concurrent creation of execution job ver...

2018-07-18 Thread tison1
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6353 Fix unstable case, the problem is code below, that may assign `constraints` to a long array and then to a short array, which cause out of index exception. to solve it we could init `constraints` in ob

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2018-07-18 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548759#comment-16548759 ] zhangminglei commented on FLINK-4534: - Hi, [~gjy] Can we use a lightweight synchroniz

[jira] [Commented] (FLINK-9675) Avoid FileInputStream/FileOutputStream

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548748#comment-16548748 ] ASF GitHub Bot commented on FLINK-9675: --- Github user zhangminglei commented on the

[GitHub] flink issue #6335: [FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream

2018-07-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6335 Hi, @hequn8128 I will create another jira for ```new InputStreamReader``` refactor issue. What do you think ? ---

[jira] [Commented] (FLINK-9236) Use Apache Parent POM 19

2018-07-18 Thread Stephen Jason (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548735#comment-16548735 ] Stephen Jason commented on FLINK-9236: -- Yes, but I can't find [~jiayichao] in the na

[jira] [Assigned] (FLINK-9236) Use Apache Parent POM 19

2018-07-18 Thread Stephen Jason (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Jason reassigned FLINK-9236: Assignee: Stephen Jason > Use Apache Parent POM 19 > > >

[GitHub] flink pull request #6367: [FLINK-9850] Add a string to the print method to i...

2018-07-18 Thread hequn8128
Github user hequn8128 commented on a diff in the pull request: https://github.com/apache/flink/pull/6367#discussion_r203588835 --- Diff: flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/DataStream.scala --- @@ -959,6 +959,29 @@ class DataStream[T](stream:

[jira] [Assigned] (FLINK-9236) Use Apache Parent POM 19

2018-07-18 Thread Stephen Jason (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Jason reassigned FLINK-9236: Assignee: (was: Stephen Jason) > Use Apache Parent POM 19 > >

[jira] [Commented] (FLINK-9850) Add a string to the print method to identify output for DataStream

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548718#comment-16548718 ] ASF GitHub Bot commented on FLINK-9850: --- Github user hequn8128 commented on a diff

[jira] [Commented] (FLINK-9236) Use Apache Parent POM 19

2018-07-18 Thread jiayichao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548715#comment-16548715 ] jiayichao commented on FLINK-9236: -- hi [~Stephen Jason]Stephen Jason,  Could you give th

[jira] [Updated] (FLINK-9675) Avoid FileInputStream/FileOutputStream

2018-07-18 Thread zhangminglei (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangminglei updated FLINK-9675: Description: They rely on finalizers (before Java 11), which create unnecessary GC load. The alter

[jira] [Commented] (FLINK-9675) Avoid FileInputStream/FileOutputStream

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548677#comment-16548677 ] ASF GitHub Bot commented on FLINK-9675: --- Github user zhangminglei commented on the

[GitHub] flink issue #6335: [FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream

2018-07-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6335 Thank you very much! @hequn8128 ! I will take a look. ---

[jira] [Commented] (FLINK-9735) Potential resource leak in RocksDBStateBackend#getDbOptions

2018-07-18 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548670#comment-16548670 ] vinoyang commented on FLINK-9735: - Will process this issue soon. > Potential resource le

[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548654#comment-16548654 ] ASF GitHub Bot commented on FLINK-9849: --- Github user zhangminglei commented on the

[GitHub] flink issue #6365: [FLINK-9849] [hbase] Hbase upgrade to 2.0.1

2018-07-18 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/6365 Thanks @yanghua you are right! I just want waiting the travis ending. then give the old and new version's dependency tree. ---

[jira] [Commented] (FLINK-9061) add entropy to s3 path for better scalability

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548629#comment-16548629 ] ASF GitHub Bot commented on FLINK-9061: --- Github user mdaxini commented on the issue

[GitHub] flink issue #6302: [FLINK-9061][checkpointing] add entropy to s3 path for be...

2018-07-18 Thread mdaxini
Github user mdaxini commented on the issue: https://github.com/apache/flink/pull/6302 @indrc In addition to removing the additional dependency, I think there should be a test for validating the randomness of the chose algorithm, and to make sure there are no conflicts. For a

[jira] [Updated] (FLINK-9236) Use Apache Parent POM 19

2018-07-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-9236: -- Description: Flink is still using Apache Parent POM 18. Apache Parent POM 19 is out. This will also fix Javad

[jira] [Comment Edited] (FLINK-9735) Potential resource leak in RocksDBStateBackend#getDbOptions

2018-07-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16540754#comment-16540754 ] Ted Yu edited comment on FLINK-9735 at 7/19/18 12:37 AM: - Short t

[GitHub] flink issue #6259: [FLINK-9679] Implement AvroSerializationSchema

2018-07-18 Thread medcv
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6259 @dawidwys in last commit, I did extend `SchemaCoder` to have `getSchemaId` as you suggested. ---

[jira] [Commented] (FLINK-9679) Implement AvroSerializationSchema

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548595#comment-16548595 ] ASF GitHub Bot commented on FLINK-9679: --- Github user medcv commented on the issue:

[GitHub] flink issue #6364: [hotfix] typo for SqlExecutionException msg

2018-07-18 Thread tison1
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6364 Thanks! LGTM cc @zentol ---

[GitHub] flink issue #6360: [FLINK-9884] [runtime] fix slot request may not be remove...

2018-07-18 Thread tison1
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6360 @shuai-xu It makes sense. The message that TM has successfully allocated slot might lost in transport. When slot manager receives a slot status report which says one slot has allocation id

[jira] [Commented] (FLINK-9884) Slot request may not be removed when it has already be assigned in slot manager

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548559#comment-16548559 ] ASF GitHub Bot commented on FLINK-9884: --- Github user tison1 commented on the issue:

[jira] [Commented] (FLINK-9679) Implement AvroSerializationSchema

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548479#comment-16548479 ] ASF GitHub Bot commented on FLINK-9679: --- Github user medcv commented on the issue:

[GitHub] flink issue #6259: [FLINK-9679] Implement AvroSerializationSchema

2018-07-18 Thread medcv
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6259 @dawidwys For second issue I am looking at other Schema registries and trying to extend `SchemaCoder` ---

[jira] [Commented] (FLINK-9679) Implement AvroSerializationSchema

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548425#comment-16548425 ] ASF GitHub Bot commented on FLINK-9679: --- Github user medcv commented on the issue:

[GitHub] flink issue #6259: [FLINK-9679] Implement AvroSerializationSchema

2018-07-18 Thread medcv
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6259 @dawidwys Thanks! As far as I dog on Confluent code, their api needs `subject` to retrieve the Schema Id and version and it should be provided by consumer. https://github.com/conflu

[jira] [Assigned] (FLINK-9891) Flink cluster is not shutdown in YARN mode when Flink client is stopped

2018-07-18 Thread Shuyi Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuyi Chen reassigned FLINK-9891: - Assignee: Shuyi Chen > Flink cluster is not shutdown in YARN mode when Flink client is stopped >

[jira] [Commented] (FLINK-9679) Implement AvroSerializationSchema

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548207#comment-16548207 ] ASF GitHub Bot commented on FLINK-9679: --- Github user dawidwys commented on the issu

[GitHub] flink issue #6259: [FLINK-9679] Implement AvroSerializationSchema

2018-07-18 Thread dawidwys
Github user dawidwys commented on the issue: https://github.com/apache/flink/pull/6259 @medcv the new commit does not address any of my previous comments or I don't understand something. ---

[jira] [Commented] (FLINK-9679) Implement AvroSerializationSchema

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548150#comment-16548150 ] ASF GitHub Bot commented on FLINK-9679: --- Github user medcv commented on the issue:

[GitHub] flink issue #6259: [FLINK-9679] Implement AvroSerializationSchema

2018-07-18 Thread medcv
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6259 @dawidwys I update the PR, please review the usage would be like this ` ConfluentRegistryAvroSerializationSchema.forSpecific(User.class, subject, schemaRegistryUrl)` as Confluent needs

[jira] [Created] (FLINK-9891) Flink cluster is not shutdown in YARN mode when Flink client is stopped

2018-07-18 Thread Sergey Krasovskiy (JIRA)
Sergey Krasovskiy created FLINK-9891: Summary: Flink cluster is not shutdown in YARN mode when Flink client is stopped Key: FLINK-9891 URL: https://issues.apache.org/jira/browse/FLINK-9891 Project

[jira] [Updated] (FLINK-9891) Flink cluster is not shutdown in YARN mode when Flink client is stopped

2018-07-18 Thread Sergey Krasovskiy (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Krasovskiy updated FLINK-9891: - Description: We are not using session mode and detached mode. The command to run Flink jo

[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548029#comment-16548029 ] ASF GitHub Bot commented on FLINK-9849: --- Github user yanghua commented on a diff in

[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548031#comment-16548031 ] ASF GitHub Bot commented on FLINK-9849: --- Github user yanghua commented on a diff in

[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548030#comment-16548030 ] ASF GitHub Bot commented on FLINK-9849: --- Github user yanghua commented on a diff in

[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548027#comment-16548027 ] ASF GitHub Bot commented on FLINK-9849: --- Github user yanghua commented on a diff in

[jira] [Commented] (FLINK-9849) Upgrade hbase version to 2.0.1 for hbase connector

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548028#comment-16548028 ] ASF GitHub Bot commented on FLINK-9849: --- Github user yanghua commented on a diff in

[GitHub] flink pull request #6365: [FLINK-9849] [hbase] Hbase upgrade to 2.0.1

2018-07-18 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6365#discussion_r203439890 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java --- @@ -87,22 +90,22 @@ public void

[GitHub] flink pull request #6365: [FLINK-9849] [hbase] Hbase upgrade to 2.0.1

2018-07-18 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6365#discussion_r203440989 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java --- @@ -87,22 +90,22 @@ public void

[GitHub] flink pull request #6365: [FLINK-9849] [hbase] Hbase upgrade to 2.0.1

2018-07-18 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6365#discussion_r203438579 --- Diff: flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java --- @@ -81,7 +85,9 @@ private HTable createTable()

[GitHub] flink pull request #6365: [FLINK-9849] [hbase] Hbase upgrade to 2.0.1

2018-07-18 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6365#discussion_r203439523 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java --- @@ -87,22 +90,22 @@ public void

[GitHub] flink pull request #6365: [FLINK-9849] [hbase] Hbase upgrade to 2.0.1

2018-07-18 Thread yanghua
Github user yanghua commented on a diff in the pull request: https://github.com/apache/flink/pull/6365#discussion_r203439859 --- Diff: flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/example/HBaseWriteStreamExample.java --- @@ -87,22 +90,22 @@ public void

[jira] [Commented] (FLINK-9675) Avoid FileInputStream/FileOutputStream

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548019#comment-16548019 ] ASF GitHub Bot commented on FLINK-9675: --- Github user hequn8128 commented on the iss

[GitHub] flink issue #6335: [FLINK-9675] [fs] Avoid FileInputStream/FileOutputStream

2018-07-18 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/6335 Hi @zhangminglei , Good catch! Maybe the Reader may also need to be adapted, making `new InputStreamReader` to `Channels.newReader`. I find a benchmark about File InputStream and Reader [here]

[jira] [Commented] (FLINK-9878) IO worker threads BLOCKED on SSL Session Cache while CMS full gc

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548014#comment-16548014 ] ASF GitHub Bot commented on FLINK-9878: --- Github user zentol commented on a diff in

[GitHub] flink pull request #6355: [FLINK-9878][network][ssl] add more low-level ssl ...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6355#discussion_r203437995 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/SecurityOptions.java --- @@ -160,4 +160,41 @@ key("security.ssl.verify-hostn

[jira] [Commented] (FLINK-9860) Netty resource leak on receiver side

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548008#comment-16548008 ] ASF GitHub Bot commented on FLINK-9860: --- Github user zentol commented on the issue:

[GitHub] flink issue #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHandler

2018-07-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6363 +1 ---

[jira] [Commented] (FLINK-9850) Add a string to the print method to identify output for DataStream

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548004#comment-16548004 ] ASF GitHub Bot commented on FLINK-9850: --- Github user yanghua commented on the issue

[GitHub] flink issue #6367: [FLINK-9850] Add a string to the print method to identify...

2018-07-18 Thread yanghua
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6367 @tillrohrmann and @zentol I see the Python DataStream API methods do not match DataStream Java API methods (missed some API methods), Shall we add those missed API into `PythonDataStream`? If yes, I'

[jira] [Commented] (FLINK-9860) Netty resource leak on receiver side

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547991#comment-16547991 ] ASF GitHub Bot commented on FLINK-9860: --- Github user NicoK commented on a diff in t

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203432013 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java --- @@ -0,0 +1,84 @@ +/* + * Licensed

[jira] [Updated] (FLINK-9889) create .bat script to start Flink task manager

2018-07-18 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] vinoyang updated FLINK-9889: Summary: create .bat script to start Flink task manager (was: .bat script to start Flink task manager) >

[jira] [Commented] (FLINK-9860) Netty resource leak on receiver side

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547969#comment-16547969 ] ASF GitHub Bot commented on FLINK-9860: --- Github user zentol commented on a diff in

[jira] [Commented] (FLINK-9860) Netty resource leak on receiver side

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547968#comment-16547968 ] ASF GitHub Bot commented on FLINK-9860: --- Github user zentol commented on a diff in

[jira] [Commented] (FLINK-9860) Netty resource leak on receiver side

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547967#comment-16547967 ] ASF GitHub Bot commented on FLINK-9860: --- Github user zentol commented on a diff in

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203414529 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/FileUploadHandlerTest.java --- @@ -220,4 +224,5 @@ public void testUploadCleanupOnFailure

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203422176 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java --- @@ -0,0 +1,84 @@ +/* + * Licensed

[GitHub] flink pull request #6363: [FLINK-9860][REST] fix buffer leak in FileUploadHa...

2018-07-18 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/6363#discussion_r203414700 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyLeakDetectionResource.java --- @@ -0,0 +1,84 @@ +/* + * Licensed

[jira] [Commented] (FLINK-9850) Add a string to the print method to identify output for DataStream

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547965#comment-16547965 ] ASF GitHub Bot commented on FLINK-9850: --- GitHub user yanghua opened a pull request:

[jira] [Updated] (FLINK-9850) Add a string to the print method to identify output for DataStream

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9850: -- Labels: pull-request-available (was: ) > Add a string to the print method to identify output f

[GitHub] flink pull request #6367: [FLINK-9850] Add a string to the print method to i...

2018-07-18 Thread yanghua
GitHub user yanghua opened a pull request: https://github.com/apache/flink/pull/6367 [FLINK-9850] Add a string to the print method to identify output for DataStream ## What is the purpose of the change *This pull request adds a string to the print method to identify output

[jira] [Commented] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2018-07-18 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547934#comment-16547934 ] Gary Yao commented on FLINK-4534: - [~yuzhih...@gmail.com] Synchronization bears a perform

[jira] [Commented] (FLINK-9815) YARNSessionCapacitySchedulerITCase flaky

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547936#comment-16547936 ] ASF GitHub Bot commented on FLINK-9815: --- Github user zentol commented on the issue:

[GitHub] flink issue #6352: [FLINK-9815][yarn][tests] Harden tests against slow job s...

2018-07-18 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/6352 yay travis is green. ---

[jira] [Commented] (FLINK-9869) Send PartitionInfo in batch to Improve perfornance

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547929#comment-16547929 ] ASF GitHub Bot commented on FLINK-9869: --- Github user tison1 commented on the issue:

[GitHub] flink issue #6345: [FLINK-9869] Send PartitionInfo in batch to Improve perfo...

2018-07-18 Thread tison1
Github user tison1 commented on the issue: https://github.com/apache/flink/pull/6345 OK. This PR is about performance improvement. I will try to give out a benchmark, but since it is inspired by our own batch table tasks, it might take time to give one. Though since this PR concurrent

[jira] [Commented] (FLINK-9886) Build SQL jars with every build

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547920#comment-16547920 ] ASF GitHub Bot commented on FLINK-9886: --- Github user twalthr commented on the issue

[jira] [Commented] (FLINK-9886) Build SQL jars with every build

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547917#comment-16547917 ] ASF GitHub Bot commented on FLINK-9886: --- GitHub user twalthr opened a pull request:

[jira] [Updated] (FLINK-9886) Build SQL jars with every build

2018-07-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9886: -- Labels: pull-request-available (was: ) > Build SQL jars with every build > ---

  1   2   3   4   >