[ 
https://issues.apache.org/jira/browse/FLINK-9675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548019#comment-16548019
 ] 

ASF GitHub Bot commented on FLINK-9675:
---------------------------------------

Github user hequn8128 commented on the issue:

    https://github.com/apache/flink/pull/6335
  
    Hi @zhangminglei ,
    Good catch! Maybe the Reader may also need to be adapted, making `new 
InputStreamReader` to `Channels.newReader`. I find a benchmark about File 
InputStream and Reader 
[here](https://arnaudroger.github.io/blog/2017/03/20/faster-reader-inpustream-in-java.html).
 Hope it helps.


> Avoid FileInputStream/FileOutputStream
> --------------------------------------
>
>                 Key: FLINK-9675
>                 URL: https://issues.apache.org/jira/browse/FLINK-9675
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: zhangminglei
>            Priority: Minor
>              Labels: filesystem, pull-request-available
>
> They rely on finalizers (before Java 11), which create unnecessary GC load.
> The alternatives, Files.newInputStream, are as easy to use and don't have 
> this issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to