Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6365#discussion_r203438579
  
    --- Diff: 
flink-connectors/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
 ---
    @@ -81,7 +85,9 @@ private HTable createTable() {
                org.apache.hadoop.conf.Configuration hConf = 
HBaseConfiguration.create();
     
                try {
    -                   return new HTable(hConf, getTableName());
    +                   Connection connection = 
ConnectionFactory.createConnection(hConf);
    +                   Table table = 
connection.getTable(TableName.valueOf(getTableName()));
    +                   return (HTable) table;
    --- End diff --
    
    I think we should release the connection when happens exception


---

Reply via email to