[jira] [Created] (FLINK-8270) TaskManagers do not use correct local path for shipped Keytab files in Yarn deployment modes

2017-12-15 Thread Tzu-Li (Gordon) Tai (JIRA)
Tzu-Li (Gordon) Tai created FLINK-8270: -- Summary: TaskManagers do not use correct local path for shipped Keytab files in Yarn deployment modes Key: FLINK-8270 URL: https://issues.apache.org/jira/browse/FLINK-

[jira] [Commented] (FLINK-8267) Kinesis Producer example setting Region key

2017-12-15 Thread Dyana Rose (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293231#comment-16293231 ] Dyana Rose commented on FLINK-8267: --- a push towards the native keys in the docs would si

[jira] [Commented] (FLINK-7736) Fix some of the alerts raised by lgtm.com

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293108#comment-16293108 ] ASF GitHub Bot commented on FLINK-7736: --- Github user 1m2c3t4 commented on the issue:

[GitHub] flink issue #4784: FLINK-7736: fix some lgtm.com alerts

2017-12-15 Thread 1m2c3t4
Github user 1m2c3t4 commented on the issue: https://github.com/apache/flink/pull/4784 Rebased again and fixed another obvious bug ---

[jira] [Assigned] (FLINK-8267) Kinesis Producer example setting Region key

2017-12-15 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li reassigned FLINK-8267: --- Assignee: Bowen Li > Kinesis Producer example setting Region key > --

[jira] [Commented] (FLINK-8249) Kinesis Producer didnt configure region

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293087#comment-16293087 ] ASF GitHub Bot commented on FLINK-8249: --- Github user bowenli86 commented on the issu

[jira] [Comment Edited] (FLINK-8267) Kinesis Producer example setting Region key

2017-12-15 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293017#comment-16293017 ] Bowen Li edited comment on FLINK-8267 at 12/15/17 7:39 PM: --- This

[GitHub] flink issue #5160: [FLINK-8249] [KinesisConnector] [hotfix] aws region is ne...

2017-12-15 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5160 @eskabetxe Thanks for fixing this A further effort is https://issues.apache.org/jira/browse/FLINK-8267 ---

[GitHub] flink issue #5162: [FLINK-8250][runtime] Remove unused RecordSerializer#inst...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5162 Seems reasonable... ---

[jira] [Commented] (FLINK-8249) Kinesis Producer didnt configure region

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293073#comment-16293073 ] ASF GitHub Bot commented on FLINK-8249: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5164: [hotfix][javadoc] fix typo in StreamExecutionEnvironment ...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5164 Good catch, +1 to merge ---

[jira] [Commented] (FLINK-8250) Remove RecordSerializer#instantiateMetrics

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293074#comment-16293074 ] ASF GitHub Bot commented on FLINK-8250: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5160: [FLINK-8249] [KinesisConnector] [hotfix] aws region is ne...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5160 Minor comment: The commit should not have the [hotfix] tag ---

[jira] [Commented] (FLINK-8249) Kinesis Producer didnt configure region

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293072#comment-16293072 ] ASF GitHub Bot commented on FLINK-8249: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #5160: [FLINK-8249] [KinesisConnector] [hotfix] aws regio...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5160#discussion_r157281403 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java --- @@ -191,6

[jira] [Commented] (FLINK-8079) Skip remaining E2E tests if one failed

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293069#comment-16293069 ] ASF GitHub Bot commented on FLINK-8079: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5156: [FLINK-8079][tests] Stop end-to-end test execution after ...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5156 I like the change+1 Minor: Is there a way to write `if code != 0 return` in bash? Might be easier to read... ---

[jira] [Commented] (FLINK-8227) Optimize the performance of SharedBufferSerializer

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293066#comment-16293066 ] ASF GitHub Bot commented on FLINK-8227: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5142: [FLINK-8227] Optimize the performance of SharedBufferSeri...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5142 @kl0u or @dawidwys I think this could use your opinion. General questions: - Is there any reason to use a boxed integer over a primitive one? Primitives should be the default choice

[jira] [Commented] (FLINK-8217) Properly annotate APIs of flink-connector-kinesis

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293062#comment-16293062 ] ASF GitHub Bot commented on FLINK-8217: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5138: [FLINK-8217] [Kinesis connector] Properly annotate APIs o...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5138 I agree that we should be careful with `@Public` and if in doubt resort to `@PublicEvolving` (and use `@Internal` sort of as the default). Given that @tzulitai did a good amount of the Ki

[jira] [Commented] (FLINK-8223) Update Hadoop versions

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293057#comment-16293057 ] ASF GitHub Bot commented on FLINK-8223: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5137: [FLINK-8223] [build] Update Hadoop versions

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5137 Looks good. Related: Hadoop 3.0 just got released, wondering when we need to add support for that... ---

[jira] [Commented] (FLINK-8222) Update Scala version

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293056#comment-16293056 ] ASF GitHub Bot commented on FLINK-8222: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5136: [FLINK-8222] [build] Update Scala version

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5136 Should be good. I have seen now and then warnings by the Scala compiler about Scala dependencies requiring different minor versions. It's only a warning, but I am wondering if there coul

[GitHub] flink issue #5135: [hotfix] [doc] Fix typo in TaskManager and EnvironmentInf...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5135 Thanks @greghogan for the review, looks good to merge... ---

[GitHub] flink issue #5133: [hotfix] Fix typo in AkkaUtils method

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5133 I think this is good, except for the removal of `StandaloneHaServices#RESOURCE_MANAGER_RPC_ENDPOINT_NAME` where I am unsure if some of the pending FLIP-6 work has plans for that. I would suggest

[jira] [Commented] (FLINK-5506) Java 8 - CommunityDetection.java:158 - java.lang.NullPointerException

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293052#comment-16293052 ] ASF GitHub Bot commented on FLINK-5506: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5126: [FLINK-5506] [gelly] Fix CommunityDetection NullPointerEx...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5126 Just a comment on the use of `TypeHint`: In the `DataSet` and `DataStream` API, we typically pass `TypeInformation` when offering an explicit way to describe the type. The reason is that

[jira] [Commented] (FLINK-8199) Annotation for Elasticsearch connector

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293046#comment-16293046 ] ASF GitHub Bot commented on FLINK-8199: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5124: [FLINK-8199] [elasticsearch connector] Properly annotate ...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5124 @tzulitai you are one of the main contributors here, I think your input would be valuable. A result could also be that this is not yet ready to be divided it into "stable public" "evolvi

[jira] [Commented] (FLINK-8199) Annotation for Elasticsearch connector

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293045#comment-16293045 ] ASF GitHub Bot commented on FLINK-8199: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5124: [FLINK-8199] [elasticsearch connector] Properly annotate ...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5124 I think the intent here is good, but every time some class is annotated with `@Public`, that is a commitment to keep the API stable. Before doing that, the community members that mainly a

[GitHub] flink issue #5113: [FLINK-8156][build] Bump commons-beanutils version to 1.9...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5113 Good change, thank you! Given that beanutils is not used directly by Flink, but only by Hadoop (which we try to depend on less and less), could you move the dependency management entry f

[jira] [Commented] (FLINK-8156) Bump commons-beanutils version to 1.9.3

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293040#comment-16293040 ] ASF GitHub Bot commented on FLINK-8156: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5112: [FLINK-8175] [DataStream API java/scala] remove flink-str...

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5112 I would actually be in favor of dismantling the `flink-streaming-contrib` project. We could have a dedicated package `experimental` in `flink-streaming-java` for such code. The package s

[jira] [Commented] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293032#comment-16293032 ] ASF GitHub Bot commented on FLINK-8175: --- Github user StephanEwen commented on the is

[jira] [Commented] (FLINK-7574) Remove unused dependencies from flink-clients

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293025#comment-16293025 ] ASF GitHub Bot commented on FLINK-7574: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5076 Is this merged already? I think the idea is nice, but I would say let's merge this if we have commitment to follow up on this, meaning fixing the other modules. We already have a

[jira] [Commented] (FLINK-8267) Kinesis Producer example setting Region key

2017-12-15 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293017#comment-16293017 ] Bowen Li commented on FLINK-8267: - This is a great point. According to the previous discus

[jira] [Commented] (FLINK-7574) Remove unused dependencies from flink-clients

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293018#comment-16293018 ] ASF GitHub Bot commented on FLINK-7574: --- Github user StephanEwen commented on a diff

[GitHub] flink pull request #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5076#discussion_r157271859 --- Diff: pom.xml --- @@ -891,6 +905,41 @@ under the License. + + org

[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293010#comment-16293010 ] ASF GitHub Bot commented on FLINK-7984: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5072: [FLINK-7984][build] Bump snappy-java to 1.1.4

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5072 Sorry, actually, taking a step back: Can you check in which dependencies snappy is included in addition? Especially big packaged dependencies like `flink-s3-fs-presto` and `flink-s3-fs-hadoop

[jira] [Created] (FLINK-8269) Set netRuntime in JobExecutionResult

2017-12-15 Thread Gary Yao (JIRA)
Gary Yao created FLINK-8269: --- Summary: Set netRuntime in JobExecutionResult Key: FLINK-8269 URL: https://issues.apache.org/jira/browse/FLINK-8269 Project: Flink Issue Type: Bug Components

[jira] [Assigned] (FLINK-8233) Retrieve ExecutionResult by REST polling

2017-12-15 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8233: --- Assignee: Gary Yao > Retrieve ExecutionResult by REST polling > -

[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292632#comment-16292632 ] ASF GitHub Bot commented on FLINK-7984: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5072: [FLINK-7984][build] Bump snappy-java to 1.1.4

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5072 Merging this... ---

[jira] [Commented] (FLINK-7984) Bump snappy-java to 1.1.4

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292628#comment-16292628 ] ASF GitHub Bot commented on FLINK-7984: --- Github user StephanEwen commented on the is

[GitHub] flink issue #5072: [FLINK-7984][build] Bump snappy-java to 1.1.4

2017-12-15 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5072 Bumping the version should be fine. We only need to make sure that wherever this is pulled, we promote it to a direct dependency such that dependency convergence works. ---

[jira] [Created] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2017-12-15 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-8268: --- Summary: Test instability for 'TwoPhaseCommitSinkFunctionTest' Key: FLINK-8268 URL: https://issues.apache.org/jira/browse/FLINK-8268 Project: Flink Issue Type:

[jira] [Commented] (FLINK-8264) Add Scala to the parent-first loading patterns

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292615#comment-16292615 ] ASF GitHub Bot commented on FLINK-8264: --- Github user StephanEwen closed the pull req

[GitHub] flink pull request #5167: [FLINK-8264] [core] Add 'scala.' to the 'parent-fi...

2017-12-15 Thread StephanEwen
Github user StephanEwen closed the pull request at: https://github.com/apache/flink/pull/5167 ---

[jira] [Closed] (FLINK-8264) Add Scala to the parent-first loading patterns

2017-12-15 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-8264. --- > Add Scala to the parent-first loading patterns > -- > >

[jira] [Resolved] (FLINK-8264) Add Scala to the parent-first loading patterns

2017-12-15 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-8264. - Resolution: Fixed Fixed in - 1.4.1 via 57de25d8950272fc6c6ac9ed400c79b0680f40e4 - 1.5.0 via 28

[jira] [Commented] (FLINK-8264) Add Scala to the parent-first loading patterns

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292596#comment-16292596 ] ASF GitHub Bot commented on FLINK-8264: --- Github user asfgit closed the pull request

[GitHub] flink pull request #5166: [FLINK-8264] [core] Add 'scala.' to the 'parent-fi...

2017-12-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5166 ---

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292515#comment-16292515 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292508#comment-16292508 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292509#comment-16292509 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292517#comment-16292517 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292516#comment-16292516 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292511#comment-16292511 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292512#comment-16292512 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292518#comment-16292518 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292513#comment-16292513 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292519#comment-16292519 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292510#comment-16292510 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[jira] [Commented] (FLINK-8178) Introduce not threadsafe write only BufferBuilder

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292514#comment-16292514 ] ASF GitHub Bot commented on FLINK-8178: --- Github user pnowojski commented on a diff i

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156931533 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordOrEventCollectingResultPartitionWriter.java --- @@ -0,0 +1,104

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r157154019 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferBuilder.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the A

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156929782 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordCollectingResultPartitionWriter.java --- @@ -0,0 +1,88 @@ +

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r157178704 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java --- @@ -118,7 +122,7 @@ public Buffer answer(In

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156928873 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPoolDestroyTest.java --- @@ -104,11 +104,10 @@ public void tes

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156923552 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/util/TestBufferFactory.java --- @@ -40,37 +39,31 @@ private final

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156931262 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordOrEventCollectingResultPartitionWriter.java --- @@ -0,0 +1,104

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156934340 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpanningRecordSerializer.java --- @@ -169,33 +151,29 @@ public

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r157172734 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java --- @@ -179,7 +179,8 @@ public void setBufferPoolOwn

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r157174669 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java --- @@ -188,10 +189,16 @@ public Buffer requestBuffe

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r157154679 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/BufferBuilder.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the A

[GitHub] flink pull request #5105: [FLINK-8178][network] Introduce not threadsafe wri...

2017-12-15 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/5105#discussion_r156922694 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/SpilledSubpartitionViewTest.java --- @@ -48,8 +47,7 @@ p

[jira] [Closed] (FLINK-8248) RocksDB state backend Checkpointing is not working with KeyedCEP in 1.4

2017-12-15 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-8248. --- Resolution: Not A Problem > RocksDB state backend Checkpointing is not working with KeyedCEP i

[jira] [Reopened] (FLINK-8248) RocksDB state backend Checkpointing is not working with KeyedCEP in 1.4

2017-12-15 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reopened FLINK-8248: - Reopen to change resolution > RocksDB state backend Checkpointing is not working with KeyedC

[jira] [Updated] (FLINK-8267) Kinesis Producer example setting Region key

2017-12-15 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-8267: Component/s: Kinesis Connector > Kinesis Producer example setting Region key > -

[jira] [Commented] (FLINK-8264) Add Scala to the parent-first loading patterns

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292376#comment-16292376 ] ASF GitHub Bot commented on FLINK-8264: --- Github user aljoscha commented on the issue

[GitHub] flink issue #5166: [FLINK-8264] [core] Add 'scala.' to the 'parent-first' cl...

2017-12-15 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5166 I think this looks good! ---

[jira] [Commented] (FLINK-8266) Add network memory to ResourceProfile

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292337#comment-16292337 ] ASF GitHub Bot commented on FLINK-8266: --- GitHub user shuai-xu opened a pull request:

[GitHub] flink pull request #5170: [FLINK-8266] [runtime] add network memory to Resou...

2017-12-15 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5170 [FLINK-8266] [runtime] add network memory to ResourceProfile for the input and output memory of a task ## What is the purpose of the change This pull request adds a network memory fie

[jira] [Updated] (FLINK-8267) Kinesis Producer example setting Region key

2017-12-15 Thread Dyana Rose (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dyana Rose updated FLINK-8267: -- Description: https://ci.apache.org/projects/flink/flink-docs-release-1.4/dev/connectors/kinesis.html#kin

[jira] [Created] (FLINK-8267) Kinesis Producer example setting Region key

2017-12-15 Thread Dyana Rose (JIRA)
Dyana Rose created FLINK-8267: - Summary: Kinesis Producer example setting Region key Key: FLINK-8267 URL: https://issues.apache.org/jira/browse/FLINK-8267 Project: Flink Issue Type: Bug

[jira] [Updated] (FLINK-8266) Add network memory to ResourceProfile

2017-12-15 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu updated FLINK-8266: Labels: flip-6 (was: ) > Add network memory to ResourceProfile > - > >

[jira] [Created] (FLINK-8266) Add network memory to ResourceProfile

2017-12-15 Thread shuai.xu (JIRA)
shuai.xu created FLINK-8266: --- Summary: Add network memory to ResourceProfile Key: FLINK-8266 URL: https://issues.apache.org/jira/browse/FLINK-8266 Project: Flink Issue Type: Improvement C

[jira] [Commented] (FLINK-4822) Ensure that the Kafka 0.8 connector is compatible with kafka-consumer-groups.sh

2017-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292235#comment-16292235 ] ASF GitHub Bot commented on FLINK-4822: --- Github user taizilongxu commented on the is

[GitHub] flink issue #5050: [FLINK-4822] Ensure that the Kafka 0.8 connector is compa...

2017-12-15 Thread taizilongxu
Github user taizilongxu commented on the issue: https://github.com/apache/flink/pull/5050 Hi, is there any thing to edit or change? ---