[
https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293018#comment-16293018
]
ASF GitHub Bot commented on FLINK-7574:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5076#discussion_r157271859
--- Diff: pom.xml ---
@@ -891,6 +905,41 @@ under the License.
<build>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-dependency-plugin</artifactId>
+ <version>3.0.2</version>
+ <executions>
+ <execution>
+ <id>analyze</id>
+ <goals>
+
<goal>analyze-only</goal>
+ </goals>
+ <configuration>
+ <!-- Ignore
runtime-only dependencies in analysis -->
+
<ignoreNonCompile>true</ignoreNonCompile>
+
<outputXML>true</outputXML>
+
<failOnWarning>true</failOnWarning>
+
<ignoredUnusedDeclaredDependencies>
--- End diff --
Can we keep the root dependencies? I find the current way actually
convenient and avoiding pom clutter.
As Chesnay mentioned, the compile scope dependencies should be okay (used
everywhere).
Could the test dependencies be separately skipped?
> Remove unused dependencies from flink-clients
> ---------------------------------------------
>
> Key: FLINK-7574
> URL: https://issues.apache.org/jira/browse/FLINK-7574
> Project: Flink
> Issue Type: Sub-task
> Components: Build System
> Affects Versions: 1.3.2
> Environment: Apache Maven 3.3.9, Java version: 1.8.0_144
> Reporter: Hai Zhou UTC+8
> Assignee: Hai Zhou UTC+8
>
> [INFO] --- maven-dependency-plugin:2.10:analyze (default-cli) @
> flink-clients_2.11 ---
> [WARNING] Used undeclared dependencies found:
> [WARNING] org.scala-lang:scala-library:jar:2.11.11:compile
> [WARNING] com.data-artisans:flakka-actor_2.11:jar:2.3-custom:compile
> [WARNING] Unused declared dependencies found:
> [WARNING] org.hamcrest:hamcrest-all:jar:1.3:test
> [WARNING] org.apache.flink:force-shading:jar:1.4-SNAPSHOT:compile
> [WARNING] org.powermock:powermock-module-junit4:jar:1.6.5:test
> [WARNING] com.google.code.findbugs:jsr305:jar:1.3.9:compile
> [WARNING] log4j:log4j:jar:1.2.17:test
> [WARNING] org.powermock:powermock-api-mockito:jar:1.6.5:test
> [WARNING] org.slf4j:slf4j-log4j12:jar:1.7.7:test
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
