[
https://issues.apache.org/jira/browse/FLINK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293066#comment-16293066
]
ASF GitHub Bot commented on FLINK-8227:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5142
@kl0u or @dawidwys I think this could use your opinion.
General questions:
- Is there any reason to use a boxed integer over a primitive one?
Primitives should be the default choice.
- Is is correct that this the id is transient?
> Optimize the performance of SharedBufferSerializer
> --------------------------------------------------
>
> Key: FLINK-8227
> URL: https://issues.apache.org/jira/browse/FLINK-8227
> Project: Flink
> Issue Type: Bug
> Components: CEP
> Reporter: Dian Fu
> Assignee: Dian Fu
>
> Currently {{SharedBufferSerializer.serialize()}} will create a HashMap and
> put all the {{SharedBufferEntry}} into it. Usually this is not a problem. But
> we obverse that in some cases the calculation of hashCode may become the
> bottleneck. The performance will decrease as the number of
> {{SharedBufferEdge}} increases. For looping pattern {{A*}}, if the number of
> {{SharedBufferEntry}} is {{N}}, the number of {{SharedBufferEdge}} is about
> {{N * N}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
