[
https://issues.apache.org/jira/browse/FLINK-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994354#comment-15994354
]
ASF GitHub Bot commented on FLINK-6346:
---
GitHub user fanyon opened a pull request:
GitHub user fanyon opened a pull request:
https://github.com/apache/flink/pull/3812
[FLINK-6346] Migrate from Java serialization for GenericWriteAheadSink's
state
fix Migrate from Java serialization for GenericWriteAheadSink's state
You can merge this pull request into a Git reposi
[
https://issues.apache.org/jira/browse/FLINK-6345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994319#comment-15994319
]
ASF GitHub Bot commented on FLINK-6345:
---
Github user tzulitai commented on the issue
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3750
@zhangminglei I don't think this properly solves the issue. The problem is
that we need a migration path from the Java serialization shortcut, and not
simply replace it. Otherwise we would be breaki
[
https://issues.apache.org/jira/browse/FLINK-6348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
mingleizhang reassigned FLINK-6348:
---
Assignee: mingleizhang
> Migrate from Java serialization for RollingSink's state
> --
[
https://issues.apache.org/jira/browse/FLINK-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Fang Yong reassigned FLINK-6346:
Assignee: Fang Yong
> Migrate from Java serialization for GenericWriteAheadSink's state
> -
[
https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994229#comment-15994229
]
ASF GitHub Bot commented on FLINK-5488:
---
Github user fanyon commented on the issue:
Github user fanyon commented on the issue:
https://github.com/apache/flink/pull/3805
In `YarnClusterClientV2`, I think yarn client should be stopped in
`finalizeCluster()`, which is empty right now
---
If your project is set up for it, you can reply to this email and have your
reply
Github user fanzhidongyzby commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114466541
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,145 @@
+/*
+ * Licens
Github user fanzhidongyzby commented on a diff in the pull request:
https://github.com/apache/flink/pull/3802#discussion_r114466564
--- Diff:
flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/generator/CirculantGraph.java
---
@@ -0,0 +1,161 @@
+/*
+ * Licens
[
https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994214#comment-15994214
]
ASF GitHub Bot commented on FLINK-6288:
---
Github user fanyon commented on a diff in t
Github user fanyon commented on a diff in the pull request:
https://github.com/apache/flink/pull/3766#discussion_r114466534
--- Diff:
flink-connectors/flink-connector-kafka-base/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducerBase.java
---
@@ -281,6 +30
[
https://issues.apache.org/jira/browse/FLINK-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994172#comment-15994172
]
sunjincheng edited comment on FLINK-6428 at 5/3/17 2:22 AM:
Hi
[
https://issues.apache.org/jira/browse/FLINK-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994172#comment-15994172
]
sunjincheng commented on FLINK-6428:
Hi [~rtudoran], Thanks for pay attention to this
Github user zimmermatt commented on the issue:
https://github.com/apache/flink/pull/3811
@tillrohrmann, this is the port of FLINK-5718 to the `release-1.2` branch I
mentioned. It mostly transferred over, but I needed to make some judgement
calls in `TaskManagerConfiguration`, `TaskMa
[
https://issues.apache.org/jira/browse/FLINK-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994064#comment-15994064
]
ASF GitHub Bot commented on FLINK-5718:
---
Github user zimmermatt commented on the iss
[
https://issues.apache.org/jira/browse/FLINK-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994053#comment-15994053
]
ASF GitHub Bot commented on FLINK-5718:
---
GitHub user zimmermatt opened a pull reques
GitHub user zimmermatt opened a pull request:
https://github.com/apache/flink/pull/3811
[FLINK-5718] [core] TaskManagers exit the JVM on fatal exceptions.
Manually applied and adapted commit
dfc6fba5b9830e6a7804a6a0c9f69b36bf772730 for
the `release-1.2` branch.
You can merge t
[
https://issues.apache.org/jira/browse/FLINK-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994026#comment-15994026
]
ASF GitHub Bot commented on FLINK-5906:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994023#comment-15994023
]
ASF GitHub Bot commented on FLINK-5906:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994027#comment-15994027
]
ASF GitHub Bot commented on FLINK-5906:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994028#comment-15994028
]
ASF GitHub Bot commented on FLINK-5906:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994024#comment-15994024
]
ASF GitHub Bot commented on FLINK-5906:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994025#comment-15994025
]
ASF GitHub Bot commented on FLINK-5906:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114448779
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -274,27 +278,73 @@ class CodeGenerator(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r11069
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/DStreamUDAGGITCase.scala
---
@@ -0,0 +1,309 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114447396
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -911,7 +911,21 @@ class GroupedTable(
*/
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114449859
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/DStreamUDAGGITCase.scala
---
@@ -0,0 +1,309 @@
+/*
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114448027
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -274,27 +278,73 @@ class CodeGenerator(
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3809#discussion_r114446564
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
---
@@ -911,7 +911,21 @@ class GroupedTable(
*/
[
https://issues.apache.org/jira/browse/FLINK-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen updated FLINK-2067:
Fix Version/s: 1.3.0
> Chained streaming operators should not throw chained exceptions
> ---
[
https://issues.apache.org/jira/browse/FLINK-2067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen reassigned FLINK-2067:
---
Assignee: Stephan Ewen
> Chained streaming operators should not throw chained exceptions
> --
[
https://issues.apache.org/jira/browse/FLINK-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993627#comment-15993627
]
Stavros Kontopoulos edited comment on FLINK-5536 at 5/2/17 8:06 PM:
[
https://issues.apache.org/jira/browse/FLINK-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993627#comment-15993627
]
Stavros Kontopoulos edited comment on FLINK-5536 at 5/2/17 8:06 PM:
[
https://issues.apache.org/jira/browse/FLINK-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993627#comment-15993627
]
Stavros Kontopoulos commented on FLINK-5536:
Ok can do that. I verified that t
[
https://issues.apache.org/jira/browse/FLINK-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eron Wright updated FLINK-5536:
Description:
Configure Flink HA thru package options plus good defaults. The main
components are
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993384#comment-15993384
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114380645
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -808,6
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993354#comment-15993354
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993350#comment-15993350
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993352#comment-15993352
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993349#comment-15993349
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993353#comment-15993353
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993346#comment-15993346
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993338#comment-15993338
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993348#comment-15993348
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993351#comment-15993351
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114362074
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -621,6
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114284380
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateHandle.java
---
@@ -0,0 +1
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114360519
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -621,6
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114318544
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateHandle.java
---
@@ -0,0 +1
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114287252
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointTypeTest.java
---
@@ -36,7 +36,8 @@
*/
@Test
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993339#comment-15993339
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993341#comment-15993341
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114320148
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateHandle.java
---
@@ -0,0 +1
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114363332
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -808,6
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114354639
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -621,6
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993347#comment-15993347
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993342#comment-15993342
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114289498
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateHandle.java
---
@@ -0,0 +1
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993344#comment-15993344
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993335#comment-15993335
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993345#comment-15993345
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993340#comment-15993340
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993337#comment-15993337
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114318030
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateHandle.java
---
@@ -0,0 +1
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114359825
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -621,6
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114286771
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
---
@@ -769,9 +769,10 @@ public OperatorStateBa
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114368960
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -137,6
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114318333
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateHandle.java
---
@@ -0,0 +1
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993343#comment-15993343
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114365154
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -808,6
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114361888
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -621,6
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114325070
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -265,9
[
https://issues.apache.org/jira/browse/FLINK-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993336#comment-15993336
]
ASF GitHub Bot commented on FLINK-6364:
---
Github user StefanRRichter commented on a d
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114364811
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -808,6
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114288802
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateHandle.java
---
@@ -0,0 +1
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114321075
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
---
@@ -152,6
[
https://issues.apache.org/jira/browse/FLINK-6420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostas Kloudas reassigned FLINK-6420:
-
Assignee: (was: Kostas Kloudas)
> Cleaner CEP API to specify conditions between event
[
https://issues.apache.org/jira/browse/FLINK-5536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993287#comment-15993287
]
Eron Wright commented on FLINK-5536:
-
HA is fully implemented for Flink on Mesos, yes
[
https://issues.apache.org/jira/browse/FLINK-6302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993219#comment-15993219
]
ASF GitHub Bot commented on FLINK-6302:
---
Github user alpinegizmo commented on the is
Github user alpinegizmo commented on the issue:
https://github.com/apache/flink/pull/3720
I prefer a conservative approach for as long as we still have to support
building the docs on Ruby 1.9, so I'd keep the number of updated gems as small
as possible.
As for adding support
[
https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993214#comment-15993214
]
ASF GitHub Bot commented on FLINK-5969:
---
Github user aljoscha commented on the issue
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3778
Yep, though it is code duplication both across time (releases) and
versions, now. ð
I definitely have plans to unify for the
`*From13MigrationTests`, though, since the interface is a bit more sta
[
https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993209#comment-15993209
]
ASF GitHub Bot commented on FLINK-5969:
---
Github user zentol commented on the issue:
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/3778
@aljoscha Having the same code on all branches is rather nice; never looked
at it from that angle before. Not modifying existing tests is a plus anyway; so
trying to unify from here on out sounds like
[
https://issues.apache.org/jira/browse/FLINK-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993206#comment-15993206
]
Aljoscha Krettek commented on FLINK-6107:
-
Chiming in a bit late, sorry for that.
[
https://issues.apache.org/jira/browse/FLINK-6433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993198#comment-15993198
]
Fabian Hueske commented on FLINK-6433:
--
Thanks for reporting this.
This class was co
Ted Yu created FLINK-6433:
-
Summary: Unreachable code in SqlToRelConverter#visitCall()
Key: FLINK-6433
URL: https://issues.apache.org/jira/browse/FLINK-6433
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-6431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993163#comment-15993163
]
Chesnay Schepler commented on FLINK-6431:
-
I don't know whether it's still under d
[
https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993154#comment-15993154
]
ASF GitHub Bot commented on FLINK-5969:
---
Github user aljoscha commented on a diff in
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3778#discussion_r114356062
--- Diff:
flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingFrom12MigrationTest.java
---
@@ -0,0 +1,360 @@
+/*
+ * Li
[
https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993150#comment-15993150
]
ASF GitHub Bot commented on FLINK-5969:
---
Github user aljoscha commented on the issue
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3778
@zentol Thanks again for your thorough review!
What do you think about my earlier comment regarding unification:
```
About unifying the functionality of the tests/ITCases, I was plann
[
https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993146#comment-15993146
]
ASF GitHub Bot commented on FLINK-5969:
---
Github user aljoscha commented on a diff in
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3778#discussion_r114353483
--- Diff:
flink-connectors/flink-connector-filesystem/src/test/java/org/apache/flink/streaming/connectors/fs/bucketing/BucketingSinkFrom12MigrationTest.java
--
[
https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993145#comment-15993145
]
ASF GitHub Bot commented on FLINK-5969:
---
Github user aljoscha commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993142#comment-15993142
]
ASF GitHub Bot commented on FLINK-5969:
---
Github user aljoscha commented on a diff in
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3778#discussion_r114353390
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseFrom12MigrationTest.java
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3778#discussion_r114353314
--- Diff:
flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseFrom12MigrationTest.java
1 - 100 of 276 matches
Mail list logo