Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3801#discussion_r114287252
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointTypeTest.java
---
@@ -36,7 +36,8 @@
*/
@Test
public void testOrdinalsAreConstant() {
- assertEquals(0, CheckpointType.FULL_CHECKPOINT.ordinal());
- assertEquals(1, CheckpointType.SAVEPOINT.ordinal());
+ assertEquals(0,
CheckpointType.INCREMENTAL_CHECKPOINT.ordinal());
+ assertEquals(1, CheckpointType.FULL_CHECKPOINT.ordinal());
+ assertEquals(2, CheckpointType.SAVEPOINT.ordinal());
--- End diff --
The purpose of this test is to ensures that encoding of checkpoint types
remains stable for compatibility of Flink savepoints, and this changes would
break the compatibility. In this sense, it should enforce "append-only" for new
chckpoint types. To fix this problem, `CheckpointType.INCREMENTAL_CHECKPOINT`
should be encoded as value 2 and the other types must be changed back to their
old value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
