[jira] [Comment Edited] (FLINK-4194) KinesisDeserializationSchema.isEndOfStream() is never called

2016-07-12 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374453#comment-15374453 ] Tzu-Li (Gordon) Tai edited comment on FLINK-4194 at 7/13/16 6:34 AM: ---

[jira] [Commented] (FLINK-4194) KinesisDeserializationSchema.isEndOfStream() is never called

2016-07-12 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374453#comment-15374453 ] Tzu-Li (Gordon) Tai commented on FLINK-4194: [~rmetzger] Hi Robert, I can take

[jira] [Issue Comment Deleted] (FLINK-2125) String delimiter for SocketTextStream

2016-07-12 Thread Erli Ding (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erli Ding updated FLINK-2125: - Comment: was deleted (was: I just made a PR (https://github.com/apache/flink/pull/2233) to resolve this i

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2016-07-12 Thread Erli Ding (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374282#comment-15374282 ] Erli Ding commented on FLINK-2125: -- I just made a PR (https://github.com/apache/flink/pul

[GitHub] flink issue #2233: [FLINK-2125][streaming] Delimiter change from char to str...

2016-07-12 Thread delding
Github user delding commented on the issue: https://github.com/apache/flink/pull/2233 This is my first pull request to Flink. Any comments would be very appreciative. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374279#comment-15374279 ] ASF GitHub Bot commented on FLINK-2125: --- Github user delding commented on the issue:

[jira] [Commented] (FLINK-2125) String delimiter for SocketTextStream

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374268#comment-15374268 ] ASF GitHub Bot commented on FLINK-2125: --- GitHub user delding opened a pull request:

[GitHub] flink pull request #2233: [FLINK-2125][streaming] Delimiter change from char...

2016-07-12 Thread delding
GitHub user delding opened a pull request: https://github.com/apache/flink/pull/2233 [FLINK-2125][streaming] Delimiter change from char to string Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[jira] [Commented] (FLINK-4179) Update TPCHQuery3Table example

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374149#comment-15374149 ] ASF GitHub Bot commented on FLINK-4179: --- GitHub user smarthi opened a pull request:

[GitHub] flink pull request #2232: FLINK-4179: Update TPCHQuery3Table example

2016-07-12 Thread smarthi
GitHub user smarthi opened a pull request: https://github.com/apache/flink/pull/2232 FLINK-4179: Update TPCHQuery3Table example Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration. If your changes ta

[jira] [Commented] (FLINK-4204) Clean up gelly-examples

2016-07-12 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374064#comment-15374064 ] Greg Hogan commented on FLINK-4204: --- I think there is a strong case for providing both 1

[jira] [Commented] (FLINK-4204) Clean up gelly-examples

2016-07-12 Thread Vasia Kalavri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373767#comment-15373767 ] Vasia Kalavri commented on FLINK-4204: -- [~greghogan] let me know what you think! > C

[jira] [Created] (FLINK-4204) Clean up gelly-examples

2016-07-12 Thread Vasia Kalavri (JIRA)
Vasia Kalavri created FLINK-4204: Summary: Clean up gelly-examples Key: FLINK-4204 URL: https://issues.apache.org/jira/browse/FLINK-4204 Project: Flink Issue Type: Improvement Compo

[jira] [Commented] (FLINK-4035) Bump Kafka producer in Kafka sink to Kafka 0.10.0.0

2016-07-12 Thread Radoslaw Gruchalski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373536#comment-15373536 ] Radoslaw Gruchalski commented on FLINK-4035: Hi everyone, I'm the author of t

[GitHub] flink pull request #2231: [FLINK-4035] Bump Kafka producer in Kafka sink to ...

2016-07-12 Thread radekg
GitHub user radekg opened a pull request: https://github.com/apache/flink/pull/2231 [FLINK-4035] Bump Kafka producer in Kafka sink to Kafka 0.10.0.0 Hi everyone, At The Weather Company we bumped into a problem while trying to use Flink with Kafka 0.10.x. This PR introduces

[jira] [Commented] (FLINK-4035) Bump Kafka producer in Kafka sink to Kafka 0.10.0.0

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373533#comment-15373533 ] ASF GitHub Bot commented on FLINK-4035: --- GitHub user radekg opened a pull request:

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 Using anything but a simple wrapper around a HashMap (what the MetricConfig currently is) is overkill. We would have a bunch of methods without an actual use-case cluttering up the interface.

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373325#comment-15373325 ] ASF GitHub Bot commented on FLINK-4192: --- Github user zentol commented on the issue:

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2226 I would actually prefer to use a standard library class for configuration, rather then "roll our own". With a few helper methods along the lines of "getAndParseOrReturnDefault()", this can be sim

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373285#comment-15373285 ] ASF GitHub Bot commented on FLINK-4192: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2002: Support for bz2 compression in flink-core

2016-07-12 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2002 I was assuming that you wanted to add more codecs, given the discussion above. Pending an update of the documentation (as per Greg's pointer), this can be merged in my opinion. --- If your

[GitHub] flink issue #2002: Support for bz2 compression in flink-core

2016-07-12 Thread mtanski
Github user mtanski commented on the issue: https://github.com/apache/flink/pull/2002 This has been sitting around for a month. Any chance to merge or clear todo in order to get this in shape. --- If your project is set up for it, you can reply to this email and have your reply appea

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373256#comment-15373256 ] ASF GitHub Bot commented on FLINK-4197: --- Github user rmetzger commented on a diff in

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373259#comment-15373259 ] ASF GitHub Bot commented on FLINK-4197: --- Github user rmetzger commented on the issue

[GitHub] flink issue #2227: [FLINK-4197] Allow Kinesis endpoint to be overridden via ...

2016-07-12 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2227 Looks good to merge. Waiting for the tests to pass, then merging (probably tomorrow). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as we

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-12 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2227#discussion_r70478621 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -299,3 +299,43 @@ Otherwise, the returned stream name is used. Other optional configuration ke

[jira] [Commented] (FLINK-4170) Remove `CONFIG_` prefix from KinesisConfigConstants variables

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373255#comment-15373255 ] ASF GitHub Bot commented on FLINK-4170: --- Github user tzulitai commented on the issue

[GitHub] flink issue #2228: [FLINK-4170][kinesis-connector] Simplify Kinesis connecte...

2016-07-12 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2228 Sorry, had a failing test after the rebase. Fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 I've looked into the `Properties` class. I would prefer not to use it since it would force the Reporter implementations to parse things from Strings manually. I would be nicer if we could hide that.

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373252#comment-15373252 ] ASF GitHub Bot commented on FLINK-4192: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373241#comment-15373241 ] ASF GitHub Bot commented on FLINK-4197: --- Github user rmetzger commented on a diff in

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-12 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2227#discussion_r70477574 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -299,3 +299,43 @@ Otherwise, the returned stream name is used. Other optional configuration ke

[jira] [Commented] (FLINK-4143) Configurable delimiter for metric identifier

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373229#comment-15373229 ] ASF GitHub Bot commented on FLINK-4143: --- Github user zentol commented on a diff in t

[GitHub] flink pull request #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-12 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2219#discussion_r70475544 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -64,6 +66,15 @@ public MetricRegistry(Configuration config) {

[jira] [Commented] (FLINK-3034) Redis SInk Connector

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373221#comment-15373221 ] ASF GitHub Bot commented on FLINK-3034: --- Github user kl0u commented on the issue:

[GitHub] flink issue #1813: [FLINK-3034] Redis Sink Connector

2016-07-12 Thread kl0u
Github user kl0u commented on the issue: https://github.com/apache/flink/pull/1813 Hi @subhankarb ! By playing around with the sink during testing, I saw that if Redis goes down in the middle of the execution of a job, the job has to wait until the next element (after the Redis failu

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373217#comment-15373217 ] ASF GitHub Bot commented on FLINK-4192: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2226 Makes sense (I initially thought it was mainly about the Counter and MetricGroup classes). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Commented] (FLINK-4200) Kafka consumers should log the offset from which they restore

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373198#comment-15373198 ] ASF GitHub Bot commented on FLINK-4200: --- Github user rmetzger commented on the issue

[jira] [Commented] (FLINK-4143) Configurable delimiter for metric identifier

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373200#comment-15373200 ] ASF GitHub Bot commented on FLINK-4143: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-12 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2219 The changes look good to me. Thanks for your work @zentol :-) I only had a minor comment whether we should allow users to use a string as metric scope delimiter. Apart from that, +1 for

[GitHub] flink issue #2230: [FLINK-4200] [Kafka Connector] Kafka consumers logs the o...

2016-07-12 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2230 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[jira] [Updated] (FLINK-4203) Improve Table API documentation

2016-07-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-4203: Affects Version/s: 1.1.0 > Improve Table API documentation > --- > >

[jira] [Commented] (FLINK-4143) Configurable delimiter for metric identifier

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373171#comment-15373171 ] ASF GitHub Bot commented on FLINK-4143: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2219#discussion_r70471431 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -64,6 +66,15 @@ public MetricRegistry(Configuration config) {

[jira] [Commented] (FLINK-4143) Configurable delimiter for metric identifier

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373161#comment-15373161 ] ASF GitHub Bot commented on FLINK-4143: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2219: [FLINK-4143][metrics] Configurable delimiter

2016-07-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2219#discussion_r70470970 --- Diff: flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java --- @@ -64,6 +66,15 @@ public MetricRegistry(Configuration config) {

[jira] [Commented] (FLINK-4123) CassandraWriteAheadSink can hang on cassandra failure

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373150#comment-15373150 ] ASF GitHub Bot commented on FLINK-4123: --- Github user asfgit closed the pull request

[jira] [Resolved] (FLINK-4123) CassandraWriteAheadSink can hang on cassandra failure

2016-07-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-4123. -- Resolution: Fixed Fixed via 5c2da21f25741502dd8ca64ce9d314a1ebea1441 > CassandraWriteAheadSink

[GitHub] flink pull request #2183: [FLINK-4123] Cassandra sink checks for exceptions ...

2016-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Created] (FLINK-4203) Improve Table API documentation

2016-07-12 Thread Timo Walther (JIRA)
Timo Walther created FLINK-4203: --- Summary: Improve Table API documentation Key: FLINK-4203 URL: https://issues.apache.org/jira/browse/FLINK-4203 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373076#comment-15373076 ] ASF GitHub Bot commented on FLINK-4192: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373077#comment-15373077 ] ASF GitHub Bot commented on FLINK-4197: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-12 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2227#discussion_r70462752 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -299,3 +299,43 @@ Otherwise, the returned stream name is used. Other optional configuration ke

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 The whole point of this PR is to have the MetricReporter in a separate module; other changes are just side-effects. I'll look into the Properties class. --- If your project is set up for it,

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373069#comment-15373069 ] ASF GitHub Bot commented on FLINK-4197: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-12 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2227#discussion_r70461744 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -299,3 +299,43 @@ Otherwise, the returned stream name is used. Other optional configuration ke

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373034#comment-15373034 ] ASF GitHub Bot commented on FLINK-4197: --- Github user skidder commented on a diff in

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373049#comment-15373049 ] ASF GitHub Bot commented on FLINK-4197: --- Github user tzulitai commented on the issue

[GitHub] flink issue #2227: [FLINK-4197] Allow Kinesis endpoint to be overridden via ...

2016-07-12 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/2227 @skidder Thank you for the quick responses & fixes! @rmetzger Can you also have a look through the changes & the comment on the Kinesalite referencing? Will also need help on the final mergi

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373043#comment-15373043 ] ASF GitHub Bot commented on FLINK-4197: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-12 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2227#discussion_r70459536 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -299,3 +299,41 @@ Otherwise, the returned stream name is used. Other optional configuration ke

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-12 Thread skidder
Github user skidder commented on a diff in the pull request: https://github.com/apache/flink/pull/2227#discussion_r70458869 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -299,3 +299,41 @@ Otherwise, the returned stream name is used. Other optional configuration key

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-12 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2227#discussion_r70458352 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -299,3 +299,41 @@ Otherwise, the returned stream name is used. Other optional configuration ke

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373030#comment-15373030 ] ASF GitHub Bot commented on FLINK-4197: --- Github user tzulitai commented on a diff in

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373025#comment-15373025 ] ASF GitHub Bot commented on FLINK-4197: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-12 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2227#discussion_r70457990 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -299,3 +299,41 @@ Otherwise, the returned stream name is used. Other optional configuration ke

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373018#comment-15373018 ] ASF GitHub Bot commented on FLINK-4197: --- Github user tzulitai commented on a diff in

[GitHub] flink pull request #2227: [FLINK-4197] Allow Kinesis endpoint to be overridd...

2016-07-12 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/2227#discussion_r70457227 --- Diff: docs/apis/streaming/connectors/kinesis.md --- @@ -299,3 +299,41 @@ Otherwise, the returned stream name is used. Other optional configuration ke

[jira] [Commented] (FLINK-4149) Fix Serialization of NFA in AbstractKeyedCEPPatternOperator

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373006#comment-15373006 ] ASF GitHub Bot commented on FLINK-4149: --- Github user tillrohrmann commented on the i

[GitHub] flink issue #2202: [FLINK-4149] Fix Serialization of NFA in AbstractKeyedCEP...

2016-07-12 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/2202 Changes look good to me. Thanks for fixing the CEP issues @aljoscha :-). I had some minor comments concerning the NFA serializer. Before merging it would be good to rebase on the latest

[jira] [Commented] (FLINK-4034) Dependency convergence on com.101tec:zkclient and com.esotericsoftware.kryo:kryo

2016-07-12 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372979#comment-15372979 ] Stephan Ewen commented on FLINK-4034: - Super, thanks a lot! > Dependency convergence

[jira] [Commented] (FLINK-4034) Dependency convergence on com.101tec:zkclient and com.esotericsoftware.kryo:kryo

2016-07-12 Thread Vladislav Pernin (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372977#comment-15372977 ] Vladislav Pernin commented on FLINK-4034: - For sure, even if I have been very care

[GitHub] flink issue #2194: [FLINK-4067] [runtime] Add savepoint headers

2016-07-12 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2194 If there are no objections, I would like to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] flink issue #2083: [FLINK-3713] [clients, runtime] Use user code class loade...

2016-07-12 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/2083 If there are no objections, I would like to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-4067) Add version header to savepoints

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372972#comment-15372972 ] ASF GitHub Bot commented on FLINK-4067: --- Github user uce commented on the issue:

[jira] [Commented] (FLINK-3713) DisposeSavepoint message uses system classloader to discard state

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372973#comment-15372973 ] ASF GitHub Bot commented on FLINK-3713: --- Github user uce commented on the issue:

[GitHub] flink pull request #2202: [FLINK-4149] Fix Serialization of NFA in AbstractK...

2016-07-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2202#discussion_r70450213 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -454,4 +458,126 @@ static String generateStateName(final Strin

[jira] [Commented] (FLINK-4149) Fix Serialization of NFA in AbstractKeyedCEPPatternOperator

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372963#comment-15372963 ] ASF GitHub Bot commented on FLINK-4149: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4199) Wrong client behavior when submitting job to non-existing cluster

2016-07-12 Thread Kostas Kloudas (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372951#comment-15372951 ] Kostas Kloudas commented on FLINK-4199: --- Another related issue is that a similar mis

[jira] [Commented] (FLINK-4149) Fix Serialization of NFA in AbstractKeyedCEPPatternOperator

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372960#comment-15372960 ] ASF GitHub Bot commented on FLINK-4149: --- Github user tillrohrmann commented on a dif

[jira] [Commented] (FLINK-4149) Fix Serialization of NFA in AbstractKeyedCEPPatternOperator

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372959#comment-15372959 ] ASF GitHub Bot commented on FLINK-4149: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2202: [FLINK-4149] Fix Serialization of NFA in AbstractK...

2016-07-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2202#discussion_r70449753 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -454,4 +458,126 @@ static String generateStateName(final Strin

[GitHub] flink pull request #2202: [FLINK-4149] Fix Serialization of NFA in AbstractK...

2016-07-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2202#discussion_r70449634 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -454,4 +458,126 @@ static String generateStateName(final Strin

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372955#comment-15372955 ] ASF GitHub Bot commented on FLINK-4192: --- Github user StephanEwen commented on the is

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2226 Could the `MetricReporter` stay in `flink-core`as well, or does that void the separation of dependencies. You can probably use the Java `Properties` object as a configuration object. Sav

[jira] [Commented] (FLINK-4149) Fix Serialization of NFA in AbstractKeyedCEPPatternOperator

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372952#comment-15372952 ] ASF GitHub Bot commented on FLINK-4149: --- Github user tillrohrmann commented on a dif

[GitHub] flink pull request #2202: [FLINK-4149] Fix Serialization of NFA in AbstractK...

2016-07-12 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/2202#discussion_r70448543 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -19,12 +19,16 @@ package org.apache.flink.cep.nfa;

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372942#comment-15372942 ] ASF GitHub Bot commented on FLINK-4192: --- Github user zentol commented on the issue:

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/2226 you are correct that the MetricRegistry could remain in flink-core. However, you would still need the new MetricConfig due to the MetricReporter. --- If your project is set up for it, you can reply t

[jira] [Resolved] (FLINK-4111) Flink Table & SQL doesn't work in very simple example

2016-07-12 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-4111. - Resolution: Fixed Fixed in 508965e69cfb99724b69f1e5dc59e5f5d5a70315. > Flink Table & SQL doesn't

[jira] [Commented] (FLINK-4197) Allow Kinesis Endpoint to be Overridden via Config

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372941#comment-15372941 ] ASF GitHub Bot commented on FLINK-4197: --- Github user skidder commented on the issue:

[GitHub] flink issue #2227: [FLINK-4197] Allow Kinesis endpoint to be overridden via ...

2016-07-12 Thread skidder
Github user skidder commented on the issue: https://github.com/apache/flink/pull/2227 @tzulitai definitely, I'll add an explanation of the config setting in the docs shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[jira] [Created] (FLINK-4202) Add JM metric which shows the restart duration

2016-07-12 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-4202: Summary: Add JM metric which shows the restart duration Key: FLINK-4202 URL: https://issues.apache.org/jira/browse/FLINK-4202 Project: Flink Issue Type: Impr

[GitHub] flink issue #2226: [FLINK-4192] - Move Metrics API to separate module

2016-07-12 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/2226 Is it important that the metric reporter projects do not depend on "flink-core"? If not, the the entire MetricRegistry could stay in flink-core, and there would be no need to the MetricConfig obj

[jira] [Created] (FLINK-4201) Checkpoints for jobs in non-terminal state (e.g. suspended) get deleted

2016-07-12 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-4201: - Summary: Checkpoints for jobs in non-terminal state (e.g. suspended) get deleted Key: FLINK-4201 URL: https://issues.apache.org/jira/browse/FLINK-4201 Project: Flin

[jira] [Commented] (FLINK-4111) Flink Table & SQL doesn't work in very simple example

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372932#comment-15372932 ] ASF GitHub Bot commented on FLINK-4111: --- Github user asfgit closed the pull request

[GitHub] flink pull request #2209: [FLINK-4111] [table] Flink Table & SQL doesn't wor...

2016-07-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

2016-07-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372930#comment-15372930 ] ASF GitHub Bot commented on FLINK-4192: --- Github user StephanEwen commented on the is

[jira] [Updated] (FLINK-4150) Problem with Blobstore in Yarn HA setting on recovery after cluster shutdown

2016-07-12 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stefan Richter updated FLINK-4150: -- Description: Submitting a job in Yarn with HA can lead to the following exception: {code} org.a

  1   2   >