[
https://issues.apache.org/jira/browse/FLINK-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373006#comment-15373006
]
ASF GitHub Bot commented on FLINK-4149:
---------------------------------------
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2202
Changes look good to me. Thanks for fixing the CEP issues @aljoscha :-). I
had some minor comments concerning the NFA serializer.
Before merging it would be good to rebase on the latest master and rerun
Travis, because many builds failed due to a problem with the Kinesis connector.
Thus, there might be some problems shadowed by the failing Kinesis tests (not
really expecting this).
> Fix Serialization of NFA in AbstractKeyedCEPPatternOperator
> -----------------------------------------------------------
>
> Key: FLINK-4149
> URL: https://issues.apache.org/jira/browse/FLINK-4149
> Project: Flink
> Issue Type: Bug
> Components: CEP
> Affects Versions: 1.0.0, 1.1.0, 1.0.1, 1.0.2, 1.0.3
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Blocker
> Fix For: 1.1.0
>
>
> A job that uses CEP fails upon restore with a {{NullPointerException}} in
> {{NFA.process()}}. The reason seems to be that field {{computationStates}} is
> {{null}}. This field is transient and read in a custom {{readObject()}}
> method.
> In {{AbstractKeyedCEPPatternOperator}} this snipped is used to construct a
> {{StateDescriptor}} for an {{NFA}} state:
> {code}
> new ValueStateDescriptor<NFA<IN>>(
> NFA_OPERATOR_STATE_NAME,
> new KryoSerializer<NFA<IN>>((Class<NFA<IN>>) (Class<?>) NFA.class,
> getExecutionConfig()),
> null)
> {code}
> It seems Kryo does not invoke {{readObject}}/{{writeObject}}. We probably
> need a custom {{TypeSerializer}} for {{NFA}} to solve the problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
