[
https://issues.apache.org/jira/browse/FLINK-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15374064#comment-15374064
]
Greg Hogan commented on FLINK-4204:
-----------------------------------
I think there is a strong case for providing both 1) drivers and 2) examples.
The drivers are a nice way to kick the tires, to run the algorithms on actual
data, and as examples for using the library methods. The example algorithms, as
you note, illustrate the APIs.
The {{provided}} scoping that was discussed in February forced the executable
code into the separate examples module.
I think it would be helpful to namespace the drivers into
{{o.a.f.graph.examples.driver}}. Also, to provide some documentation under
"Using Gelly" for running a job.
It's nice to consolidate algorithms where possible, for example
ClusteringCoefficient performs both local and global for directed and
undirected.
I like seeing three variants of, for example, SSSP as the comparison makes a
useful example. I'd prefer to clean these up a little so that the examples
demonstrate performant code and out-of-the-box can run on a large data set.
> Clean up gelly-examples
> -----------------------
>
> Key: FLINK-4204
> URL: https://issues.apache.org/jira/browse/FLINK-4204
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
> Affects Versions: 1.1.0
> Reporter: Vasia Kalavri
>
> The gelly-examples has grown quite big (14 examples) and contains several
> examples that illustrate the same functionality. Examples should help users
> understand how to use the API and ideally show how to use 1-2 features.
> Also, it is helpful to state the purpose of each example in the comments.
> We should keep the example set small and move everything that does not fit
> there to the library.
> I propose to remove the following:
> - ClusteringCoefficient: the functionality already exists as a library method.
> - HITS: the functionality already exists as a library method.
> - JaccardIndex: the functionality already exists as a library method.
> - SingleSourceShortestPaths: the example shows how to use scatter-gather
> iterations. HITSAlgorithm shows the same feature plus the use of aggregators.
> I propose we keep this one instead.
> - TriangleListing: the functionality already exists as a library method
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
