Re: [PR] fixed maxBuildToolVersion calculation [cordova-android]

2025-01-21 Thread via GitHub
breautek closed pull request #1761: fixed maxBuildToolVersion calculation URL: https://github.com/apache/cordova-android/pull/1761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] fixed maxBuildToolVersion calculation [cordova-android]

2025-01-21 Thread via GitHub
breautek commented on PR #1761: URL: https://github.com/apache/cordova-android/pull/1761#issuecomment-2605365962 The intent is to allow >= the min build tools version, but not allow the next major version. ``` def maxVersion = new Version((minBuildToolsVersion.getMajor() + 1) + ".0

[PR] fixed maxBuildToolVersion calculation [cordova-android]

2025-01-21 Thread via GitHub
ssiyo opened a new pull request, #1761: URL: https://github.com/apache/cordova-android/pull/1761 ### Platforms affected Android ### Motivation and Context The `doFindLatestInstalledBuildTools` function in `cordova.gradle` has a bug: it can exclude valid B