breautek commented on PR #1761: URL: https://github.com/apache/cordova-android/pull/1761#issuecomment-2605365962
The intent is to allow >= the min build tools version, but not allow the next major version. ``` def maxVersion = new Version((minBuildToolsVersion.getMajor() + 1) + ".0.0") ``` This is exactly what this grabs. so if the min version is `34.0.1`, then the max version value is `35.0.0`, the equation is `version >= 34.0.1 && version < 35.0.0` (exclusive check, in otherwords build tools version `35.0.0` will also fail and this is intentional). > The script considers 35.0.1 not within 34.0.0-35.0.0, which is a range that incorrectly calculates its upper bound. 35.0.1 is in fact not within 34.0.0-35.0.0. Updating the max version to be hard-coded arbitrary value to allow anything above the min version will result unexpected breakage. The build tools package often includes breaking changes. Instead you should just install/use the latest available patch of version `34` of build tools. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
