Re: [PHP-DEV] BC break with rand() where min > max

2016-08-09 Thread Christoph M. Becker
to disallow this in the future, use an E_DEPRECATED, but a > warning seems pointless unless it's doing the wrong thing, or it's going to > start doing the wrong thing at some point. +1 -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] GC issue wrt. to resource <-> object cycles?

2016-08-10 Thread Christoph M. Becker
rs fine, but actually it's in error, because of <https://github.com/php/php-src/commit/72ec2e8f>. Not increasing the refcount of `parser->object` might theoretically lead to use-after-free scenarios. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] SQLite 3.14

2016-08-10 Thread Christoph M. Becker
On 10.08.2016 at 16:01, Anatol Belski wrote: > Hi Christoph, > >> -Original Message- >> From: Christoph M. Becker [mailto:cmbecke...@gmx.de] >> Sent: Monday, August 8, 2016 11:23 PM >> To: internals@lists.php.net; Anatol Belski >> Subject: [PHP-DEV

Re: [PHP-DEV] GC issue wrt. to resource <-> object cycles?

2016-08-10 Thread Christoph M. Becker
On 10.08.2016 at 12:59, Nikita Popov wrote: > On Wed, Aug 10, 2016 at 12:52 PM, Christoph M. Becker > wrote: >> >> I've tried to fix <https://bugs.php.net/72793>, and it looks like >> there's a general GC issue wrt. to resources referencing objects and &

Re: [PHP-DEV] GC issue wrt. to resource <-> object cycles?

2016-08-10 Thread Christoph M. Becker
On 10.08.2016 at 19:34, Fleshgrinder wrote: > On 8/10/2016 4:17 PM, Christoph M. Becker wrote: >> On 10.08.2016 at 12:59, Nikita Popov wrote: >> >>> The simplest way to fix ext/xml in particular is probably to migrate it to >>> use an object instead of a resourc

Re: [PHP-DEV] SQLite 3.14

2016-08-10 Thread Christoph M. Becker
On 10.08.2016 at 20:51, Rasmus Schultz wrote: > On Wed, Aug 10, 2016 at 4:08 PM, Christoph M. Becker > wrote: > >> Sounds reasonable, Anotol. Thanks. So I'm going to update 7.1+ ASAP. > > Are you going to include any plugins? > > I noticed today, SQLite h

Re: [PHP-DEV] GC issue wrt. to resource <-> object cycles?

2016-08-10 Thread Christoph M. Becker
On 10.08.2016 at 13:38, Kalle Sommer Nielsen wrote: > 2016-08-10 12:59 GMT+02:00 Nikita Popov : >> On Wed, Aug 10, 2016 at 12:52 PM, Christoph M. Becker >> wrote: >> The simplest way to fix ext/xml in particular is probably to migrate it to >> use an object instea

Re: [PHP-DEV] Simple variable handling.

2016-08-12 Thread Christoph M. Becker
) {} function setConstraint() {} function setEscape() {} function setReadOnly() {} function isValid() {} function __toString() {} } $var = new Container($some_value); -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] GC issue wrt. to resource <-> object cycles?

2016-08-12 Thread Christoph M. Becker
On 11.08.2016 at 12:04, Rowan Collins wrote: > On 10/08/2016 19:23, Christoph M. Becker wrote: >> That might be a good idea, even if we already have the XMLReader. And >> yes, the utf8_* functions don't really belong into ext/xml; frankly, I >> think they don't be

Re: [PHP-DEV] GC issue wrt. to resource <-> object cycles?

2016-08-12 Thread Christoph M. Becker
On 11.08.2016 at 12:04, Rowan Collins wrote: > On 10/08/2016 19:23, Christoph M. Becker wrote: > >> That might be a good idea, even if we already have the XMLReader. And >> yes, the utf8_* functions don't really belong into ext/xml; frankly, I >> think they don&#

[PHP-DEV] Bug #72828

2016-08-13 Thread Christoph M. Becker
p-src/blob/php-5.6.24/ext/standard/string.c#L2926-L2927> [2] <https://github.com/php/php-src/blob/php-5.6.24/ext/standard/string.c#L3133-L3134> -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: Bug #72828

2016-08-13 Thread Christoph M. Becker
On 13.08.2016 at 15:08, Nikita Popov wrote: > On Sat, Aug 13, 2016 at 2:42 PM, Christoph M. Becker > wrote: > >> You have commented on <https://bugs.php.net/bug.php?id=72828>: >> >> | Unless the allocations explicitly use the system allocator (i.e. do >>

Re: [PHP-DEV] Bug #72828

2016-08-14 Thread Christoph M. Becker
easier it to catch it. > > If pe* or system functions are used, then check may be warranted. Thanks! I had already closed the bug report, because the issue affects only PHP 5.6, and I don't think this extraneous NULL check is a real bug. Please re-open if you don't agree, in which c

[PHP-DEV] Re: [RFC] get_class() disallow null parameter

2016-08-14 Thread Christoph M. Becker
hile `__CLASS__` has been introduced with PHP 4.3.0, it had the glitch to return the lower-cased class name before PHP 5.0.0. So there *might* still be PHP 5 code around using `get_class(NULL)`. The deprecation might be more appropriate, and could equally well catch an inadvertent `get_class(NUL

Re: [PHP-DEV] Namespaces internal refactoring

2016-08-14 Thread Christoph M. Becker
deal with the > class by only considering the important things. If it were only about suppressing unimportant details, documentation would suffice, e.g. /** @private */ or the leading underscore convention. I am, however, quite happy to have language support to catch *inadvertent* accesses.

Re: [PHP-DEV] Re: [RFC] get_class() disallow null parameter

2016-08-15 Thread Christoph M. Becker
s that we should be careful here. Deprecating for 7.2 and removing with 8.0 seems to be the safer way. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC][VOTE] Add validation functions to filter module

2016-08-15 Thread Christoph M. Becker
y invalid input, such as invalid UTF-8 byte sequences. I think, that in this case the app should bail out without even given detailed information, as such grossly invalid input most likely is an attempt to attack (or a severe browser bug). -- Christoph M. Becker -- PHP Internals - PHP Runtime

[PHP-DEV] Re: [RFC] orphan extensions cleanup

2016-08-15 Thread Christoph M. Becker
c/EXTENSIONS is totally out-dated. The bug tracker statistics appear to present a somewhat more realistic view: <https://bugs.php.net/stats.php>. The topmost bundled extensions having the most unresolved issues are standard, soap, date, spl and pdo. The XML related extensions (libxml,

Re: [PHP-DEV] rethinking security issues in bugs db

2016-08-15 Thread Christoph M. Becker
net/search.php?search_for=&boolean=0&limit=30&order_by=&direction=DESC&cmd=display&status=Open&bug_type=All&project=All&php_os=&phpver=&cve_id=&assign=&author_email=me%40kelunik.com&bug_age=0&bug_updated=0>. -- Christoph M. Becker -- PHP

[PHP-DEV] Re: [RFC] orphan extensions cleanup

2016-08-15 Thread Christoph M. Becker
ivate bug reports is rather special, as you've already pointed out in the other mail "rethinking security issues in bugs db". Unless the extension maintainer has access to these tickets, (s)he can't be of much help. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC][VOTE] Add validation functions to filter module

2016-08-16 Thread Christoph M. Becker
sequence that was malformed), but presenting them to visitors doesn't seem to be helpful – most of these wouldn't even know what UTF-8 is. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [RFC][DISCUSSION] Remove utf8_decode() and utf8_encode()

2016-08-16 Thread Christoph M. Becker
a new active maintainer steps forward, we should consider to move ext/xml to PECL, in which case the deprecation of utf8_(en|de)code might be unnecessary. [1] <http://news.php.net/php.internals/94998> [2] <http://news.php.net/php.internals/95033> [3] <http://news.php.net/php.intern

Re: [PHP-DEV] Re: [RFC][VOTE] Add validation functions to filtermodule

2016-08-17 Thread Christoph M. Becker
please. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC][VOTE] Add validation functions tofiltermodule

2016-08-17 Thread Christoph M. Becker
On 17.08.2016 at 12:52, Lester Caine wrote: > On 17/08/16 10:36, Christoph M. Becker wrote: >> On 17.08.2016 at 10:58, Lester Caine wrote: >> >>>> ( and the javascript thing is more a case of upgrading PHP examples to >>>> use html5 validation by default )

[PHP-DEV] Re: [RFC] orphan extensions cleanup

2016-08-17 Thread Christoph M. Becker
l try to write the second RFC > soon (hopefully I'll have time) and we can do the maintainer list > refersh together with deciding what to do with unmaintaned extensions. Sounds good to me. If I can be of assistance, please let me know. -- Christoph M. Becker -- PHP Internals -

Re: [PHP-DEV] [RFC] orphan extensions cleanup

2016-08-18 Thread Christoph M. Becker
[1] <https://bugs.php.net/search.php?cmd=display&package_name[]=DBM%2FDBA+related> [2] <https://github.com/php/php-src/blob/PHP-7.0.9/ext/dba/dba.c#L654> -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] orphan extensions cleanup

2016-08-18 Thread Christoph M. Becker
Hi Kalle! On 18.08.2016 at 15:12, Kalle Sommer Nielsen wrote: > 2016-08-18 15:03 GMT+02:00 Christoph M. Becker : > >> I don't know, but most certainly not on Windows. I had a look at >> ext/dba, because I like that we have it bundled, but got 3 failing tests >>

Re: [PHP-DEV] [RFC] orphan extensions cleanup

2016-08-18 Thread Christoph M. Becker
On 18.08.2016 at 15:46, Christoph M. Becker wrote: > That would be great! A quick fix (simply removing the db3 check) made > it compile, but the test suite stalled on dba_flatfile.phpt. That was actually caused by the test case being broken. I've fixed it just now: <http://git.

Re: [PHP-DEV] [RFC] orphan extensions cleanup

2016-08-19 Thread Christoph M. Becker
On 18.08.2016 at 15:46, Christoph M. Becker wrote: > On 18.08.2016 at 15:12, Kalle Sommer Nielsen wrote: > >> But I will have to look at our deps and see if it is possible to get >> this running again with some cross reference to the m4. > > That would be great! I

[PHP-DEV] Re: [PHP-CVS] com php-src: Fix dba configuration for Windows: ext/dba/config.w32

2016-08-19 Thread Christoph M. Becker
m php-src: Fix dba configuration for Windows: >> ext/dba/config.w32 >> >> Commit:ad76e8a529eabf150f17d313bb035b329bc68dec >> Author:Christoph M. Becker Fri, 19 Aug 2016 >> 11:42:16 +0200 >> Parents: bc1214f25e7c9525336b34e09aec1f1db82b9894 >>

Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Fix dba configuration for Windows: ext/dba/config.w32

2016-08-19 Thread Christoph M. Becker
On 19.08.2016 at 15:22, Anatol Belski wrote: >> -Original Message- >> From: Christoph M. Becker [mailto:cmbecke...@gmx.de] >> Sent: Friday, August 19, 2016 1:38 PM >> To: Anatol Belski ; php-...@lists.php.net; >> internals@lists.php.net >> Subject: [PHP

Re: [PHP-DEV] SQLite 3.14

2016-08-19 Thread Christoph M. Becker
[1] <https://github.com/php/php-src/blob/PHP-7.1.0beta3/ext/sqlite3 /sqlite3.c#L125> [2] <https://github.com/php/php-src/commit/cc125f27> -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] SQLite 3.14

2016-08-19 Thread Christoph M. Becker
rsion, this patch might be committed to PHP 7.0 (the code is dead code anyway, if the test succeeds), and maybe removed later. BTW: do you deliberately run the tests without -n in <https://github.com/dshafik/php-build/blob/master/build.sh#L294>? Regards, Christoph > - Davey > On Sa

Re: [PHP-DEV] Write down a deprecation policy

2016-08-20 Thread Christoph M. Becker
ns messages +1 -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC][DISCUSSION] Remove utf8_decode() andutf8_encode()

2016-08-22 Thread Christoph M. Becker
be moved into the string section of the source, exposed in such a way >> that the XML parser can still make use of them. > > Thanks for looking deeper. That makes even more sense now. +1 -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: BC break: ReflectionMethod::invoke() expects parameter 1 to beobject, string given

2016-08-22 Thread Christoph M. Becker
[1] <https://github.com/php/php-src/blob/PHP-7.0.10/ext/reflection/php_reflection.c#L3197-L3202> If so desired, I can revert that commit, but I wouldn't be happy with sticking with a completely unused parameter, which obviously has been and still is misunderstood. -- Christoph M. Becke

Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects parameter1 to be object, string given

2016-08-22 Thread Christoph M. Becker
e, in prior versions, the first argument was completely > ignored for static methods: https://3v4l.org/8o4Hm > > $m->invoke('some_other_class_name', 'baz'); // Warns in 7.1.0beta3, > ignores everywhere else > $m->invoke(42, 'baz'); // Warns in 7.

Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects parameter1 to be object, string given

2016-08-22 Thread Christoph M. Becker
roduced a new class in a hierarchy, but nobody noticed that an ::invoke() call would have to be adjusted accordingly. Suddenly changing the meaning of the first parameter may well introduce a behavioral change. [1] <https://github.com/php/php-src/blob/PHP-7.1.0beta3/UPGRADING#L18-L129> --

Re: [PHP-DEV] [RFC] orphan extensions cleanup

2016-08-22 Thread Christoph M. Becker
; Stanislav Malyshev >> Subject: Re: [PHP-DEV] [RFC] orphan extensions cleanup >> >> On Aug 18, 2016 8:03 PM, "Christoph M. Becker" >> >>> I don't know, but most certainly not on Windows. I had a look at >>> ext/dba, because I like th

Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects parameter1to be object, string given

2016-08-23 Thread Christoph M. Becker
aviour should an object argument give? >> >> In my opinion, the best "fix", if something needs to change, would be to >> reject anything other than null; that anything else works appears to just be >> an oversight. > > Anyone oppose to emitting E_DEPRE

Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects parameter1to be object, string given

2016-08-23 Thread Christoph M. Becker
On 23.08.2016 at 13:36, Julien Pauli wrote: > On Tue, Aug 23, 2016 at 10:30 AM, Christoph M. Becker > wrote: > >> On 23.08.2016 at 00:25, Levi Morrison wrote: >> >>> On Mon, Aug 22, 2016 at 3:40 PM, Rowan Collins >>> wrote: >>>> >>

[PHP-DEV] Re: [RFC][VOTE] E_WARNING on invalid container read-adccess

2016-08-25 Thread Christoph M. Becker
r is noted in a comment I have documented this behavior now[3], and removed the note, which was not quite correct, because it claimed that TRUE would be returned when array dereferencing NULL, bool or int. [3] <http://svn.php.net/viewvc?view=revision&revision=339937> -- Christoph M.

Re: [PHP-DEV] Reverting "Too Few Arguments Exception" RFC

2016-08-25 Thread Christoph M. Becker
> Inability to provide a more specific exception should not be a blocker for > this, especially as this is beyond the scope of the original RFC. Indeed, the RFC explicitly claims: | Behavior of internal functions is not going to be changed. The RFC has been accepted, so I don't see

Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expects parameter1to be object, string given

2016-08-25 Thread Christoph M. Becker
that it takes ten years again, and therefore might be more inclined to accept BC breaks in a minor version ("better a BC now, than to wait too long for the improvement"). -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] BC break: ReflectionMethod::invoke() expectsparameter1to be object, string given

2016-08-25 Thread Christoph M. Becker
Am 23.08.2016 um 14:51 schrieb Julien Pauli: > On Tue, Aug 23, 2016 at 1:51 PM, Christoph M. Becker > wrote: > >> I suggest to deprecate all other types than NULL as first arg for static >> methods, because passing an int, for instance, makes even less sense as >> Ro

Re: [PHP-DEV] Reverting "Too Few Arguments Exception" RFC

2016-08-26 Thread Christoph M. Becker
On 25.08.2016 at 18:37, Davey Shafik wrote: > On Thu, Aug 25, 2016 at 8:12 PM, Christoph M. Becker > wrote: > >> Indeed, the RFC explicitly claims: >> >> | Behavior of internal functions is not going to be changed. > > This is correct for functions tha

Re: [PHP-DEV] Reverting "Too Few Arguments Exception" RFC

2016-08-26 Thread Christoph M. Becker
On 26.08.2016 at 16:48, Levi Morrison wrote: > On Fri, Aug 26, 2016 at 4:53 AM, Christoph M. Becker > wrote: > >> Finally, I wonder why array_diff(), for instance, even has an explicit >> check for ZEND_NUM_ARGS() and for Z_TYPE() != IS_ARRAY instead of

[PHP-DEV] Re: [PHP-CVS] com php-src: Fix #65550: get_browser() incorrectlyparsers entries with "+" sign: NEWS ext/standard/browscap.c ext/standard/tests/misc/bug65550.phpt

2016-08-27 Thread Christoph M. Becker
<http://php.net/manual/en/function.get-browser.php#118632> -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: [RFC][VOTE] E_WARNING on invalid container read-adccess

2016-08-31 Thread Christoph M. Becker
esday, August 31, 2016 10:10:23 AM > To: Dmitry Stogov > Cc: Christoph M. Becker; PHP Internals List; Nikita Popov; David Walker > Subject: Re: [PHP-DEV] Re: [RFC][VOTE] E_WARNING on invalid container > read-adccess > > > Hi Dmitry, > > On 31 Aug 2016 8:37 a.m., "

Re: [PHP-DEV] Re: [RFC][VOTE] E_WARNING on invalid container read-adccess

2016-09-02 Thread Christoph M. Becker
ust like property access, which also might throw multiple notices, see <https://3v4l.org/v49i7>. If this is considered too much of a BC break for 7.2, we still could postpone that change to 8.0. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC][VOTE] Deprecate then Remove Mcrypt Closed (23-6)

2016-09-02 Thread Christoph M. Becker
On 02.09.2016 at 17:24, Davey Shafik wrote: > That would be why I thought it hadn't been missed! > > Thanks Scott (and Christoph :) And Thomas: Cheers! > - Davey > > On Fri, Sep 2, 2016 at 8:19 AM, Scott A

[PHP-DEV] Re: [RFC][VOTE]: Implement socket_getaddrinfo family

2016-09-02 Thread Christoph M. Becker
ever it would need to go for 7.2) I have merged the PR into master (what's indeed the proper branch for 7.2), and also adjusted the RFC accordingly. Thanks for the RFC and the implementation, Dave! -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] SQLite 3.14

2016-09-02 Thread Christoph M. Becker
ir(__DIR__); at the top. Indeed, using chdir() seems to be the proper way to test for open_basedir restrictions, see <https://github.com/php/php-src/blob/PHP-7.0.11/tests/security/open_basedir.inc#L12-L14>. Should that be changed for PHP-5.6+? Cheers! > Thoughts? > > On Fri, Aug 19,

Re: [PHP-DEV] SQLite 3.14

2016-09-02 Thread Christoph M. Becker
On 02.09.2016 at 21:21, Davey Shafik wrote: > Good find with that other test! > > I don't see any reason not to fix it for 5.6+ Fine, I'll see to it. Cheers! > - Davey > > On Fri, Sep 2, 2016 at 12:08 PM, Christoph M. Becker > wrote: > >> On

Re: [PHP-DEV] Single Point of Entry Apps.

2016-09-05 Thread Christoph M. Becker
t it isn't easy. > > Again, the above may not be a possible solution - but there's got to be a > better way than the current approach which amounts to installing the > application on every single request. > > Thank you all for your time. Not long ago (something like) th

[PHP-DEV] How to properly fix issues in ext/zip?

2016-09-05 Thread Christoph M. Becker
Hi! I've stumbled upon <https://bugs.php.net/70752> and could fix it, but I'm not sure whether the fix should be applied to php-src/ext/zip or rather against PECL/zip (i.e. <https://github.com/pierrejoye/php_zip>). So, which repo is the "master" – ext/zip or PE

Re: [PHP-DEV] How to properly fix issues in ext/zip?

2016-09-05 Thread Christoph M. Becker
On 05.09.2016 at 18:40, Remi Collet wrote: > Le 05/09/2016 à 18:23, Christoph M. Becker a écrit : > >> I've stumbled upon <https://bugs.php.net/70752> and could fix it, but >> I'm not sure whether the fix should be applied to php-src/ext/zip or >> rather ag

[PHP-DEV] Re: The death of `#ifndef FAST_ZPP`?

2016-09-07 Thread Christoph M. Becker
hrough > and removing all unnecessary zend_parse_parameters fallbacks, and making > it impossible to disable FAST_ZPP? This would make the two APIs equally > valid. All in all, I think that the benefits of using only one of the parameter parsing APIs per function outweigh the drawback

Re: [PHP-DEV] RFC - Immutable classes

2016-09-07 Thread Christoph M. Becker
ue) > > $b->p = 1; > > var_dump($a === $b); // bool(false) > > It's only about writing to existing properties. Ah, good old PHP 4, see <https://3v4l.org/VaD1W#v5328>. :-) -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] [RFC] Deprecate PEAR/PECL & Replace withcomposer/pickle

2016-09-08 Thread Christoph M. Becker
composer are needed > as an alternative and those are not currently in place? The `global` command appears to solve that: <https://getcomposer.org/doc/03-cli.md#global>. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] RFC - Immutable classes

2016-09-08 Thread Christoph M. Becker
der >> >> I will make changes that if immutable objects are being compared that they >> will be compared by value rather then hash >> On Sep 7, 2016 8:27 PM, "Christoph M. Becker" wrote: >> >>> On 07.09.2016 at 20:11, Fleshgrinder wrote: >>> >&

[PHP-DEV] Re: [RFC][VOTE]: Argon2 Password Hash (Reopened)

2016-09-08 Thread Christoph M. Becker
ient, as the doc team is supposed to integrate the UPGRADING information into the manual proper and the respective migration guide. Of course, it's also possible to update the manual now, making sure that there are notes about the availability (maybe as changelog entries). -- Christoph M. Beck

Re: [PHP-DEV] [RFC][VOTE] Add validation functions to filter module

2016-09-08 Thread Christoph M. Becker
So the above script is replaced by $var->is_valid(); or if you prefer it >> throws an exception when you try and set the variable with an invalid >> input ( or one that does not match a 'strict' rule ). > > Anyway, your way would work with autoboxing. > https://wiki.

[PHP-DEV] Re: The death of `#ifndef FAST_ZPP`?

2016-09-08 Thread Christoph M. Becker
Hi Andrea! On 07.09.2016 at 17:26, Andrea Faulds wrote: > Christoph M. Becker wrote: > >> On 04.05.2016 at 18:11, Andrea Faulds wrote: > > This is a fair point. Functions using Fast ZPP have larger code size, > because of aggressive inlining. > > If every function

[PHP-DEV] Re: [RFC] Make uniqid() more unique

2016-09-09 Thread Christoph M. Becker
/php-src/blob/PHP-7.0.11/ext/standard/uniqid.c#L68> -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PDO] Shared behavior of persistent connections

2016-09-09 Thread Christoph M. Becker
. I think I even > never used them on PDO. > > That said, yes that's the behaviour I would expect. Transactions should > be rolled back and the environment should be completely clean from > anything that's suppose to last for the current session only. > > > Ch

[PHP-DEV] Re: The death of `#ifndef FAST_ZPP`?

2016-09-09 Thread Christoph M. Becker
Hi Andrea! On 10.09.2016 at 01:33, Andrea Faulds wrote: > Christoph M. Becker wrote: > >>> In any case, thanks to some uncaught bugs in dead code, no stable >>> release of PHP 7 has been able to compile with FAST_ZPP disabled anyway, >>> which means I can be ce

Re: [PHP-DEV] Modern practices ...

2016-09-10 Thread Christoph M. Becker
create the same environment > on Windows? I have not yet tried to check out a build stack on Windows > 10, but for the vast majority of PHP users it is not a practical option? Despite the rather common myth, building PHP on Windows nowadays is not really harder than on Linux. Detailed

Re: [PHP-DEV] Modern practices ...

2016-09-11 Thread Christoph M. Becker
On 10.09.2016 at 23:45, Lester Caine wrote: > On 10/09/16 16:41, Christoph M. Becker wrote: > >> Despite the rather common myth, building PHP on Windows nowadays is not >> really harder than on Linux. Detailed instructions are available on >> <https://wik

Re: [PHP-DEV] Modern practices ...

2016-09-12 Thread Christoph M. Becker
On 11.09.2016 at 12:35, Lester Caine wrote: > On 11/09/16 11:05, Christoph M. Becker wrote: > I have already debugged the problems and will tidy up the notes later > when I cross check things. This is the sort of support I've always > provided to the PHP project. The page

[PHP-DEV] Re: pdo_dblib on pecl

2016-09-13 Thread Christoph M. Becker
xml, for instance. Either way, that should also be done for PECL/PDO_SQLITE and PECL/sqlite3. And the out-dated note for PECL/SQLite should be fixed. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: Concept: 7.1 nullable function parameter format ...

2016-09-14 Thread Christoph M. Becker
al of the RFC; > however in future iterations multiple data types could be allowed. > > Gauge initial interest in a alteratio of this type, thanks for your time. There has already been the union type RFC[1], which has recently been declined. [1] <https://wiki.php.net/rfc/union_t

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-25 Thread Christoph M. Becker
set to null" are different things. However, the changelog entry for 5.3.0 states: | NULL became the default value for object, so passing NULL to object | now has the same result as not passing any value. And that's what I would expect when reading the function signature; after all,

Re: [PHP-DEV] [VOTE] get_class() disallow null parameter

2016-09-26 Thread Christoph M. Becker
ot clearly documented. In fact the > manual also says: "If get_class() is called with anything other than > an object, an E_WARNING level error is raised.". I'm pretty sure that > null is not an object, so this RFC actually moves the behaviour closer > to what the manual

[PHP-DEV] Re: [RFC] add radius and sigma to IMG_FILTER_GAUSSIAN_BLUR

2016-09-28 Thread Christoph M. Becker
how, even if we adjust the PHP binding only, the RFC process might not be necessary; instead a PR might be sufficient. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Fwd: [PHP-BUG] Bug #73234 [NEW]: emulated statementslet value dictate parameter type

2016-10-04 Thread Christoph M. Becker
L script is invalid so prepare fails. If it works for dblib > then I would consider THAT the bug. Parameters can only be assigned to > fields identified in the prepared SQL. In this case :null has nothing to > identify what it is to be prepared to populate. This is about *emulated* prepares

Re: [PHP-DEV] Fwd: [PHP-BUG] Bug #73234 [NEW]: emulated statementsletvalue dictate parameter type

2016-10-04 Thread Christoph M. Becker
get PHP 5.6 (unless it would cause a BC break for "reasonably" written code). CCing Matteo, who has expressed that he's willing to have a look on PDO core issues. :-) -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Fwd: [PHP-BUG] Bug #73234 [NEW]: emulated statementslet value dictate parameter type

2016-10-04 Thread Christoph M. Becker
n and verifying that NULL was stored. > > That's not ture. If memory serves, emulated prepares are only available > supported by the mysql and pgsql pdo drivers. If that is so, the docs would be in error, e.g. <http://www.php.net/manual/en/pdo.setattribute.php> states: | PDO::

Re: [PHP-DEV] Fwd: [PHP-BUG] Bug #73234 [NEW]: emulated statementsletvalue dictate parameter type

2016-10-04 Thread Christoph M. Becker
c/blob/master/ext/pdo/pdo_stmt.c#L483 > https://github.com/php/php-src/blob/master/ext/pdo/pdo_stmt.c#L1732 Yes, they *could*, but not all *do*. E.g. (new PDO('sqlite::memory:')) ->setAttribute(PDO::ATTR_EMULATE_PREPARES, true) returns FALSE. Also pdo_sqlite will report

Re: [PHP-DEV] Fwd: [PHP-BUG] Bug #73234 [NEW]: emulated statementsletvalue dictate parameter type

2016-10-04 Thread Christoph M. Becker
uld probably bit the bullet sometime soon and finally disable > it by default on pdo_mysql too. There's already PR #108 suggesting to do so. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: Feature Request: inline pseudo-instruction

2016-10-04 Thread Christoph M. Becker
repare the files before they're compiled by PHP. A rather simple PHP script using preg_replace() might already be sufficient. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: ext/fileinfo/libmagic/apprentice.c", line 2195: error: syntax error

2016-10-05 Thread Christoph M. Becker
*ms, struct magic_entry *me, const > char *line) >2191 { >2192 struct magic *m = &me->mp[0]; >2193 >2194 return parse_extra(ms, me, line, >2195 CAST(off_t, offsetof(struct magic, apple)), >2196 sizeof

[PHP-DEV] Re: [RFC] Bug #72811 - Replacing parse_url()

2016-10-06 Thread Christoph M. Becker
r that'll be released) and switch the implementation of parse_url() then – what might delay the adoption of PHP 8 * add a new function in PHP 7.2 (maybe called parse_uri()), and perhaps deprecate parse_url() at the same time -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] RE: [PHP-CVS] Re: [PHP-DEV] Re: [PHP-CVS] com php-src: Fix dba configuration for Windows: ext/dba/config.w32

2016-10-12 Thread Christoph M. Becker
ttps://github.com/php/php-src/blob/PHP-7.0.12/ext/dba/libflatfile/flatfile.c#L131> -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Merging PHP-5.6 into PHP-7.0 conflicts

2016-10-12 Thread Christoph M. Becker
Hi! It seems there has been an unresolved bad merge. When I attempt an empty merge from PHP-5.6 into PHP-7.0, Git reports 18 conflicting files. Can somebody please have a look at this issue. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit

Re: [PHP-DEV] Merging PHP-5.6 into PHP-7.0 conflicts

2016-10-12 Thread Christoph M. Becker
Hi Anatol! On 12.10.2016 at 16:33, Anatol Belski wrote: >> -Original Message- >> From: Christoph M. Becker [mailto:cmbecke...@gmx.de] >> Sent: Wednesday, October 12, 2016 4:26 PM >> To: PHP Internals >> Subject: [PHP-DEV] Merging PHP-5.6 into PHP-7.0 conf

Re: [PHP-DEV] Merging PHP-5.6 into PHP-7.0 conflicts

2016-10-13 Thread Christoph M. Becker
progress of being > merged. I should have sent a message to internals, but forgot to. I > apologize. Will do so in the future when starting big merges that may > leave the repos in a weird state for a while. Thanks! :-) -- Christoph M. Becker -- PHP Internals - PHP Runtime Development M

Re: [PHP-DEV] [RFC] Bug #72811 - Replacing parse_url()

2016-10-13 Thread Christoph M. Becker
nality conforms to WHATWG's URL standard we have to always apply the latest changes even into revisions, potentially causing BC breaks. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] ext/gd: Deprecate png2wbmp() and jpeg2wbmp()

2016-10-13 Thread Christoph M. Becker
d a cleaner interface. Thoughts? -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] ext/gd: Deprecate png2wbmp() and jpeg2wbmp()

2016-10-13 Thread Christoph M. Becker
On 13.10.2016 at 22:28, Kalle Sommer Nielsen wrote: > 2016-10-13 19:03 GMT+02:00 Christoph M. Becker : > >> I suggest to deprecate png2wbmp() and jpeg2wbmp() as of PHP 7.2 and to >> remove the functions as of PHP 8.0. >> >> Both functions are very special for ext

Re: [PHP-DEV] ext/gd: Deprecate png2wbmp() and jpeg2wbmp()

2016-10-14 Thread Christoph M. Becker
On 14.10.2016 at 00:50, Kalle Sommer Nielsen wrote: > 2016-10-13 23:17 GMT+02:00 Dan Ackroyd : > >> On 13 October 2016 at 18:03, Christoph M. Becker wrote: >> >>> Implementing a fallback in userland would be trivial >> >> You should do that first, and g

Re: [PHP-DEV] IMPORTANT: Git reset after wrong merge

2016-10-14 Thread Christoph M. Becker
be a big help to double check, also > with UPGRADING, NEWS, etc. My commits are in all branches where they are supposed to be. Also NEWS and UPGRADING is correct (I had to re-commit a single NEWS entry). -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsu

[PHP-DEV] Re: lxr.php.net is coming soon.... finally....

2016-10-15 Thread Christoph M. Becker
could need some help there. :-) -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] [RFC] Deprecate png2wbmp() and jpeg2wbmp()

2016-10-15 Thread Christoph M. Becker
Hi! I've create an RFC to deprecate and later remove the png2wbmp() and jpeg2wbmp() functions, and put it under discussion: <https://wiki.php.net/rfc/deprecate-png-jpeg-2wbmp> Comments are appreciated! -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mail

[PHP-DEV] Update to SQLite 3.15.0

2016-10-15 Thread Christoph M. Becker
, both x64, didn't show any regression. [1] <http://news.php.net/php.internals/95009> -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: lxr.php.net is coming soon.... finally....

2016-10-18 Thread Christoph M. Becker
icking on php_info_print_table_row gives | Error: File not found! | | The requested resource is not available That also happens for all other identifiers located in other files that I tried. Don't know what's wrong there. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing

Re: [PHP-DEV] [RFC] Counting of non-countable objects

2016-10-18 Thread Christoph M. Becker
>> action this RFC implies for PHP 8. > > Would it be acceptable for the RFC to state that this has no implications > for PHP 8, and is an indefinite deprecation? In my opinion, an indefinite deprecation doesn't make much sense. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: Bug fix and RFC/Merge rule

2016-10-18 Thread Christoph M. Becker
iscussed and if no consensus can be found, an RFC seems to be the most sensible way to resolve the issue. Until the RFC has been decided upon, (temporarily) reverting the commit also makes sense, in my opinion. :-) -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV] Re: lxr.php.net is coming soon.... finally....

2016-10-18 Thread Christoph M. Becker
gt; directory exists on disk but isn't supposed to be part of the URL. > > hi, yeah, on Tomcat the opengrok app is called source, I've the changed the > settings so now that it works both with and without /source in the url. Works fine now. Thank you very much! -- Christ

[PHP-DEV] Re: [PHP-CVS] com php-src: This is a very very old thing dated backto year 2009. MYSQL_OPT_READ_TIMEOUT was never a macro in mysqlnd but an enumvalue. So this never actually worked correctly

2016-10-20 Thread Christoph M. Becker
php-src.git;a=commitdiff;h=9594e364ed49d575dc27b887a996af10d18577ce >>> >>> Log: >>> This is a very very old thing dated back to year 2009. >>> MYSQL_OPT_READ_TIMEOUT was never a macro in mysqlnd but an enum value. >>> So this never actually w

<    5   6   7   8   9   10   11   12   13   14   >