Hi Andrea! On 07.09.2016 at 17:26, Andrea Faulds wrote:
> Christoph M. Becker wrote: > >> On 04.05.2016 at 18:11, Andrea Faulds wrote: > > This is a fair point. Functions using Fast ZPP have larger code size, > because of aggressive inlining. > > If every function used it, I suppose it might bloat the size of the PHP > binary somewhat. And probably for no good reason. The performance overhead of zend_parse_parameters() can probably be ignored for a lot of functions, and while it is somewhat harder to read, besides it's being space-saving, it is way easier to debug. There are, however, functions that would greatly benefit from using the fast ZPP API (e.g. imagecolorat(), see commit 0bf11d1e), so I'd welcome code reviews regarding (fast) ZPP. > In any case, thanks to some uncaught bugs in dead code, no stable > release of PHP 7 has been able to compile with FAST_ZPP disabled anyway, > which means I can be certain nobody is using it. I have successfully compiled a recent master with FAST_ZPP undefined. While that was with `--disable-all`, I can imagine that some extensions would also compile, so perhaps somebody actually uses that feature. However, even if that is the case, I don't see necessity to do so. -- Christoph M. Becker -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
