On 18/08/2014 18:41, Nikita Popov wrote:
I've opened the vote on the Abstract Syntax Tree RFC:
https://wiki.php.net/rfc/abstract_syntax_tree#vote
After speaking with other members of AFUP (French UG) about this RFC, we
pretty much all agree that a cleaner compilation process is a nice
On Wed, Aug 20, 2014 at 3:41 PM, Levi Morrison wrote:
> On Wed, Aug 20, 2014 at 7:30 AM, Paul Dragoonis
> wrote:
> > On Tue, Aug 19, 2014 at 3:32 AM, Andi Gutmans wrote:
> >
> >> Hi Nikita,
> >>
> >> I reviewed the AST RFC on my way to vote but there was something that
> >> wasn’t clear to me.
On Wed, Aug 20, 2014 at 7:30 AM, Paul Dragoonis wrote:
> On Tue, Aug 19, 2014 at 3:32 AM, Andi Gutmans wrote:
>
>> Hi Nikita,
>>
>> I reviewed the AST RFC on my way to vote but there was something that
>> wasn’t clear to me.
>> This patch introduces some semantic/behavioral changes in addition to
On Wed, Aug 20, 2014 at 2:57 PM, Nikita Popov wrote:
> On Wed, Aug 20, 2014 at 3:30 PM, Paul Dragoonis
> wrote:
>
>> Hi Nikita,
>>
>> I second some of Andi's concerns about behavioural changes, some things
>> working from right-to-left and not left-to-right. Are these things that we
>> can adapt
On Wed, Aug 20, 2014 at 3:30 PM, Paul Dragoonis wrote:
> Hi Nikita,
>
> I second some of Andi's concerns about behavioural changes, some things
> working from right-to-left and not left-to-right. Are these things that we
> can adapt the AST part or tweak another part to make this more consistent
On Tue, Aug 19, 2014 at 3:32 AM, Andi Gutmans wrote:
> Hi Nikita,
>
> I reviewed the AST RFC on my way to vote but there was something that
> wasn’t clear to me.
> This patch introduces some semantic/behavioral changes in addition to the
> AST.
> Are these as a side-effect of how AST was implemen
got it. thanks!
On Aug 18, 2014, at 11:36 PM, Dmitry Stogov wrote:
> Hi Andi,
>
> We already discussed most of semantic changes introduced in AST patch.
> Most of them came from another approved RFC
> https://wiki.php.net/rfc/uniform_variable_syntax
>
> Thanks. Dmitry.
>
>
> On Tue, Aug 19,
On Tue, Aug 19, 2014 at 11:21 AM, Laruence wrote:
> Hey:
>
>the problem came from zend_ast_size for 0 children node..
>
Thanks for the report, this should be fixed now:
https://github.com/nikic/php-src/commit/69f0deb399eec76bc8afa97fa383b08a207582fb
Nikita
On Tue, Aug 19, 2014 at 11:30 AM, Laruence wrote:
> Hey:
>
> a fix could be:
> diff --git a/Zend/zend_ast.c b/Zend/zend_ast.c
> index eb35a51..f738e34 100644
> --- a/Zend/zend_ast.c
> +++ b/Zend/zend_ast.c
> @@ -33,11 +33,11 @@ static inline void *zend_ast_realloc(void *old,
> size_t old_size, s
Hey:
a fix could be:
diff --git a/Zend/zend_ast.c b/Zend/zend_ast.c
index eb35a51..f738e34 100644
--- a/Zend/zend_ast.c
+++ b/Zend/zend_ast.c
@@ -33,11 +33,11 @@ static inline void *zend_ast_realloc(void *old,
size_t old_size, size_t new_size
return new;
}
-size_t zend_ast_size(zend_uint chi
Hey:
the problem came from zend_ast_size for 0 children node..
backtrace:
Program terminated with signal 6, Aborted.
#0 0x0034dc030285 in raise () from /lib64/libc.so.6
(gdb) bt
#0 0x0034dc030285 in raise () from /lib64/libc.so.6
#1 0x0034dc031d30 in abort () from /lib64/lib
Hey:
I find a problem while I was trying play with the patch
Generating phar.php
Generating phar.phar
Fatal error: Out of memory (allocated 786432) at
/home/huixinchen/opensource/github/php-src/Zend/zend_arena.h:69 (tried
to allocate 34359738400 bytes) in
/home/huixinchen/opensource/github/p
Hi Andi,
We already discussed most of semantic changes introduced in AST patch.
Most of them came from another approved RFC
https://wiki.php.net/rfc/uniform_variable_syntax
Thanks. Dmitry.
On Tue, Aug 19, 2014 at 6:32 AM, Andi Gutmans wrote:
> Hi Nikita,
>
> I reviewed the AST RFC on my way t
Hi Nikita,
I reviewed the AST RFC on my way to vote but there was something that wasn’t
clear to me.
This patch introduces some semantic/behavioral changes in addition to the AST.
Are these as a side-effect of how AST was implemented? Or are they unrelated to
the AST patch?
I think some of them
14 matches
Mail list logo
