Hello Matt,
Saturday, July 15, 2006, 2:45:16 PM, you wrote:
> Hi Marcus,
> - Original Message -
> From: "Marcus Boerger"
>> Hello Matt,
>>
>> thanks for the update
>>
>> best regards
>> marcus
> No problem, but...
> HEAD looks good now (meaning how you guys want it), but there's a
Hi Marcus,
- Original Message -
From: "Marcus Boerger"
> Hello Matt,
>
> thanks for the update
>
> best regards
> marcus
No problem, but...
HEAD looks good now (meaning how you guys want it), but there's an issue
with 5.2 -- fill and fill_keys will handle "val" passed by reference
d
Hello Matt,
thanks for the update
best regards
marcus
Saturday, July 15, 2006, 1:25:25 PM, you wrote:
> Hi Marcus,
> - Original Message -
> From: "Marcus Boerger"
>> Hello Matt,
>>
>> Thursday, July 13, 2006, 12:28:27 PM, you wrote:
>>
>> There's two ways. First as you mentioned s
Hi Marcus,
- Original Message -
From: "Marcus Boerger"
> Hello Matt,
>
> Thursday, July 13, 2006, 12:28:27 PM, you wrote:
>
> There's two ways. First as you mentioned sending them as plain text files.
> And second editing the CVS/Entries file in that directory and adding this
> line: "/
Hello Matt,
Thursday, July 13, 2006, 12:28:27 PM, you wrote:
> Hi Marcus,
> - Original Message -
> From: "Marcus Boerger"
>> Hello Matt,
>>
>> Tuesday, July 11, 2006, 10:54:05 AM, you wrote:
>>
>> > Hi Marcus,
>>
>> > I'm replying again for clarification about the patch. When you fir
Hi Marcus,
- Original Message -
From: "Marcus Boerger"
> Hello Matt,
>
> Tuesday, July 11, 2006, 10:54:05 AM, you wrote:
>
> > Hi Marcus,
>
> > I'm replying again for clarification about the patch. When you first
> > replied and said it looked OK, you mentioned "once we agree to this,"
ROTECTED]>
To: "'Matt W'" <[EMAIL PROTECTED]>;
Sent: Tuesday, July 11, 2006 4:42 PM
Subject: RE: [PHP-DEV] [PATCH] array_fill: Allow an array to specify keys
> I don't have a problem with the functionality and the patch doesn't seem
> problematic.
>
I don't have a problem with the functionality and the patch doesn't seem
problematic.
I do question though whether we want to add this to array_fill()? Not sure
if that parameter overloading is very intuitive as it doesn't just add one
parameter. What do others think? Would you prefer an array_fill
Hello Matt,
Tuesday, July 11, 2006, 10:54:05 AM, you wrote:
> Hi Marcus,
> I'm replying again for clarification about the patch. When you first
> replied and said it looked OK, you mentioned "once we agree to this," which
> I assumed meant it could be used/committed. I saw array.c hasn't been
Hi Marcus,
I'm replying again for clarification about the patch. When you first
replied and said it looked OK, you mentioned "once we agree to this," which
I assumed meant it could be used/committed. I saw array.c hasn't been
changed in CVS (though I don't know when that would happen anyway), so
Hello Matt,
in general we only require head first and once that is in we discuss
merging the stuff to older versons (in this case 5.2). Tests have not
always been required but it has shown that we introduce to many changes
this way. So we more and more develop with tests. Especially when there
i
Hi Marcus,
Thanks for the info. I'm sending along the patch for 5.2 now, since I
didn't know whether to wait until the MAIN patch was agreed to (that's what
I got from your message), or if you wanted both first. :-)
I didn't realize tests were needed for every function, change, etc. (being
new a
Hello Matt,
patch looks fine now, once we agree to this set you'd have to provide
a patch for 5.2 as well. Another thing we need is tests to ensure all
is working as expected.
best regards
marcus
Saturday, July 1, 2006, 12:30:48 PM, you wrote:
> Index: ext/standard/array.c
> =
Hi all,
I didn't receive any feedback about the first patch I sent (against
PHP_5_1), but have since realized that I should just use the MAIN branch, is
that correct? Will someone then take care of backporting to older versions
if needed...? (Also, from looking at http://cvs.php.net it looks lik
14 matches
Mail list logo
