Hello Matt, in general we only require head first and once that is in we discuss merging the stuff to older versons (in this case 5.2). Tests have not always been required but it has shown that we introduce to many changes this way. So we more and more develop with tests. Especially when there is a change in an untested area it is very good to test against old documented behavior first and then see what changes with the patch. For the tests themselves we not test for every error situation but we test for a lot.
best regards marcus Wednesday, July 5, 2006, 11:25:14 AM, you wrote: > Hi Marcus, > Thanks for the info. I'm sending along the patch for 5.2 now, since I > didn't know whether to wait until the MAIN patch was agreed to (that's what > I got from your message), or if you wanted both first. :-) > I didn't realize tests were needed for every function, change, etc. (being > new at this, sorry). And I don't see any tests for the current > array_fill()... Anyway, if I need to make a test, how thorough should it > be? Should all error messages be checked also, or not, since the message > text may change in the future? > Are tests needed before the patches will get committed? (Assuming they're > agreed to, of course.) ;-) Again, don't know how long that takes either... > Thanks, > Matt > ----- Original Message ----- > From: "Marcus Boerger" <[EMAIL PROTECTED]> >> Hello Matt, >> >> patch looks fine now, once we agree to this set you'd have to provide >> a patch for 5.2 as well. Another thing we need is tests to ensure all >> is working as expected. Best regards, Marcus -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
