Hi Marcus, ----- Original Message ----- From: "Marcus Boerger"
> Hello Matt, > > Tuesday, July 11, 2006, 10:54:05 AM, you wrote: > > > Hi Marcus, > > > I'm replying again for clarification about the patch. When you first > > replied and said it looked OK, you mentioned "once we agree to this," which > > I assumed meant it could be used/committed. I saw array.c hasn't been > > changed in CVS (though I don't know when that would happen anyway), so I was > > kinda wondering, that's all. :-) > > Well a common problem, you would probably get feedback if you would commit > it. Since you don't have CVS rights somebody else needs to do that job but > risks to get blamed...so you need to find more people that have interest > in your patch. Heh, understandable. Can anyone like me get a CVS account if we request it? (I see those request messages often...) Or do you have to be more "known?" :-) Well, even with rights, I'd want to verify a change was OK beforehand -- it sounds like you're saying stuff should be commited *first* and then feedback comes... > > Then about the tests, I still didn't know whether you'd tell me to make a > > tests file *after* committing the patch or if you need it *first*. Sorry. > > :-/ > > First of course. You can do "cvs add ext/standard/tests/array_xyz.phpt" to > add your new test file "array_xyz.phpt" virtually to cvs. After that you > can regenerate the patch with "cvs di -updN" where -N ensures that those > tests go into the patch. Well, I just tried to use (with WinCvs) "cvs add ..." and it said: "add" requires write access to the repository :-( > > If you (meaning anyone who'd apply the patch) are just waiting for tests, > > please let me know, and I'll create tests for all array_fill() functionality > > (old and new) right away! > > > BTW, since sending the patches, I realized that my code will allow an empty > > "keys" array. I'm thinking there should be a warning for that to make it > > consistent with the old behavior of not returning an empty array. Should I > > change that and RE-send patches...? > > Yep, do so please. I created array_fill_keys() instead after seeing Andi's e-mail questioning the array_fill() modification, and made a few simple tests for it (I see array_fill tests were recently added). So, it's all ready to go, but I can't add the test file... What should I do, e-mail it as a plain file? > Best regards, > Marcus Thanks for your help, Matt -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
