:12 PM
To: Dmitry Stogov; 'Frank M. Kromann'; Andi Gutmans
Cc: 'internals'; 'Antony Dovgal'; 'Xuefer'
Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
Hi Andi,
>I don't understand this patch. Doesn't this completely
remove printing
>m
;Frank M. Kromann'; Andi Gutmans
> Cc: 'internals'; 'Antony Dovgal'; 'Xuefer'
> Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
>
>
> Hi Andi,
>
> >I don't understand this patch. Doesn't this completely
> remove printing
al Message-
> From: Andi Gutmans [mailto:[EMAIL PROTECTED]
> Sent: Friday, June 02, 2006 10:08 PM
> To: Dmitry Stogov; 'Steph Fox'; 'Frank M. Kromann'
> Cc: 'internals'; 'Antony Dovgal'; 'Xuefer'
> Subject: RE: [PHP-DEV] tsrm_shut
01, 2006 10:29 AM
> To: Steph Fox; Frank M. Kromann
> Cc: 'internals'; 'Antony Dovgal'; Dmitry Stogov; 'Xuefer'
> Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
>
>
> As we are not planning to release a new version within the next
> couple o
ch in 24h.
Any objections?
Thanks. Dmitry.
> -Original Message-
> From: Andi Gutmans [mailto:[EMAIL PROTECTED]
> Sent: Thursday, June 01, 2006 10:29 AM
> To: Steph Fox; Frank M. Kromann
> Cc: 'internals'; 'Antony Dovgal'; Dmitry Stogov; 'Xuefer'
;
Cc: "'internals'" ; "'Antony Dovgal'"
<[EMAIL PROTECTED]>
Sent: Friday, June 02, 2006 8:11 AM
Subject: RE: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
I am working in this way, but this willnot help you with php-gtk for
php-5.1
Dmitry.
-Orig
nternals'; 'Antony Dovgal'
> Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
>
>
> I already wasted several hours on that :)
>
> I agree that making it work from inside zend_shutdown would
> be the smart
> approach, but don't see why you thin
GLOBAL_CLASS_TABLE
and the compiler_globals->class_table is destroyed and freed because of
that.
- Steph
- Original Message -
From: "Dmitry Stogov" <[EMAIL PROTECTED]>
To: "'Steph Fox'" <[EMAIL PROTECTED]>
Cc: "'internals'
On Thu, June 1, 2006 12:21 am, Frank M. Kromann wrote:
>> Fine, but breaking working code while you're trying to understand
>> what's
>
>> happening is far from beneficial to our users. Can't we at least #0
>> it?
>
> There is no need to break code. The shutdown function was commented
> out
> for a
m: "Dmitry Stogov" <[EMAIL PROTECTED]>
To: "'Steph Fox'" <[EMAIL PROTECTED]>
Cc: "'internals'"
Sent: Thursday, June 01, 2006 1:25 PM
Subject: RE: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
Patch was cutted.
Dmitry.
-Original
ts_free_id() would be a correct workaround if it came from
zend_shutdown().
How's it right to suddenly force EVERY extension author to add it to
their
code individually?
This was only reqiured in extensions registering custom dtor's like tidy
and printer.
Unfortunately that's not true. It's
Stogov" <[EMAIL PROTECTED]>
To: "'Steph Fox'" <[EMAIL PROTECTED]>; "'Xuefer'" <[EMAIL PROTECTED]>; "'Andi
Gutmans'" <[EMAIL PROTECTED]>
Cc: "'internals'" ; "'Antony Dovgal'&quo
mann'" <[EMAIL PROTECTED]>
Cc: "'internals'" ; "'Antony Dovgal'"
<[EMAIL PROTECTED]>; "'Xuefer'" <[EMAIL PROTECTED]>
Sent: Thursday, June 01, 2006 1:05 PM
Subject: RE: [PHP-DEV] tsrm_shutdown() and the CLI
y Dovgal'"
<[EMAIL PROTECTED]>; "Dmitry Stogov" <[EMAIL PROTECTED]>; "'Xuefer'"
<[EMAIL PROTECTED]>
Sent: Thursday, June 01, 2006 8:28 AM
Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
As we are not planning to release a new version
Patch was cutted.
Dmitry.
> -Original Message-
> From: Dmitry Stogov [mailto:[EMAIL PROTECTED]
> Sent: Thursday, June 01, 2006 3:05 PM
> To: 'Andi Gutmans'; 'Steph Fox'; 'Frank M. Kromann'
> Cc: 'internals'; 'Antony Dovgal
ns?
Thanks. Dmitry.
> -Original Message-
> From: Andi Gutmans [mailto:[EMAIL PROTECTED]
> Sent: Thursday, June 01, 2006 10:29 AM
> To: Steph Fox; Frank M. Kromann
> Cc: 'internals'; 'Antony Dovgal'; Dmitry Stogov; 'Xuefer'
> Subject: R
6 8:48 AM
> To: Dmitry Stogov; 'Xuefer'; Andi Gutmans
> Cc: 'internals'; Antony Dovgal
> Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
>
>
> > I'm a bit behind so sorry if this has been answered
> already. I don't
> > think
&
As we are not planning to release a new version within the next
couple of weeks, I suggest before jumping to conclusions we take a look at it.
If you really need to comment out that line in the meanwhile that's OK with me.
Andi
At 09:50 PM 5/31/2006, Steph Fox wrote:
Yes, it would, given the r
> >>Yes, it would, given the root cause - but would you really want to
break
> >>the whole of PHP for an academic exercise?
> >
> > It's not really an academic exercise. If we know there's a bug
someplace
> > we should at least look into it and try and understand it.
>
> Frank's referring to Z
> > I'm a bit behind so sorry if this has been answered already. I don't
think
> > ts_free_id() is a workaround but it's actually correct.
>
> ts_free_id() would be a correct workaround if it came from
zend_shutdown().
> How's it right to suddenly force EVERY extension author to add it to
thei
Yes, it would, given the root cause - but would you really want to break
the whole of PHP for an academic exercise?
It's not really an academic exercise. If we know there's a bug someplace
we should at least look into it and try and understand it.
Frank's referring to Zeev's three-years-ago d
I'm a bit behind so sorry if this has been answered already. I don't think
ts_free_id() is a workaround but it's actually correct.
ts_free_id() would be a correct workaround if it came from zend_shutdown().
How's it right to suddenly force EVERY extension author to add it to their
code individ
At 08:23 AM 5/31/2006, Steph Fox wrote:
Hi Frank,
tsrm_shutdown() is already comented out in the CGI version, most likely as
a fix to the same kind of problem there. Perhaps enabling that again will
show the same kind of problems?
Yes, it would, given the root cause - but would you really wan
At 04:28 AM 5/31/2006, Steph Fox wrote:
Probably some other bug that is the reason of the crash was masked by
omitting FreeLibrary().
I know Tony fixed some kind of such bugs in ext/tidy and ext/sybase.
Yes, he gave those extensions the ts_free_id() workaround I
mentioned a looong time
Hi Steph,
Yes, it would, given the root cause - but would you really want to break
the
whole of PHP for an academic exercise?
Changing the code locally just to test and see if it gave another clude to
the problem would be my approach :-)
I don't need to... the current problem's bleedin' ob
Hi Steph,
> Yes, it would, given the root cause - but would you really want to break
the
> whole of PHP for an academic exercise?
Changing the code locally just to test and see if it gave another clude to
the problem would be my approach :-)
- Frank
--
PHP Internals - PHP Runtime Development
Hi Frank,
tsrm_shutdown() is already comented out in the CGI version, most likely as
a fix to the same kind of problem there. Perhaps enabling that again will
show the same kind of problems?
Yes, it would, given the root cause - but would you really want to break the
whole of PHP for an acade
gt;
> > Do you know any other extension from PHP distribution that cause the
same
> > crash?
> > Could you provide instruction how to reproduce it?
> >
> > Thanks. Dmitry.
> >
> >> -Original Message-
> >> From: Steph Fox [mailto:[EMAIL PRO
]>; "'Andi
Gutmans'" <[EMAIL PROTECTED]>
Cc: "'internals'" ; "'Antony Dovgal'"
<[EMAIL PROTECTED]>
Sent: Wednesday, May 31, 2006 2:55 PM
Subject: RE: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
Steph,
Commenting tsrm_shu
x27;Xuefer'; 'Andi Gutmans'
> Cc: 'internals'; Antony Dovgal
> Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
>
>
> > Oh well, now I see the difference.
> > With my patch PHP starts call FreeLibrary() for dll extension. I am
> > wonder wh
Oh well, now I see the difference.
With my patch PHP starts call FreeLibrary() for dll extension.
I am wonder why it wasn't called before. :)
Pure luck, by the look of it :)
Probably some other bug that is the reason of the crash was masked by
omitting FreeLibrary().
I know Tony fixed some kin
On 31.05.2006 15:19, Dmitry Stogov wrote:
Oh well, now I see the difference.
With my patch PHP starts call FreeLibrary() for dll extension.
I am wonder why it wasn't called before. :)
Probably some other bug that is the reason of the crash was masked by
omitting FreeLibrary().
I know Tony fixed
ks. Dmitry.
> -Original Message-
> From: Steph Fox [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, May 31, 2006 2:38 PM
> To: Xuefer; Andi Gutmans; Dmitry Stogov
> Cc: internals
> Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
>
>
> C:\sandbox\php5\Zend>grep -l -drecu
-
From: "Steph Fox" <[EMAIL PROTECTED]>
To: "Xuefer" <[EMAIL PROTECTED]>; "Andi Gutmans" <[EMAIL PROTECTED]>
Cc: "internals"
Sent: Wednesday, May 31, 2006 9:28 AM
Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
Fixing the
istory and mechanics.
It's a pig.
- Steph
- Original Message - From: "Xuefer" <[EMAIL PROTECTED]>
To: "Steph Fox" <[EMAIL PROTECTED]>
Cc: "internals"
Sent: Sunday, May 28, 2006 4:58 AM
Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
g to track down its history and mechanics.
It's a pig.
- Steph
- Original Message - From: "Xuefer" <[EMAIL PROTECTED]>
To: "Steph Fox" <[EMAIL PROTECTED]>
Cc: "internals"
Sent: Sunday, May 28, 2006 4:58 AM
Subject: Re: [PHP-DEV] tsrm_s
eph Fox" <[EMAIL PROTECTED]>
Cc: "internals"
Sent: Sunday, May 28, 2006 4:58 AM
Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI
i can confirm this on other extension.
something like this
grep free_id */*.c -B1 -A3
mbstring/mbstring.c-#ifdef ZTS
mbstring/mbstring.c:ts_fre
i can confirm this on other extension.
something like this
grep free_id */*.c -B1 -A3
mbstring/mbstring.c-#ifdef ZTS
mbstring/mbstring.c:ts_free_id(mbstring_globals_id);
mbstring/mbstring.c-#else
mbstring/mbstring.c-_php_mb_globals_dtor(&mbstring_globals TSRMLS_CC);
mbstring/mbstring.c-#en
Under CLI ZTS build, when loading a PHP-GTK 2 .dll built against anything
this side of PHP 5.1.2 release, I'm seeing an 'access violation' crash on
reaching:
if (resource_types_table && !resource_types_table[j].done &&
resource_types_table[j].dtor) {
resource_types_table[j].dtor
39 matches
Mail list logo
