Steph, Commenting tsrm_shutdown() or FreeLibrary() is just hidding real bugs. Of course this is a solution, but not excellent.
Right now I haven't enough time even for ZE and PHP themself, so I don't like spent it looking into php-gtk on windows. (I don't know GTK at all). Do you know any other extension from PHP distribution that cause the same crash? Could you provide instruction how to reproduce it? Thanks. Dmitry. > -----Original Message----- > From: Steph Fox [mailto:[EMAIL PROTECTED] > Sent: Wednesday, May 31, 2006 3:28 PM > To: Dmitry Stogov; 'Xuefer'; 'Andi Gutmans' > Cc: 'internals'; Antony Dovgal > Subject: Re: [PHP-DEV] tsrm_shutdown() and the CLI SAPI > > > > Oh well, now I see the difference. > > With my patch PHP starts call FreeLibrary() for dll extension. I am > > wonder why it wasn't called before. :) > > Pure luck, by the look of it :) > > > Probably some other bug that is the reason of the crash was > masked by > > omitting FreeLibrary(). I know Tony fixed some kind of such bugs in > > ext/tidy and ext/sybase. > > Yes, he gave those extensions the ts_free_id() workaround I > mentioned a > looooooooooong time ago when I first started looking into this. > > > Probably php-gtk needs similar fix. > > That workaround didn't work for PHP-GTK. I tried that first. > That's why I > need you to fix this bug rather than me just cover it up. The > only thing > that works for PHP-GTK is to either avoid tsrm_shutdown() > completely (via > Zeev's suggestion of commenting out the call in php_cli.c), > or to fix the > bug that makes reaching it a problem. > > > All other systems except win32 already used common config > file, and I > > don't > > see any reason for this exceptions. > > I don't know or care what other systems do... how's that even > relevant? > > > Especially because it was the reason of bug, and masked other bugs > > that > > may > > be reproduced on linux with ZTS. > > Sorry, I didn't parse that... can you rephrase? > > > > Thanks. Dmitry. > > Cheers, > - Steph > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
