On Sun, Jan 4, 2015 at 2:21 PM, Derick Rethans wrote:
> On Fri, 2 Jan 2015, Sara Golemon wrote:
>
> >
> > > It was deliberate, I did it. The reason for getting rid of it was
> because it makes checking ZE2 simpler, actually. I didn't want to have to
> do #if defined(ZEND_ENGINE_2) && !defined(ZEN
On Fri, 2 Jan 2015, Sara Golemon wrote:
>
> > It was deliberate, I did it. The reason for getting rid of it was because
> > it makes checking ZE2 simpler, actually. I didn't want to have to do #if
> > defined(ZEND_ENGINE_2) && !defined(ZEND_ENGINE_3).
> >
> So instead you have to do:
> #if def
On Fri, Jan 2, 2015 at 2:30 PM, Kalle Sommer Nielsen wrote:
> 2015-01-02 20:41 GMT+01:00 Sara Golemon :
>> So instead you have to do:
>> #if defined(ZEND_ENGINE_2) || defined(ZEND_ENGINE_3)
>>
>
> #ifdef ZEND_ENGINE_3
> # define ZEND_ENGINE_2
> #endif
>
Yeah, obviously I can do that. I'm not actu
2015-01-02 20:41 GMT+01:00 Sara Golemon :
> So instead you have to do:
> #if defined(ZEND_ENGINE_2) || defined(ZEND_ENGINE_3)
>
#ifdef ZEND_ENGINE_3
# define ZEND_ENGINE_2
#endif
in php_ext.h, like we had the following for 5.2 compatibles:
#if PHP_VERSION_ID < 503000
# define zend_parse_parameter
> It was deliberate, I did it. The reason for getting rid of it was because it
> makes checking ZE2 simpler, actually. I didn't want to have to do #if
> defined(ZEND_ENGINE_2) && !defined(ZEND_ENGINE_3).
>
So instead you have to do:
#if defined(ZEND_ENGINE_2) || defined(ZEND_ENGINE_3)
But cool
Hey Sara,
> On 2 Jan 2015, at 05:24, Sara Golemon wrote:
>
> I realize that ZE3 is not ZE2, but I always saw the ZEND_ENGINE_2
> define as more of a "At least ZE2" so that code of the form:
>
> #ifdef ZEND_ENGINE_2
> newAPI();
> #else /* ZE1 */
> oldAPI();
> #endif
>
> Would continue making
On Jan 2, 2015 12:24 PM, "Sara Golemon" wrote:
>
> I realize that ZE3 is not ZE2, but I always saw the ZEND_ENGINE_2
> define as more of a "At least ZE2" so that code of the form:
>
> #ifdef ZEND_ENGINE_2
> newAPI();
> #else /* ZE1 */
> oldAPI();
> #endif
>
> Would continue making sense (modul
I realize that ZE3 is not ZE2, but I always saw the ZEND_ENGINE_2
define as more of a "At least ZE2" so that code of the form:
#ifdef ZEND_ENGINE_2
newAPI();
#else /* ZE1 */
oldAPI();
#endif
Would continue making sense (modulo newNewAPI() in ZE3, of course).
Was the ZEND_ENGINE_2 define remo
