On Sun, Jan 4, 2015 at 2:21 PM, Derick Rethans <der...@php.net> wrote:
> On Fri, 2 Jan 2015, Sara Golemon wrote: > > > > > > It was deliberate, I did it. The reason for getting rid of it was > because it makes checking ZE2 simpler, actually. I didn't want to have to > do #if defined(ZEND_ENGINE_2) && !defined(ZEND_ENGINE_3). > > > > > So instead you have to do: > > #if defined(ZEND_ENGINE_2) || defined(ZEND_ENGINE_3) > > > > But cool, kind of arbitrary either way, so it's all good. > > I'm rather more of a fan to actually do: > > #if PHP_VERSION_ID >= 70000 instead anyway.... > Yeah, same to me. I'm used to using something like this : https://github.com/jpauli/symfony/blob/eventdispatcher_ext/src/Symfony/Component/EventDispatcher/Resources/ext/sensiolabs_php_compat.h#L23 Julien
