On Fri, Jan 2, 2015 at 2:30 PM, Kalle Sommer Nielsen <ka...@php.net> wrote: > 2015-01-02 20:41 GMT+01:00 Sara Golemon <p...@golemon.com>: >> So instead you have to do: >> #if defined(ZEND_ENGINE_2) || defined(ZEND_ENGINE_3) >> > > #ifdef ZEND_ENGINE_3 > # define ZEND_ENGINE_2 > #endif > Yeah, obviously I can do that. I'm not actually an idiot, I just disagree on which of two arbitrary choices seems more obvious.
And since we're pasting unnecessary pieces of obvious code, we could as easily do: #ifdef ZEND_ENGINE_3 # undef ZEND_ENGINE_2 #endif Which leaves the decision to make the macros exclusive of each other an arbitrary one. Just as making them inclusive would have been equally arbitrary. But thank you for the unnecessary piece of obvious code. -Sara -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
