Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-21 Thread Hans Henrik Bergan
@Rowan Tommins >I think I'd prefer to drop the fluent interface (returning void on most > things, and relevant values on others) well both approaches has pros and cons, that said, the sample implementation Sara posted returns $this, if you (or anyone) feels strongly about it one way or the othe

Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-16 Thread Sara Golemon
On Tue, Oct 13, 2020 at 12:04 PM Sara Golemon wrote: > On Tue, Oct 13, 2020 at 11:42 AM Christoph M. Becker > wrote: > >> >> > Happy to co-author an RFC with you if you'd like to get involved >> directly, >> > or I can just pick up the ball and run with it if you'd rather make the >> > feature r

Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-13 Thread Sara Golemon
On Tue, Oct 13, 2020 at 11:42 AM Christoph M. Becker wrote: > > > Happy to co-author an RFC with you if you'd like to get involved > directly, > > or I can just pick up the ball and run with it if you'd rather make the > > feature request then step back. > > Please go with this, if you like. Not

Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-13 Thread Christoph M. Becker
On 13.10.2020 at 18:01, Sara Golemon wrote: > On Mon, Oct 12, 2020 at 7:55 AM Christoph M. Becker > wrote: >> >> On 12.10.2020 at 13:49, Hans Henrik Bergan wrote: >> >>> something like >>> >>> $result = (new > HashContext("SHA1"))->update($str1)->update($str2)->final(); >>> >>> (userland sample i

Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-13 Thread Sara Golemon
On Mon, Oct 12, 2020 at 7:55 AM Christoph M. Becker wrote: > > On 12.10.2020 at 13:49, Hans Henrik Bergan wrote: > > > something like > > > > $result = (new HashContext("SHA1"))->update($str1)->update($str2)->final(); > > > > (userland sample imp: https://3v4l.org/lXd3u ) > > > > I tried asking on

Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-13 Thread Rowan Tommins
On Tue, 13 Oct 2020 at 16:33, Hans Henrik Bergan wrote: > also the sample class in the 3v4l link has an issue i hadn't thought > of: i wanted to support method chaining, so i made nearly everything > return `:self` , but hash_update_stream() returns int, the number of > bytes actually read from t

Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-13 Thread Hans Henrik Bergan
PS there might be some good reason for the hash_final() api really being final that i'm not aware of (not that i'm aware of any reason at all, pun not intended) also the sample class in the 3v4l link has an issue i hadn't thought of: i wanted to support method chaining, so i made nearly everything

Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-13 Thread Rowan Tommins
On Tue, 13 Oct 2020 at 10:43, Hans Henrik Bergan wrote: > i know this is unrelated to the thread at hand, but am i really > supposed to find the email of everyone who has replied to a thread, > and add them all manually to cc? > Nope, just the mailing list address should be fine; everyone sendi

Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-13 Thread Hans Henrik Bergan
i know this is unrelated to the thread at hand, but am i really supposed to find the email of everyone who has replied to a thread, and add them all manually to cc? (or is it sufficient to just send it to intern...@list.php.net ? ) (also funfact, it seems if you regex the innerHTML after opening an

Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-12 Thread Rowan Tommins
On Mon, 12 Oct 2020 at 15:20, G. P. B. wrote: > Therefore I am not sure what composer and a userland package can bring... > As an example of this general approach, the MongoDB extension provides a minimal set of low-level "driver" functionality, and the official userland package builds on top o

Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-12 Thread G. P. B.
On Mon, 12 Oct 2020 at 15:01, Kingsquare.nl - Robin Speekenbrink < ro...@kingsquare.nl> wrote: > Op ma 12 okt. 2020 om 14:55 schreef Christoph M. Becker >: > > > On 12.10.2020 at 13:49, Hans Henrik Bergan wrote: > > > > > something like > > > > > > $result = (new > > HashContext("SHA1"))->update(

Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-12 Thread Kingsquare.nl - Robin Speekenbrink
Op ma 12 okt. 2020 om 14:55 schreef Christoph M. Becker : > On 12.10.2020 at 13:49, Hans Henrik Bergan wrote: > > > something like > > > > $result = (new > HashContext("SHA1"))->update($str1)->update($str2)->final(); > > > > (userland sample imp: https://3v4l.org/lXd3u ) > > > > I tried asking on

[PHP-DEV] Re: want an Object-oriented interface for HashContext

2020-10-12 Thread Christoph M. Becker
On 12.10.2020 at 13:49, Hans Henrik Bergan wrote: > something like > > $result = (new HashContext("SHA1"))->update($str1)->update($str2)->final(); > > (userland sample imp: https://3v4l.org/lXd3u ) > > I tried asking on the bugtracker ( https://bugs.php.net/bug.php?id=80221 ) , > but was told to a