@Rowan Tommins >I think I'd prefer to drop the fluent interface (returning void on most > things, and relevant values on others)
well both approaches has pros and cons, that said, the sample implementation Sara posted returns $this, if you (or anyone) feels strongly about it one way or the other, i guess the php devs can vote on it @Sara Golemon thanks! (and you're the original pecl hash author, neat) given the "PHP8 release manager" thing, i guess you have a lot of other PHP8 stuff to focus on right now > Happy to co-author an RFC with you if you'd like to get involved directly, or > I can just pick up the ball and run with it if you'd rather make the feature > request then step back. stepping back sounds good to me, i have no idea how to do any of that stuff ^^ > No reply from Hans, so I've thrown together an implementation and will attach > an RFC to it in the coming days. > https://github.com/php/php-src/pull/6347 looks great to me, and you even took care of the hash_update_stream return value issue ^^ On Sat, 17 Oct 2020 at 04:52, Sara Golemon <poll...@php.net> wrote: > > On Tue, Oct 13, 2020 at 12:04 PM Sara Golemon <poll...@php.net> wrote: >> >> On Tue, Oct 13, 2020 at 11:42 AM Christoph M. Becker <cmbecke...@gmx.de> >> wrote: >>> >>> >>> > Happy to co-author an RFC with you if you'd like to get involved directly, >>> > or I can just pick up the ball and run with it if you'd rather make the >>> > feature request then step back. >>> >>> Please go with this, if you like. Note that I didn't make the feature >>> request; I just support it. :) >>> >> >> Sorry for confusion. That part of my reply was aimed at Hans, but I didn't >> have his original message in my thread to reply to. :p >> > > No reply from Hans, so I've thrown together an implementation and will attach > an RFC to it in the coming days. > https://github.com/php/php-src/pull/6347 > > -Sara -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: https://www.php.net/unsub.php
