[PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow

2014-12-12 Thread Andrea Faulds
> On 2 Dec 2014, at 21:44, Andrea Faulds wrote: > > Good evening once again, > > I’m putting the ZPP Failure on Overflow RFC to a vote. This RFC is an > important prerequisite to the Big Integer Support RFC, as it ensures safety > in implicit integer parameter conversions. > > The RFC requir

Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow

2014-12-09 Thread Rowan Collins
Andrea Faulds wrote on 09/12/2014 14:10: On 9 Dec 2014, at 13:23, Rowan Collins wrote: Xinchen Hui wrote on 09/12/2014 03:39: but I suggest change it to "expects parameter 1 to be long, double(which is beyond long range) given in %s on line %d" Note that in master, the messages have been chan

Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow

2014-12-09 Thread Andrea Faulds
> On 9 Dec 2014, at 13:23, Rowan Collins wrote: > > Xinchen Hui wrote on 09/12/2014 03:39: >> but I suggest change it to "expects parameter 1 to be long, >> double(which is beyond long range) given in %s on line %d" > > Note that in master, the messages have been changed to (correctly) not > m

Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow

2014-12-09 Thread Rowan Collins
Xinchen Hui wrote on 09/12/2014 03:39: but I suggest change it to "expects parameter 1 to be long, double(which is beyond long range) given in %s on line %d" Note that in master, the messages have been changed to (correctly) not mention the C types, only the PHP ones, so it would be more like

Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow

2014-12-09 Thread Andrea Faulds
Hi! > On 9 Dec 2014, at 03:39, Xinchen Hui wrote: > > Hey: > that will confuse people, why 12.2 is okey (it's also a double value). > > anyway, I am not a native english speaker, not sure what is the most > proper warning message. > > but I suggest change it to "expects parameter 1 to be long

Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow

2014-12-08 Thread Xinchen Hui
Hey: On Mon, Dec 8, 2014 at 7:15 PM, Andrea Faulds wrote: > >> On 8 Dec 2014, at 08:22, Xinchen Hui wrote: > >> the current warning message is :" expects parameter 1 to be long, >> double given in %s on line %d" >> >> but maybe it should be something like: "expects parameter 1 to be >> long, dou

Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow

2014-12-08 Thread Andrea Faulds
> On 8 Dec 2014, at 06:24, Joe Watkins wrote: > > Morning Andrea, > >I think it's okay to assume that people are winding down for the > holiday, possibly some people are already on holiday. > >Because of the time of year, you might want to leave the vote open > another week, or until t

Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow

2014-12-08 Thread Andrea Faulds
> On 8 Dec 2014, at 08:22, Xinchen Hui wrote: > the current warning message is :" expects parameter 1 to be long, > double given in %s on line %d" > > but maybe it should be something like: "expects parameter 1 to be > long, double(which is beyond long range) given in %s on line %d"? > > since

Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow

2014-12-08 Thread Xinchen Hui
Hey: On Mon, Dec 8, 2014 at 6:03 AM, Andrea Faulds wrote: > > Hi! > > We’re now half-way through voting on this RFC, and only three people, two if > I’m excluded, have voted. I realise it’s a rather technical and obscure > matter, but I am a little worried by how few people have voted so far.

Re: [PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow

2014-12-07 Thread Joe Watkins
On Sun, 2014-12-07 at 22:03 +, Andrea Faulds wrote: > Hi! > > We’re now half-way through voting on this RFC, and only three people, two if > I’m excluded, have voted. I realise it’s a rather technical and obscure > matter, but I am a little worried by how few people have voted so far. Three

[PHP-DEV] Re: [VOTE][RFC] ZPP Failure on Overflow

2014-12-07 Thread Andrea Faulds
Hi! We’re now half-way through voting on this RFC, and only three people, two if I’m excluded, have voted. I realise it’s a rather technical and obscure matter, but I am a little worried by how few people have voted so far. Three votes is hardly enough to justify a change. If you missed the o