Hi!

> On 9 Dec 2014, at 03:39, Xinchen Hui <larue...@php.net> wrote:
> 
> Hey:

> that will confuse people, why 12.2 is okey (it's also a double value).
> 
> anyway, I am not a native english speaker, not sure what is the most
> proper warning message.
> 
> but I suggest change it to "expects parameter 1 to be long,
> double(which is beyond long range) given in %s on line %d"
> 
> what do you think?

I realise the behaviour is somewhat confusing, but we also do this for other 
parameter parsing failures and I don't have the time to go through and change 
all the tests again, unfortunately. I'd also need to change how error messages 
are produced for fast parameter parsing.

Thanks.
--
Andrea Faulds
http://ajf.me/


--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to