Re: [PHP-DEV] Big patch for FPM (config and initialization)

2011-07-04 Thread Jérôme Loyet
> Detailed changelog of the patch: > - Renamed options "pm.status_path", "ping.path", "ping.response" into > a new logical group "diagnostics", so they are now respectively: >     "diagnostics.status_path", "diagnostics.ping_path", > "diagnostics.ping_response". See my feelings on a previous mail.

Re: [PHP-DEV] Big patch for FPM (config and initialization)

2011-07-04 Thread Jérôme Loyet
2011/7/3 Kiall Mac Innes : > FPM is still new, and only just getting the experimental flag removed, now > is the only time to make any BC breaking cosmitic changes that will lead to > less confusion in the long run.. You are right. If changes are needed, let's make them now. > > That said - I'm n

Re: [PHP-DEV] Big patch for FPM (config and initialization)

2011-07-03 Thread Giovanni Giacobbi
On Sun, Jul 3, 2011 at 22:42, Antony Dovgal wrote: > On 07/03/2011 04:50 AM, Giovanni Giacobbi wrote: >> >> Detailed changelog of the patch: >> - Renamed options "pm.status_path", "ping.path", "ping.response" into >> a new logical group "diagnostics", so they are now respectively: >>     "diagnost

Re: [PHP-DEV] Big patch for FPM (config and initialization)

2011-07-03 Thread Michael Shadle
+1 the way for change is to add the new, add an E_DEPRECATED style warning for a point release or two, and then nix it. On Sun, Jul 3, 2011 at 2:04 PM, Kiall Mac Innes wrote: > FPM is still new, and only just getting the experimental flag removed, now > is the only time to make any BC breaking co

Re: [PHP-DEV] Big patch for FPM (config and initialization)

2011-07-03 Thread Kiall Mac Innes
FPM is still new, and only just getting the experimental flag removed, now is the only time to make any BC breaking cosmitic changes that will lead to less confusion in the long run.. That said - I'm not sure about the diagnostics group name.. Maybe allow for both the old and new naming on 5.4 an

Re: [PHP-DEV] Big patch for FPM (config and initialization)

2011-07-03 Thread Antony Dovgal
On 07/03/2011 04:50 AM, Giovanni Giacobbi wrote: Detailed changelog of the patch: - Renamed options "pm.status_path", "ping.path", "ping.response" into a new logical group "diagnostics", so they are now respectively: "diagnostics.status_path", "diagnostics.ping_path", "diagnostics.ping_respo

[PHP-DEV] Big patch for FPM (config and initialization)

2011-07-02 Thread Giovanni Giacobbi
Greetings dear devs! A few days ago I made my first nginx+php-fpm setup, and I soon realized some gaps of the current FPM implementation. First of all, the lack of documentation, which of course I know I cannot complain about, but this forced me to dig into the source code which in turn motivated