2011/7/3 Kiall Mac Innes <ki...@managedit.ie>: > FPM is still new, and only just getting the experimental flag removed, now > is the only time to make any BC breaking cosmitic changes that will lead to > less confusion in the long run..
You are right. If changes are needed, let's make them now. > > That said - I'm not sure about the diagnostics group name.. For the record, when I set them, I spent some time thinking about their name. I've put status_path in pm section because it's the page which returns stats for the pool process manager. At the time it was the right place for status_path. For ping.path and ping.response, as it was not related to pm, I've put them on their own. But I'm less convinced with the "path" label (for ping and status). I'm not sure it's clear. Maybe we can change "path" to "uri". I think ping.path and ping.response are well placed and named (except for path, see above), I don't see any reason to change them. But for status, even if it's related to PM, I'm not user it's relevant for users. Why, don't change it to status.path (or uri, or else) ? As this, Process Management has its own section (pm.*), so as ping (ping.*), status (status.*), listen (listen.*) and access logs (access.*). But I fact, we should homogenize the configuration file this way by changing: - rlimit_core to rlimit.core - rlimit_files to rlimit.files - slowlog to slowlog.log or slowlog.file or slowlog.path - request_slowlog_timeout to slowlog.request_timeout - emergency_restart_threshold to emergency_restart.threshold - emergency_restart_interval to emergency_restart.interval ++ Jerome > > Maybe allow for both the old and new naming on 5.4 and remove the old in > 5.next...? > > Kiall > On Jul 3, 2011 9:43 p.m., "Antony Dovgal" <t...@daylessday.org> wrote: >> On 07/03/2011 04:50 AM, Giovanni Giacobbi wrote: >>> Detailed changelog of the patch: >>> - Renamed options "pm.status_path", "ping.path", "ping.response" into >>> a new logical group "diagnostics", so they are now respectively: >>> "diagnostics.status_path", "diagnostics.ping_path", >>> "diagnostics.ping_response". >> >> I'm not quite sure renaming config options would help anybody, in my > opinion it would do more harm than good. >> I personally would certainly expect my existing config files to continue > to work after upgrade to 5_4. >> Yes, we're changing '3' to '4' in the version number, but that doesn't > mean we can just go ahead and break the config file. >> >> Other than that, looks ok to me (assuming you've tested it and does > continue to work the way it worked before all those cosmetic changes). >> >> -- >> Wbr, >> Antony Dovgal >> --- >> http://pinba.org - realtime profiling for PHP >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
