FPM is still new, and only just getting the experimental flag removed, now is the only time to make any BC breaking cosmitic changes that will lead to less confusion in the long run..
That said - I'm not sure about the diagnostics group name.. Maybe allow for both the old and new naming on 5.4 and remove the old in 5.next...? Kiall On Jul 3, 2011 9:43 p.m., "Antony Dovgal" <t...@daylessday.org> wrote: > On 07/03/2011 04:50 AM, Giovanni Giacobbi wrote: >> Detailed changelog of the patch: >> - Renamed options "pm.status_path", "ping.path", "ping.response" into >> a new logical group "diagnostics", so they are now respectively: >> "diagnostics.status_path", "diagnostics.ping_path", >> "diagnostics.ping_response". > > I'm not quite sure renaming config options would help anybody, in my opinion it would do more harm than good. > I personally would certainly expect my existing config files to continue to work after upgrade to 5_4. > Yes, we're changing '3' to '4' in the version number, but that doesn't mean we can just go ahead and break the config file. > > Other than that, looks ok to me (assuming you've tested it and does continue to work the way it worked before all those cosmetic changes). > > -- > Wbr, > Antony Dovgal > --- > http://pinba.org - realtime profiling for PHP > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php >
