Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-07-04 Thread Pascal MARTIN, AFUP
Le 27/06/2016 17:17, Aaron Piotrowski a écrit : Voting has opened on the RFC to change most conditions in extensions that raise E_ERROR or E_RECOVERABLE_ERROR to throw an instance of Error instead. Hi, At AFUP, we would be +1 on this RFC, as it fits well into the path started with PHP 7.0

Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-06-30 Thread Aaron Piotrowski
Hi Chris, > On Jun 30, 2016, at 6:15 AM, Christopher Jones > wrote: > > Hi Aaron, > > I was someone who spent time on the RFC template to try and get better > quality and to capture more information about each RFC. I think your > RFC needs a lot more content before going to the vote. > > Chr

Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-06-30 Thread Dan Ackroyd
On 30 June 2016 at 01:32, Pierre Joye wrote: >> It's not a language change, so doesn't seem to meet the criteria for >> needing a 2/3 pass rate. > > It is changing the core like ext/standard and other core functions. That's true, but doesn't appear to be the required test. From the Voting RFC: >

Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-06-30 Thread Christopher Jones
On 28/06/2016 1:17 AM, Aaron Piotrowski wrote: Hello, Voting has opened on the RFC to change most conditions in extensions that raise E_ERROR or E_RECOVERABLE_ERROR to throw an instance of Error instead. RFC: https://wiki.php.net/rfc/throw_error_in_extensions

Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-06-29 Thread Aaron Piotrowski
Hi Dan, > On Jun 29, 2016, at 3:41 PM, Dan Ackroyd wrote: > > For the record, I'm beginning to think the RFC process should probably > be slightly more orchestrated, and RFCs should have a "pre-vote" > announcement at least one week before the vote actually opens, when > the RFC author thinks th

Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-06-29 Thread Pierre Joye
On Jun 30, 2016 3:41 AM, "Dan Ackroyd" wrote: > > On 28 June 2016 at 03:36, Pierre Joye wrote: > > > > I like the idea. > > > > It should be 2/3 tho'. > > Why? > > It's not a language change, so doesn't seem to meet the criteria for > needing a 2/3 pass rate. It is changing the core like ext/sta

Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-06-29 Thread Dan Ackroyd
On 28 June 2016 at 03:36, Pierre Joye wrote: > > I like the idea. > > It should be 2/3 tho'. Why? It's not a language change, so doesn't seem to meet the criteria for needing a 2/3 pass rate. For the record, I'm beginning to think the RFC process should probably be slightly more orchestrated, a

Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-06-28 Thread Stanislav Malyshev
Hi! >> Voting has opened on the RFC to change most conditions in extensions that >> raise E_ERROR or E_RECOVERABLE_ERROR to throw an instance of Error instead. >> >> RFC: https://wiki.php.net/rfc/throw_error_in_extensions >> >> PR: https://git

Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-06-28 Thread Aaron Piotrowski
Hi Jakub, > On Jun 28, 2016, at 12:28 PM, Jakub Zelenka wrote: > > Hi, >> >> > Just noticed the openssl case in X509_digest and it's obviously oversight > by whoever added that bit because it should be warning as it's for all > other similar fails. I'm going to change it to warning to make it

Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-06-28 Thread Jakub Zelenka
Hi, On Mon, Jun 27, 2016 at 4:17 PM, Aaron Piotrowski wrote: > Hello, > > Voting has opened on the RFC to change most conditions in extensions that > raise E_ERROR or E_RECOVERABLE_ERROR to throw an instance of Error instead. > > RFC: https://wiki.php.net/rfc/throw_error_in_extensions < > https:

Re: [PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-06-27 Thread Pierre Joye
hi, On Mon, Jun 27, 2016 at 10:17 PM, Aaron Piotrowski wrote: > Hello, > > Voting has opened on the RFC to change most conditions in extensions that > raise E_ERROR or E_RECOVERABLE_ERROR to throw an instance of Error instead. > > RFC: https://wiki.php.net/rfc/throw_error_in_extensions >

[PHP-DEV] [RFC][Vote] Throw Error in Extensions

2016-06-27 Thread Aaron Piotrowski
Hello, Voting has opened on the RFC to change most conditions in extensions that raise E_ERROR or E_RECOVERABLE_ERROR to throw an instance of Error instead. RFC: https://wiki.php.net/rfc/throw_error_in_extensions PR: https://github.com/php/ph