Hi, On Mon, Jun 27, 2016 at 4:17 PM, Aaron Piotrowski <aa...@trowski.com> wrote:
> Hello, > > Voting has opened on the RFC to change most conditions in extensions that > raise E_ERROR or E_RECOVERABLE_ERROR to throw an instance of Error instead. > > RFC: https://wiki.php.net/rfc/throw_error_in_extensions < > https://wiki.php.net/rfc/throw_error_in_extensions> > PR: https://github.com/php/php-src/pull/1942 < > https://github.com/php/php-src/pull/1942> > > Just noticed the openssl case in X509_digest and it's obviously oversight by whoever added that bit because it should be warning as it's for all other similar fails. I'm going to change it to warning to make it consistent. In general I agree with the idea but the patch should be a bit more sensible and considers consistency with other errors in the extension. It should be also reviewed by all active maintainers or regular contributors to the changed extensions before it gets merged so it might be a bit late for 7.1 Cheers Jakub
