[PHP-DEV] Re: PHP 5.2.8 Released

2008-12-09 Thread Michael Sisolak
The 5.2.8 zip files for Windows (thread and non-thread safe) don't include msql.dll or ntwdblib.dll. They were in 5.2.6 and 5.2.7. Is this a mistake? Michael Sisolak [EMAIL PROTECTED] -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.ph

Re: [PHP-DEV] PHP 5.1.2 Release Plan

2005-12-01 Thread Michael Sisolak
As per the notes at http://www.php.net/~derick/meeting-notes.html, section 2.4.2: 'We make "var" an alias for "public" and remove the warning for it.' Could something like the attached patch be included as part of 5.1.2? Michel Sisolak [EMAIL PROTECTED] ___

Re: [PHP-DEV] Debugging possible Apache php_admin_value crash - Win32 crash trace possible?

2005-11-17 Thread Michael Sisolak
y reproduce the load and page usage of real users. I can't speak at all to if I do or don't see the same issue in 5.1 yet. Michael --- Jani Taskinen <[EMAIL PROTECTED]> wrote: > > Then there is no problem. Next please. :) > > --Jani > &

Re: [PHP-DEV] Debugging possible Apache php_admin_value crash - Win32 crash trace possible?

2005-11-17 Thread Michael Sisolak
> > --Jani > > On Wed, 16 Nov 2005, Michael Sisolak wrote: > > > > > I'm trying to debug an issue I'm seeing with PHP 5.0.5 and Apache > > 2.0.55 (using apache2handler SAPI) running under Windows 2000 > Server. > > I need to set the mssq

[PHP-DEV] Debugging possible Apache php_admin_value crash - Win32 crash trace possible?

2005-11-16 Thread Michael Sisolak
ts the process. Is there any magic that can be used to tell Apache to let the error fall though so it can be caught by Dr. Watson or something similar? Or a way to tell PHP to at least record where the violation occurs on the crash? Michael Sisolak [EMAIL PROTECTED] __

[PHP-DEV] [PATCH] adding "--without-t1lib" for win32 GD configure

2005-06-30 Thread Michael Sisolak
t1lib. Thanks. Michael Sisolak [EMAIL PROTECTED] __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com --- config.w32.orig Thu Jun 30 10:15:57 2005 +++ config.w32 Thu Jun 30 10:13:40 2005

Re: [PHP-DEV] Win32 php4ts.dll 875k Larger in 5.1?

2005-06-28 Thread Michael Sisolak
Derick, I did a quick build without the date extension and php5ts.dll dropped 296kb. I did some additional digging. Some of the additional is because of the new PDO object, and some becuase PCRElib doubled in size. But the object file that really jumped in size was zend_execute.obj: from 271kb

Re: [PHP-DEV] Win32 php4ts.dll 875k Larger in 5.1?

2005-06-28 Thread Michael Sisolak
Sorry - that was a typo. It is already named php5ts.dll. Michael > Should it be named php4ts? > > Andrey __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com -- PHP Internals - PHP Runtime Dev

[PHP-DEV] Win32 php4ts.dll 875k Larger in 5.1?

2005-06-27 Thread Michael Sisolak
The default build of php4ts.dll has grown from 3,421k in 5.0.4 to 4,297k in 5.1.0b2 (an increase of over 25%). Does anyone know what the change was that had such a dramatic effect on the size of the DLL? Michael Sisolak [EMAIL PROTECTED

Re: [PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929)

2004-07-20 Thread Michael Sisolak
Andi, Yahoo in the sent mail shows the attachment, but it didn't show up in the list. I've posted it at: http://aduni.org/~msisolak/php5isapi.c.patch This is for the PHP_5_0 branch. I believe that for HEAD the change would just be to use STR_EMPTY_ALLOC() at the end of sapi_isapi_read_cookes()

[PHP-DEV] [PATCH] 5.0 ISAPI cookie string free fix (#28929)

2004-07-20 Thread Michael Sisolak
lue. For HEAD this patch would be easier becuase of the recent removal of empty_string - just return STR_EMPTY_ALLOC() and keep the efree() as is. Michael Sisolak [EMAIL PROTECTED] __ Do you Yahoo!? New and Improved Yahoo! Mail -

Re: [PHP-DEV] 5.0.0RC2: Why is DEBUG_FILE_UPLOAD always on now?

2004-05-11 Thread Michael Sisolak
gt; committed a fix to CVS, can you please verify if that fixes it? Derick, That works for me - thanks for the quick fix. Michael Sisolak [EMAIL PROTECTED] __ Do you Yahoo!? Win a $20,000 Career Makeover at Yahoo! HotJobs http://ho

[PHP-DEV] 5.0.0RC2: Why is DEBUG_FILE_UPLOAD always on now?

2004-05-11 Thread Michael Sisolak
AD #else #undef DEBUG_FILE_UPLOAD #endif would make more sense instead. Having a form with an empty upload field shouldn't be a PHP system level error should it? Isn't that really something for the script to handle? Michael Sisolak [EMAIL PROTECTED]

Re: [PHP-DEV] PHP5 Win32 Build w/o XML Link Failure

2004-02-19 Thread Michael Sisolak
gt; That error can probably be solved by disabling the iconv extension > though. > > It is safe to ignore errors when nmaking clean. > > --Wez. > > - Original Message - > From: "Michael Sisolak" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]>

[PHP-DEV] PHP5 Win32 Build w/o XML Link Failure

2004-02-19 Thread Michael Sisolak
e_TS\php5ts.dll Cleaning build dirs rmdir /s /q Release_TS\php-5.0.0RC1-dev The system cannot find the file specified. Michael Sisolak [EMAIL PROTECTED] __ Do you Yahoo!? Yahoo! Mail SpamGuard - Read only the mail you want. http://antispam.yahoo.com/tools -

[PHP-DEV] Memory Leaks in Win32 PHP 5.0.0b4

2004-02-17 Thread Michael Sisolak
malloc is freed. Attached is my take on a fix for this by leaving the new_path variable available so that it can be freed at the end of the function. There may be a cleaner way to do this, but this patch is one approach. Michael Sisolak [EMAIL PROTECTED] __ Do yo

[PHP-DEV] [REPOST] MFH Request for Zend.c for Memory Leak

2004-01-16 Thread Michael Sisolak
.5RC1. Michael Sisolak [EMAIL PROTECTED] __ Do you Yahoo!? Yahoo! Hotjobs: Enter the "Signing Bonus" Sweepstakes http://hotjobs.sweepstakes.yahoo.com/signingbonus--- zend.c.orig Wed Oct 22 18:47:18 2003 +++ zend.c Fri Jan 16 10:41:53 2004 @

[PHP-DEV] MFH Request for Zend.c

2004-01-04 Thread Michael Sisolak
GLOBAL_CONSTANTS_TABLE is currently not getting freed on thread shutdown) so that the bottom of zend_shutdown() looks like: #ifndef ZTS zend_shutdown_constants(); #else zend_hash_destroy(GLOBAL_CONSTANTS_TABLE); free(GLOBAL_CONSTANTS_TABLE); #endif Michael Sisolak [EMAIL PROTECTED

[PHP-DEV] [REPOST] TSRM.c MFH Request

2003-12-16 Thread Michael Sisolak
I know MFHing memory leaks isn't anywhere near as exciting as arguing about the fine points of CSV file processing, but can someone with enough karma please take a minute to look at my request? Thanks. > Date: Sun, 7 Dec 2003 19:17:06 -0800 (PST) > From: Michael Sisolak <[E

[PHP-DEV] Should tsrm_shutdown() be calling resource_types_table dtors?

2003-12-08 Thread Michael Sisolak
t calling all destructors, and then freeing all items). This eliminates a huge pile of thread shutdown memory leaks for ISAPI and Win32 CLI. Is there a reason not to do this (i.e., I can't test non-Win32 builds so maybe there is a reason this isn't done this way)

[PHP-DEV] TSRM.c MFH Request

2003-12-07 Thread Michael Sisolak
Can someone with proper karma please MFH the change in TSRM.c version 1.50 - it never made it back into the 4_3 branch. It cleans up a memory leak of the mutexp variable under Win32 threading. Thanks. Michael Sisolak [EMAIL PROTECTED] __ Do you Yahoo!? Free Pop

[PHP-DEV] Re: PHP4 CLI/ISAPI not calling module destructors?

2003-12-07 Thread Michael Sisolak
srm_shutdown() in the ISAPI many, many leaks disappear (as the dtors get called). Rather than a call to ts_free_thread() before each tsrm_shutdown(), should tsrm_shutdown() itself be calling ts_free_thread() before it does anything else? Michael Sisolak [EMAIL PROTECTED]

[PHP-DEV] PHP4 CLI/ISAPI not calling module destructors?

2003-12-07 Thread Michael Sisolak
ng where these dtors should be getting called? If I add a ts_free_thread() before the final tsrm_shutdown() in php_cli.c then in my testing (all Win32) the dtors do then get called correctly. Michael Sisolak [EMAIL PROTECTED] __ Do you Yahoo!? Free Pop-Up Block

Re: [PHP-DEV] [FIX] Bug #25585: PHP crash if executed MSSQL-query with RAISERROR() call and error 515

2003-12-01 Thread Michael Sisolak
--- "Frank M. Kromann" <[EMAIL PROTECTED]> wrote: > I'm running on Windows XP and using MSSQL server 7.0 and 2000 both > with the latest service packs. > > PHP 4.3.5-dev (cli) (built: Nov 4 2003 16:23:54) > Copyright (c) 1997-2003 The PHP Group > Zend Engine v1.3.0, Copyright (c) 1998-2003 Zend

Re: [PHP-DEV] [FIX] Bug #25585: PHP crash if executed MSSQL-query with RAISERROR() call and error 515

2003-12-01 Thread Michael Sisolak
> empty > > result sets too early becuase it's looking for SUCCEED instead of > > NO_MORE_RESULTS. Changing this code to: > > > > while ((num_fields = dbnumcols(mssql_ptr->link)) <= 0 && retvalue > != > > N

[PHP-DEV] [FIX] Bug #25585: PHP crash if executed MSSQL-query with RAISERROR() call and error 515

2003-11-30 Thread Michael Sisolak
g report to be correctly displayed and eliminates the fault. Michael Sisolak [EMAIL PROTECTED] __ Do you Yahoo!? Free Pop-Up Blocker - Get it now http://companion.yahoo.com/ -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Re: ZTS issues

2003-11-19 Thread Michael Sisolak
--- Rob Richards <[EMAIL PROTECTED]> wrote: > If the hash free were moved to php_url_scanner_ex_deactivate(), then > it would always need to be malloc'd on each new request. Though this > is an option, it seems the point of ZTS was to reduce the amount of > malloc/frees needed and reuse memory (p

Re: [PHP-DEV] Re: ZTS issues

2003-11-18 Thread Michael Sisolak
--- Rob Richards <[EMAIL PROTECTED]> wrote: > To check the memory, I had _CrtDumpMemoryLeaks() log to a file after > the tsrm_shutdown to test final leaks. Had to step through the code > otherwise for other parts as the system would bail out without any > indication of where. For the patch, the c

[PHP-DEV] Re: ZTS issues

2003-11-17 Thread Michael Sisolak
that this change would be causes PHP to have to reinitialize with each request. Is there a specific issue that you were able to fix with this change? Michael Sisolak [EMAIL PROTECTED] __ Do you Yahoo!? Protect your identity with Yahoo! Mail AddressGuard http://a