--- Rob Richards <[EMAIL PROTECTED]> wrote: > If the hash free were moved to php_url_scanner_ex_deactivate(), then > it would always need to be malloc'd on each new request. Though this > is an option, it seems the point of ZTS was to reduce the amount of > malloc/frees needed and reuse memory (pretty much why I wasnt > supposed to add the ts_free_thread calls at the end of the requests). > For a non-ZTS build, the hash is destroyed in the > PHP_MSHUTDOWN_FUNCTION(url_scanner) and as it should be > running on the same thread for the requests, this should be fine. > > It possibly could be moved to the basic_globals_dtor function as that > is called by non-ZTS builds as well in PHP_MSHUTDOWN_FUNCTION(basic). > Then it would all be in a common place.
Rob, That explination makes a lot of sense. I'm +1 on having a ZTS/non-ZTS common free for BG(url_adapt_state_ex).tags in basic_globals_dtor(). Michael __________________________________ Do you Yahoo!? Protect your identity with Yahoo! Mail AddressGuard http://antispam.yahoo.com/whatsnewfree -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
